From 873fc780364f3d623054c06d4497a1fb68c47074 Mon Sep 17 00:00:00 2001
From: Amar Singh <asinghchrony@protonmail.com>
Date: Thu, 29 Feb 2024 09:44:10 -0500
Subject: [PATCH] Add benchmarking compilation check to CI (#131)

* add benchmarking req to ci

* fix compilation error for feature runtime benchmarks

* remove ReachableDest because it is not part of config even with features runtime benchmarks

* add release flag
---
 .github/workflows/cargo-tests.yml | 3 +++
 runtime/src/xcm_config.rs         | 7 -------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/cargo-tests.yml b/.github/workflows/cargo-tests.yml
index 59e0cdd..fdb5cad 100644
--- a/.github/workflows/cargo-tests.yml
+++ b/.github/workflows/cargo-tests.yml
@@ -70,6 +70,9 @@ jobs:
 
       - name: Run tests
         run: cargo test --release
+      
+      - name: Check benchmarking compilation
+        run: cargo check --release --features runtime-benchmarks
 
       - name: Check clippy
         run: cargo clippy --release --locked --all-targets -- -D warnings
diff --git a/runtime/src/xcm_config.rs b/runtime/src/xcm_config.rs
index 0d73a7a..6a3065b 100644
--- a/runtime/src/xcm_config.rs
+++ b/runtime/src/xcm_config.rs
@@ -183,11 +183,6 @@ pub type XcmRouter = WithUniqueTopic<(
     XcmpQueue,
 )>;
 
-#[cfg(feature = "runtime-benchmarks")]
-parameter_types! {
-    pub ReachableDest: Option<MultiLocation> = Some(Parent.into());
-}
-
 parameter_types! {
     pub const MaxLockers: u32 = 8;
     pub const MaxRemoteLockConsumers: u32 = 0;
@@ -202,8 +197,6 @@ impl pallet_xcm::Config for Runtime {
     type ExecuteXcmOrigin = EnsureXcmOrigin<RuntimeOrigin, LocalOriginToLocation>;
     type MaxLockers = MaxLockers;
     type MaxRemoteLockConsumers = MaxLockers;
-    #[cfg(feature = "runtime-benchmarks")]
-    type ReachableDest = ReachableDest;
     type RemoteLockConsumerIdentifier = ();
     type RuntimeCall = RuntimeCall;
     type RuntimeEvent = RuntimeEvent;