From 3e89fba7c070ae94c232401fd02b45d9e7130437 Mon Sep 17 00:00:00 2001 From: Kurdistan Tech Ministry Date: Wed, 24 Dec 2025 07:19:29 +0300 Subject: [PATCH] fix: add subxt native feature propagation to umbrella node feature MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pezkuwi-subxt, pezkuwi-subxt-rpcs, and pezkuwi-subxt-lightclient all require either 'native' or 'web' feature to be enabled. When umbrella's node feature enables these dependencies with default-features = false, the default 'native' feature is not propagated, causing compile_error! in all three crates. Added "dep?/native" propagation for all three subxt crates in the node feature. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --- .claude/WORKFLOW_PLAN.md | 24 +++++++++++++++--------- umbrella/Cargo.toml | 3 +++ 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/.claude/WORKFLOW_PLAN.md b/.claude/WORKFLOW_PLAN.md index 5eb3f5b7..d4791220 100644 --- a/.claude/WORKFLOW_PLAN.md +++ b/.claude/WORKFLOW_PLAN.md @@ -19,8 +19,8 @@ | Job | Durum | Lokal Test Komutu | |-----|-------|-------------------| -| `check-toml-format` | ❌ | `taplo format --check --config .config/taplo.toml` | -| `check-markdown` | ❌ | `markdownlint --config .github/.markdownlint.yaml --ignore target --ignore vendor .` | +| `check-toml-format` | ✅ | `taplo format --check --config .config/taplo.toml` | +| `check-markdown` | ✅ | `markdownlint --config .github/.markdownlint.yaml --ignore target --ignore vendor .` | | `fmt` | ✅ | `cargo fmt --all -- --check` | | `check-zepter` | ✅ | `zepter run check` | | `check-workspace` | ✅ | `python3 .github/scripts/check-workspace.py .` | @@ -45,8 +45,8 @@ markdownlint --config .github/.markdownlint.yaml --ignore target --ignore vendor | Job | Durum | Lokal Test Komutu | |-----|-------|-------------------| -| `cargo-clippy` | ❌ | `RUSTFLAGS="-D warnings" SKIP_WASM_BUILD=1 cargo clippy --all-targets --all-features --locked --workspace --quiet` | -| `check-try-runtime` | ❌ | Aşağıdaki 3 komut sırayla çalıştırılmalı | +| `cargo-clippy` | ✅ | `RUSTFLAGS="-D warnings" SKIP_WASM_BUILD=1 cargo clippy --all-targets --all-features --locked --workspace --quiet` | +| `check-try-runtime` | ✅ | Aşağıdaki 3 komut sırayla çalıştırılmalı | | `check-core-crypto-features` | ✅ | Aşağıdaki 3 script çalıştırılmalı | **check-try-runtime komutları:** @@ -178,6 +178,12 @@ AŞAMA 4 - EVM/PolkaVM: | Tarih | Düzeltme | Etki | |-------|----------|------| +| 2024-12-24 | Umbrella node feature'ına subxt native propagation eklendi | check-try-runtime | +| 2024-12-24 | Vendor crate rebrand düzeltmeleri (sp_* -> pezsp_*) | cargo-clippy | +| 2024-12-24 | Subxt examples artifact paths düzeltildi | cargo-clippy | +| 2024-12-24 | Subxt examples type conversion düzeltmeleri | cargo-clippy | +| 2024-12-24 | Zombienet-sdk test type düzeltmeleri | cargo-clippy | +| 2024-12-24 | TOML format düzeltildi (umbrella/Cargo.toml) | check-toml-format | | 2024-12-23 | Umbrella'ya pezpallet-root-testing eklendi | check-try-runtime | | 2024-12-23 | Umbrella'ya pezpallet-xcm-benchmarks eklendi | Runtime build | | 2024-12-23 | Subxt runtime-full'dan çıkarıldı | getrandom WASM fix | @@ -189,13 +195,13 @@ AŞAMA 4 - EVM/PolkaVM: ## Şu An Yapılması Gereken -1. `taplo format --config .config/taplo.toml` çalıştır -2. Değişiklikleri commit et -3. `RUSTFLAGS="-D warnings" SKIP_WASM_BUILD=1 cargo clippy --all-targets --all-features --locked --workspace --quiet` çalıştır -4. Hataları düzelt +1. ✅ `taplo format --config .config/taplo.toml` - TAMAMLANDI +2. ✅ `cargo clippy` düzeltmeleri - TAMAMLANDI +3. ✅ `check-try-runtime` komutları - TAMAMLANDI (subxt native feature propagation eklendi) +4. Build-publish-images ve diğer build job'larını test et 5. Commit ve push yap 6. CI'da test et --- -*Son Güncelleme: 2024-12-23* +*Son Güncelleme: 2024-12-24* diff --git a/umbrella/Cargo.toml b/umbrella/Cargo.toml index a548e0ca..49406ba4 100644 --- a/umbrella/Cargo.toml +++ b/umbrella/Cargo.toml @@ -1067,12 +1067,15 @@ node = [ "pezkuwi-statement-distribution", "pezkuwi-statement-table", "pezkuwi-subxt", + "pezkuwi-subxt?/native", "pezkuwi-subxt-codegen", "pezkuwi-subxt-core", "pezkuwi-subxt-lightclient", + "pezkuwi-subxt-lightclient?/native", "pezkuwi-subxt-macro", "pezkuwi-subxt-metadata", "pezkuwi-subxt-rpcs", + "pezkuwi-subxt-rpcs?/native", "pezkuwi-subxt-signer", "pezkuwi-subxt-utils-fetchmetadata", "pezkuwi-subxt-utils-stripmetadata",