fix: Resolve cargo clippy errors and add CI workflow plan

## Changes

### Clippy Fixes
- Fixed deprecated `cargo_bin` usage in 27 test files (added #![allow(deprecated)])
- Fixed uninlined_format_args in zombienet-sdk-tests
- Fixed subxt API changes in revive/rpc/tests.rs (fetch signature, StorageValue)
- Fixed dead_code warnings in validator-pool and identity-kyc mocks
- Fixed field name `i` -> `_i` in tasks example

### CI Infrastructure
- Added .claude/WORKFLOW_PLAN.md for tracking CI fix progress
- Updated lychee.toml and taplo.toml configs

### Files Modified
- 27 test files with deprecated cargo_bin fix
- bizinikiwi/pezframe/revive/rpc/src/tests.rs (subxt API)
- pezkuwi/pezpallets/validator-pool/src/{mock,tests}.rs
- pezcumulus/teyrchains/pezpallets/identity-kyc/src/mock.rs
- bizinikiwi/pezframe/examples/tasks/src/tests.rs

## Status
- cargo clippy: PASSING
- Next: cargo fmt, zepter, workspace checks
This commit is contained in:
2025-12-22 16:36:14 +03:00
parent 8acf59c6aa
commit 65b7f5e640
1393 changed files with 17834 additions and 179151 deletions
+118 -118
View File
@@ -59,139 +59,139 @@ log = { workspace = true, default-features = true }
rand = { workspace = true, default-features = true }
serde = { features = ["derive"], workspace = true, default-features = true }
serde_json = { workspace = true, default-features = true }
subxt-signer = { workspace = true, features = ["unstable-eth"] }
pezkuwi-subxt-signer = { workspace = true, features = ["unstable-eth"] }
# The Pezkuwi-SDK:
pezkuwi-sdk = { features = [
"pez-fork-tree",
"pezframe-benchmarking-cli",
"frame-remote-externalities",
"pezframe-support-procedural-tools",
"pez-generate-bags",
"pezmmr-gadget",
"pezmmr-rpc",
"pezpallet-transaction-payment-rpc",
"pezsc-allocator",
"pezsc-authority-discovery",
"pezsc-basic-authorship",
"pezsc-block-builder",
"pezsc-chain-spec",
"pezsc-cli",
"pezsc-client-api",
"pezsc-client-db",
"pezsc-consensus",
"pezsc-consensus-aura",
"pezsc-consensus-babe",
"pezsc-consensus-babe-rpc",
"pezsc-consensus-beefy",
"pezsc-consensus-beefy-rpc",
"pezsc-consensus-epochs",
"pezsc-consensus-grandpa",
"pezsc-consensus-grandpa-rpc",
"pezsc-consensus-manual-seal",
"pezsc-consensus-pow",
"pezsc-consensus-slots",
"pezsc-executor",
"pezsc-executor-common",
"pezsc-executor-polkavm",
"pezsc-executor-wasmtime",
"pezsc-informant",
"pezsc-keystore",
"pezsc-mixnet",
"pezsc-network",
"pezsc-network-common",
"pezsc-network-gossip",
"pezsc-network-light",
"pezsc-network-statement",
"pezsc-network-sync",
"pezsc-network-transactions",
"pezsc-network-types",
"pezsc-offchain",
"pezsc-proposer-metrics",
"pezsc-rpc",
"pezsc-rpc-api",
"pezsc-rpc-server",
"pezsc-rpc-spec-v2",
"pezsc-service",
"pezsc-state-db",
"pezsc-statement-store",
"pezsc-storage-monitor",
"pezsc-sync-state-rpc",
"pezsc-sysinfo",
"pezsc-telemetry",
"pezsc-tracing",
"pezsc-transaction-pool",
"pezsc-transaction-pool-api",
"pezsc-utils",
"pezsp-api",
"pezsp-blockchain",
"pezsp-consensus",
"pezsp-core",
"pezsp-core-hashing",
"pezsp-core-hashing-proc-macro",
"pezsp-database",
"pezsp-inherents",
"pezsp-io",
"pezsp-keystore",
"pezsp-maybe-compressed-blob",
"pezsp-mmr-primitives",
"pezsp-panic-handler",
"pezsp-rpc",
"pezsp-statement-store",
"pezsp-timestamp",
"pezsp-tracing",
"pezsp-transaction-storage-proof",
"pezstaging-chain-spec-builder",
"pezstaging-node-inspect",
"pezstaging-tracking-allocator",
"std",
"pez-subkey",
"bizinikiwi-build-script-utils",
"bizinikiwi-frame-rpc-support",
"bizinikiwi-frame-rpc-system",
"bizinikiwi-prometheus-endpoint",
"bizinikiwi-rpc-client",
"bizinikiwi-state-trie-migration-rpc",
"bizinikiwi-wasm-builder",
"pez-tracing-gum",
"bizinikiwi-build-script-utils",
"bizinikiwi-frame-rpc-support",
"bizinikiwi-frame-rpc-system",
"bizinikiwi-prometheus-endpoint",
"bizinikiwi-rpc-client",
"bizinikiwi-state-trie-migration-rpc",
"bizinikiwi-wasm-builder",
"frame-remote-externalities",
"pez-fork-tree",
"pez-generate-bags",
"pez-subkey",
"pez-tracing-gum",
"pezframe-benchmarking-cli",
"pezframe-support-procedural-tools",
"pezmmr-gadget",
"pezmmr-rpc",
"pezpallet-transaction-payment-rpc",
"pezsc-allocator",
"pezsc-authority-discovery",
"pezsc-basic-authorship",
"pezsc-block-builder",
"pezsc-chain-spec",
"pezsc-cli",
"pezsc-client-api",
"pezsc-client-db",
"pezsc-consensus",
"pezsc-consensus-aura",
"pezsc-consensus-babe",
"pezsc-consensus-babe-rpc",
"pezsc-consensus-beefy",
"pezsc-consensus-beefy-rpc",
"pezsc-consensus-epochs",
"pezsc-consensus-grandpa",
"pezsc-consensus-grandpa-rpc",
"pezsc-consensus-manual-seal",
"pezsc-consensus-pow",
"pezsc-consensus-slots",
"pezsc-executor",
"pezsc-executor-common",
"pezsc-executor-polkavm",
"pezsc-executor-wasmtime",
"pezsc-informant",
"pezsc-keystore",
"pezsc-mixnet",
"pezsc-network",
"pezsc-network-common",
"pezsc-network-gossip",
"pezsc-network-light",
"pezsc-network-statement",
"pezsc-network-sync",
"pezsc-network-transactions",
"pezsc-network-types",
"pezsc-offchain",
"pezsc-proposer-metrics",
"pezsc-rpc",
"pezsc-rpc-api",
"pezsc-rpc-server",
"pezsc-rpc-spec-v2",
"pezsc-service",
"pezsc-state-db",
"pezsc-statement-store",
"pezsc-storage-monitor",
"pezsc-sync-state-rpc",
"pezsc-sysinfo",
"pezsc-telemetry",
"pezsc-tracing",
"pezsc-transaction-pool",
"pezsc-transaction-pool-api",
"pezsc-utils",
"pezsp-api",
"pezsp-blockchain",
"pezsp-consensus",
"pezsp-core",
"pezsp-core-hashing",
"pezsp-core-hashing-proc-macro",
"pezsp-database",
"pezsp-inherents",
"pezsp-io",
"pezsp-keystore",
"pezsp-maybe-compressed-blob",
"pezsp-mmr-primitives",
"pezsp-panic-handler",
"pezsp-rpc",
"pezsp-statement-store",
"pezsp-timestamp",
"pezsp-tracing",
"pezsp-transaction-storage-proof",
"pezstaging-chain-spec-builder",
"pezstaging-node-inspect",
"pezstaging-tracking-allocator",
"std",
], workspace = true, default-features = true }
# Direct dependency needed (not through umbrella due to macro visibility issues)
pezsp-runtime = { workspace = true }
# Shared code between the staging node and kitchensink runtime:
pez-kitchensink-runtime = { workspace = true }
node-inspect = { optional = true, workspace = true, default-features = true }
pez-kitchensink-runtime = { workspace = true }
pez-node-primitives = { workspace = true, default-features = true }
pez-node-rpc = { workspace = true }
[dev-dependencies]
assert_cmd = { workspace = true }
criterion = { features = [
"async_tokio",
"async_tokio",
], workspace = true, default-features = true }
nix = { features = ["signal"], workspace = true }
pezsp-keyring = { workspace = true }
pretty_assertions.workspace = true
regex = { workspace = true }
scale-info = { features = [
"derive",
"serde",
"derive",
"serde",
], workspace = true, default-features = true }
soketto = { workspace = true }
pezsp-keyring = { workspace = true }
tempfile = { workspace = true }
tokio = { features = [
"macros",
"parking_lot",
"time",
"macros",
"parking_lot",
"time",
], workspace = true, default-features = true }
tokio-util = { features = ["compat"], workspace = true }
wat = { workspace = true }
# These testing-only dependencies are not exported by the Pezkuwi-SDK crate:
bizinikiwi-cli-test-utils = { workspace = true }
pez-node-testing = { workspace = true }
pezsc-service-test = { workspace = true }
bizinikiwi-cli-test-utils = { workspace = true }
[build-dependencies]
clap = { optional = true, workspace = true }
@@ -200,29 +200,29 @@ clap_complete = { optional = true, workspace = true }
node-inspect = { optional = true, workspace = true, default-features = true }
pezkuwi-sdk = { features = [
"pezframe-benchmarking-cli",
"pezsc-cli",
"pezsc-storage-monitor",
"bizinikiwi-build-script-utils",
"bizinikiwi-build-script-utils",
"pezframe-benchmarking-cli",
"pezsc-cli",
"pezsc-storage-monitor",
], optional = true, workspace = true, default-features = true }
[features]
default = ["cli"]
cli = ["clap", "clap_complete", "node-inspect", "pezkuwi-sdk"]
runtime-benchmarks = [
"pez-kitchensink-runtime/runtime-benchmarks",
"node-inspect?/runtime-benchmarks",
"pez-node-primitives/runtime-benchmarks",
"pez-node-rpc/runtime-benchmarks",
"pez-node-testing/runtime-benchmarks",
"pezkuwi-sdk/runtime-benchmarks",
"pezsc-service-test/runtime-benchmarks",
"pezsp-keyring/runtime-benchmarks",
"pezsp-runtime/runtime-benchmarks",
"bizinikiwi-cli-test-utils/runtime-benchmarks",
"bizinikiwi-cli-test-utils/runtime-benchmarks",
"node-inspect?/runtime-benchmarks",
"pez-kitchensink-runtime/runtime-benchmarks",
"pez-node-primitives/runtime-benchmarks",
"pez-node-rpc/runtime-benchmarks",
"pez-node-testing/runtime-benchmarks",
"pezkuwi-sdk/runtime-benchmarks",
"pezsc-service-test/runtime-benchmarks",
"pezsp-keyring/runtime-benchmarks",
"pezsp-runtime/runtime-benchmarks",
]
try-runtime = [
"pez-kitchensink-runtime/try-runtime",
"pezkuwi-sdk/try-runtime",
"bizinikiwi-cli-test-utils/try-runtime",
"bizinikiwi-cli-test-utils/try-runtime",
"pez-kitchensink-runtime/try-runtime",
"pezkuwi-sdk/try-runtime",
]
+3 -3
View File
@@ -454,7 +454,7 @@ pub(crate) mod tests {
.build()
}
fn eth_account(from: subxt_signer::eth::Keypair) -> AccountId32 {
fn eth_account(from: pezkuwi_subxt_signer::eth::Keypair) -> AccountId32 {
let mut account_id = AccountId32::new([0xEE; 32]);
<AccountId32 as AsMut<[u8; 32]>>::as_mut(&mut account_id)[..20]
.copy_from_slice(&from.public_key().to_account_id().as_ref());
@@ -504,8 +504,8 @@ pub(crate) mod tests {
#[test]
fn ensure_eth_accounts_are_in_endowed() {
let alith = eth_account(subxt_signer::eth::dev::alith());
let baltathar = eth_account(subxt_signer::eth::dev::baltathar());
let alith = eth_account(pezkuwi_subxt_signer::eth::dev::alith());
let baltathar = eth_account(pezkuwi_subxt_signer::eth::dev::baltathar());
let endowed = well_known_including_eth_accounts();
+4 -6
View File
@@ -33,6 +33,7 @@ use pez_kitchensink_runtime::RuntimeApi;
use pez_node_primitives::Block;
use pezframe_benchmarking_cli::BIZINIKIWI_REFERENCE_HARDWARE;
use pezframe_system_rpc_runtime_api::AccountNonceApi;
use pezkuwi_sdk::{pezsp_api::ProvideRuntimeApi, pezsp_core::crypto::Pair};
use pezsc_client_api::{Backend, BlockBackend};
use pezsc_consensus_babe::{self, SlotProportion};
use pezsc_network::{
@@ -46,8 +47,6 @@ use pezsc_statement_store::Store as StatementStore;
use pezsc_telemetry::{Telemetry, TelemetryWorker};
use pezsc_transaction_pool::TransactionPoolHandle;
use pezsc_transaction_pool_api::OffchainTransactionPoolFactory;
use pezkuwi_sdk::pezsp_api::ProvideRuntimeApi;
use pezkuwi_sdk::pezsp_core::crypto::Pair;
use pezsp_runtime::{generic, traits::Block as BlockT, SaturatedConversion};
use std::{path::Path, sync::Arc};
@@ -623,7 +622,8 @@ pub fn new_full_base<N: NetworkBackend<Block, <Block as BlockT>::Hash>>(
create_inherent_data_providers: move |parent, ()| {
let client_clone = client_clone.clone();
async move {
let timestamp = pezkuwi_sdk::pezsp_timestamp::InherentDataProvider::from_system_time();
let timestamp =
pezkuwi_sdk::pezsp_timestamp::InherentDataProvider::from_system_time();
let slot =
pezkuwi_sdk::pezsp_consensus_babe::inherents::InherentDataProvider::from_timestamp_and_slot_duration(
@@ -886,9 +886,7 @@ mod tests {
pezsp_core::crypto::Pair,
pezsp_inherents::InherentDataProvider,
pezsp_keystore::KeystorePtr,
pezsp_timestamp,
pezsp_tracing,
*,
pezsp_timestamp, pezsp_tracing, *,
};
use pezsc_client_api::BlockBackend;
use pezsc_consensus::{BlockImport, BlockImportParams, ForkChoiceStrategy};
@@ -1,5 +1,6 @@
// This file is part of Bizinikiwi.
#![allow(deprecated)]
// Copyright (C) Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
@@ -16,6 +16,8 @@
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
#![allow(deprecated)]
use assert_cmd::cargo::cargo_bin;
use std::process::Command;
use tempfile::tempdir;
@@ -16,6 +16,8 @@
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
#![allow(deprecated)]
use assert_cmd::cargo::cargo_bin;
use std::process::Command;
@@ -16,6 +16,8 @@
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
#![allow(deprecated)]
use assert_cmd::cargo::cargo_bin;
use std::process::Command;
use tempfile::tempdir;
@@ -1,5 +1,6 @@
// This file is part of Bizinikiwi.
#![allow(deprecated)]
// Copyright (C) Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
@@ -1,5 +1,6 @@
// This file is part of Bizinikiwi.
#![allow(deprecated)]
// Copyright (C) Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
@@ -1,5 +1,6 @@
// This file is part of Bizinikiwi.
#![allow(deprecated)]
// Copyright (C) Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
@@ -16,6 +16,8 @@
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
#![allow(deprecated)]
use assert_cmd::cargo::cargo_bin;
use std::process::Command;
use tempfile::tempdir;
@@ -1,5 +1,6 @@
// This file is part of Bizinikiwi.
#![allow(deprecated)]
// Copyright (C) Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
@@ -1,5 +1,6 @@
// This file is part of Bizinikiwi.
#![allow(deprecated)]
// Copyright (C) Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
@@ -1,5 +1,6 @@
// This file is part of Bizinikiwi.
#![allow(deprecated)]
// Copyright (C) Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
@@ -16,6 +16,8 @@
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
#![allow(deprecated)]
use assert_cmd::cargo::cargo_bin;
use std::process::Command;
use tempfile::tempdir;
@@ -1,5 +1,6 @@
// This file is part of Bizinikiwi.
#![allow(deprecated)]
// Copyright (C) Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
@@ -16,6 +16,8 @@
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
#![allow(deprecated)]
use assert_cmd::cargo::cargo_bin;
use std::{process, time::Duration};
@@ -1,5 +1,6 @@
// This file is part of Bizinikiwi.
#![allow(deprecated)]
// Copyright (C) Parity Technologies (UK) Ltd.
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
+2
View File
@@ -16,6 +16,8 @@
// You should have received a copy of the GNU General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
#![allow(deprecated)]
use assert_cmd::cargo::cargo_bin;
use regex::Regex;
use std::process::Command;