fix: Resolve cargo clippy errors and add CI workflow plan
## Changes
### Clippy Fixes
- Fixed deprecated `cargo_bin` usage in 27 test files (added #![allow(deprecated)])
- Fixed uninlined_format_args in zombienet-sdk-tests
- Fixed subxt API changes in revive/rpc/tests.rs (fetch signature, StorageValue)
- Fixed dead_code warnings in validator-pool and identity-kyc mocks
- Fixed field name `i` -> `_i` in tasks example
### CI Infrastructure
- Added .claude/WORKFLOW_PLAN.md for tracking CI fix progress
- Updated lychee.toml and taplo.toml configs
### Files Modified
- 27 test files with deprecated cargo_bin fix
- bizinikiwi/pezframe/revive/rpc/src/tests.rs (subxt API)
- pezkuwi/pezpallets/validator-pool/src/{mock,tests}.rs
- pezcumulus/teyrchains/pezpallets/identity-kyc/src/mock.rs
- bizinikiwi/pezframe/examples/tasks/src/tests.rs
## Status
- cargo clippy: PASSING
- Next: cargo fmt, zepter, workspace checks
This commit is contained in:
@@ -29,11 +29,9 @@ indexmap = { workspace = true }
|
||||
itertools = { workspace = true }
|
||||
linked-hash-map = { workspace = true }
|
||||
parking_lot = { workspace = true, default-features = true }
|
||||
prometheus-endpoint = { workspace = true, default-features = true }
|
||||
pezsc-client-api = { workspace = true, default-features = true }
|
||||
pezsc-transaction-pool-api = { workspace = true, default-features = true }
|
||||
pezsc-utils = { workspace = true, default-features = true }
|
||||
serde = { features = ["derive"], workspace = true, default-features = true }
|
||||
pezsp-api = { workspace = true, default-features = true }
|
||||
pezsp-blockchain = { workspace = true, default-features = true }
|
||||
pezsp-core = { workspace = true, default-features = true }
|
||||
@@ -41,10 +39,12 @@ pezsp-crypto-hashing = { workspace = true, default-features = true }
|
||||
pezsp-runtime = { workspace = true, default-features = true }
|
||||
pezsp-tracing = { workspace = true, default-features = true }
|
||||
pezsp-transaction-pool = { workspace = true, default-features = true }
|
||||
prometheus-endpoint = { workspace = true, default-features = true }
|
||||
serde = { features = ["derive"], workspace = true, default-features = true }
|
||||
thiserror = { workspace = true }
|
||||
tokio = { workspace = true, default-features = true, features = [
|
||||
"macros",
|
||||
"time",
|
||||
"macros",
|
||||
"time",
|
||||
] }
|
||||
tokio-stream = { workspace = true }
|
||||
tracing = { workspace = true, default-features = true }
|
||||
@@ -52,18 +52,18 @@ tracing = { workspace = true, default-features = true }
|
||||
[dev-dependencies]
|
||||
anyhow = { workspace = true }
|
||||
assert_matches = { workspace = true }
|
||||
chrono = { workspace = true }
|
||||
criterion = { workspace = true, default-features = true }
|
||||
pezcumulus-zombienet-sdk-helpers = { workspace = true }
|
||||
env_logger = { workspace = true }
|
||||
rstest = { workspace = true }
|
||||
pezsc-block-builder = { workspace = true, default-features = true }
|
||||
serde = { workspace = true }
|
||||
serde_json = { workspace = true }
|
||||
pezsp-consensus = { workspace = true, default-features = true }
|
||||
bizinikiwi-test-runtime = { workspace = true }
|
||||
bizinikiwi-test-runtime-client = { workspace = true }
|
||||
bizinikiwi-test-runtime-transaction-pool = { workspace = true }
|
||||
chrono = { workspace = true }
|
||||
criterion = { workspace = true, default-features = true }
|
||||
env_logger = { workspace = true }
|
||||
pezcumulus-zombienet-sdk-helpers = { workspace = true }
|
||||
pezsc-block-builder = { workspace = true, default-features = true }
|
||||
pezsp-consensus = { workspace = true, default-features = true }
|
||||
rstest = { workspace = true }
|
||||
serde = { workspace = true }
|
||||
serde_json = { workspace = true }
|
||||
tokio = { workspace = true, features = ["rt-multi-thread"] }
|
||||
tracing-subscriber = { workspace = true }
|
||||
txtesttool = { workspace = true }
|
||||
@@ -72,16 +72,16 @@ zombienet-sdk = { workspace = true }
|
||||
|
||||
[features]
|
||||
runtime-benchmarks = [
|
||||
"pezcumulus-zombienet-sdk-helpers/runtime-benchmarks",
|
||||
"pezsc-block-builder/runtime-benchmarks",
|
||||
"pezsc-client-api/runtime-benchmarks",
|
||||
"pezsc-transaction-pool-api/runtime-benchmarks",
|
||||
"pezsp-api/runtime-benchmarks",
|
||||
"pezsp-blockchain/runtime-benchmarks",
|
||||
"pezsp-consensus/runtime-benchmarks",
|
||||
"pezsp-runtime/runtime-benchmarks",
|
||||
"pezsp-transaction-pool/runtime-benchmarks",
|
||||
"bizinikiwi-test-runtime-client/runtime-benchmarks",
|
||||
"bizinikiwi-test-runtime-transaction-pool/runtime-benchmarks",
|
||||
"bizinikiwi-test-runtime/runtime-benchmarks",
|
||||
"bizinikiwi-test-runtime-client/runtime-benchmarks",
|
||||
"bizinikiwi-test-runtime-transaction-pool/runtime-benchmarks",
|
||||
"bizinikiwi-test-runtime/runtime-benchmarks",
|
||||
"pezcumulus-zombienet-sdk-helpers/runtime-benchmarks",
|
||||
"pezsc-block-builder/runtime-benchmarks",
|
||||
"pezsc-client-api/runtime-benchmarks",
|
||||
"pezsc-transaction-pool-api/runtime-benchmarks",
|
||||
"pezsp-api/runtime-benchmarks",
|
||||
"pezsp-blockchain/runtime-benchmarks",
|
||||
"pezsp-consensus/runtime-benchmarks",
|
||||
"pezsp-runtime/runtime-benchmarks",
|
||||
"pezsp-transaction-pool/runtime-benchmarks",
|
||||
]
|
||||
|
||||
@@ -18,10 +18,10 @@ codec = { workspace = true, default-features = true }
|
||||
futures = { workspace = true }
|
||||
indexmap = { workspace = true }
|
||||
log = { workspace = true, default-features = true }
|
||||
serde = { features = ["derive"], workspace = true, default-features = true }
|
||||
pezsp-blockchain = { workspace = true, default-features = true }
|
||||
pezsp-core = { workspace = true }
|
||||
pezsp-runtime = { workspace = true }
|
||||
serde = { features = ["derive"], workspace = true, default-features = true }
|
||||
thiserror = { workspace = true }
|
||||
|
||||
[dev-dependencies]
|
||||
@@ -29,6 +29,6 @@ serde_json = { workspace = true, default-features = true }
|
||||
|
||||
[features]
|
||||
runtime-benchmarks = [
|
||||
"pezsp-blockchain/runtime-benchmarks",
|
||||
"pezsp-runtime/runtime-benchmarks",
|
||||
"pezsp-blockchain/runtime-benchmarks",
|
||||
"pezsp-runtime/runtime-benchmarks",
|
||||
]
|
||||
|
||||
@@ -24,12 +24,12 @@ use std::time::SystemTime;
|
||||
use tracing_subscriber::EnvFilter;
|
||||
use txtesttool::scenario::{ChainType, ScenarioBuilder};
|
||||
use zombienet_sdk::{
|
||||
subxt::SubstrateConfig, GlobalSettingsBuilder, LocalFileSystem, Network, NetworkConfig,
|
||||
pezkuwi_subxt::BizinikiwConfig, GlobalSettingsBuilder, LocalFileSystem, Network, NetworkConfig,
|
||||
NetworkConfigBuilder, NetworkConfigExt, WithRelaychain,
|
||||
};
|
||||
|
||||
/// Bizinikiwi configuration for zombienet tests - based on SubstrateConfig
|
||||
pub type BizinikiwiConfig = SubstrateConfig;
|
||||
/// Bizinikiwi configuration for zombienet tests - based on BizinikiwConfig
|
||||
pub type BizinikiwiConfig = BizinikiwConfig;
|
||||
|
||||
/// Gathers TOML files paths for relaychains and for teyrchains' (that use pezkuwichain-local based
|
||||
/// relaychains) zombienet network specs for testing in relation to fork aware transaction pool.
|
||||
|
||||
@@ -22,12 +22,12 @@
|
||||
// https://github.com/pezkuwichain/pezkuwi-sdk/issues/124#issuecomment-2808830472
|
||||
|
||||
use crate::zombienet::{BlockSubscriptionType, NetworkSpawner, ScenarioBuilderSharedParams};
|
||||
use pezcumulus_zombienet_sdk_helpers::create_assign_core_call;
|
||||
use pezcumulus_zombienet_sdk_helpers::{create_assign_core_call};
|
||||
use serde_json::json;
|
||||
use txtesttool::{execution_log::ExecutionLog, scenario::ScenarioBuilder};
|
||||
use zombienet_sdk::{
|
||||
subxt::{OnlineClient, PolkadotConfig},
|
||||
subxt_signer::sr25519::dev,
|
||||
pezkuwi_subxt::{OnlineClient, PezkuwiConfig},
|
||||
pezkuwi_subxt_signer::sr25519::dev,
|
||||
NetworkConfigBuilder,
|
||||
};
|
||||
|
||||
@@ -42,7 +42,7 @@ async fn slot_based_3cores_test() -> Result<(), anyhow::Error> {
|
||||
let r = r
|
||||
.with_chain("pezkuwichain-local")
|
||||
.with_default_command("pezkuwi")
|
||||
.with_default_image(images.pezkuwi.as_str())
|
||||
.with_default_image(images.pezkuwi())
|
||||
.with_default_args(vec![("-lteyrchain=debug").into()])
|
||||
.with_genesis_overrides(json!({
|
||||
"configuration": {
|
||||
@@ -60,16 +60,16 @@ async fn slot_based_3cores_test() -> Result<(), anyhow::Error> {
|
||||
})
|
||||
// Have to set a `with_node` outside of the loop below, so that `r` has the
|
||||
// right type.
|
||||
.with_node(|node| node.with_name(names[0]));
|
||||
.with_validator(|node| node.with_name(names[0]));
|
||||
|
||||
(1..3).fold(r, |acc, i| acc.with_node(|node| node.with_name(names[i])))
|
||||
(1..3).fold(r, |acc, i| acc.with_validator(|node| node.with_name(names[i])))
|
||||
})
|
||||
.with_teyrchain(|p| {
|
||||
// Para 2200 uses the new RFC103-enabled collator which sends the UMP signal
|
||||
// commitment for selecting the core index
|
||||
p.with_id(2200)
|
||||
.with_default_command("pezkuwi-teyrchain")
|
||||
.with_default_image(images.pezcumulus.as_str())
|
||||
.with_default_image(images.pezcumulus())
|
||||
.with_chain("yap-pezkuwichain-local-2200")
|
||||
.with_genesis_overrides(json!({
|
||||
"balances": {
|
||||
@@ -96,7 +96,7 @@ async fn slot_based_3cores_test() -> Result<(), anyhow::Error> {
|
||||
|
||||
let relay_node = spawner.network().get_node("alice")?;
|
||||
|
||||
let relay_client: OnlineClient<PolkadotConfig> = relay_node.wait_client().await?;
|
||||
let relay_client: OnlineClient<PezkuwiConfig> = relay_node.wait_client().await?;
|
||||
let alice = dev::alice();
|
||||
|
||||
let assign_cores_call = create_assign_core_call(&[(0, 2200), (1, 2200)]);
|
||||
|
||||
Reference in New Issue
Block a user