fix: Resolve cargo clippy errors and add CI workflow plan
## Changes
### Clippy Fixes
- Fixed deprecated `cargo_bin` usage in 27 test files (added #![allow(deprecated)])
- Fixed uninlined_format_args in zombienet-sdk-tests
- Fixed subxt API changes in revive/rpc/tests.rs (fetch signature, StorageValue)
- Fixed dead_code warnings in validator-pool and identity-kyc mocks
- Fixed field name `i` -> `_i` in tasks example
### CI Infrastructure
- Added .claude/WORKFLOW_PLAN.md for tracking CI fix progress
- Updated lychee.toml and taplo.toml configs
### Files Modified
- 27 test files with deprecated cargo_bin fix
- bizinikiwi/pezframe/revive/rpc/src/tests.rs (subxt API)
- pezkuwi/pezpallets/validator-pool/src/{mock,tests}.rs
- pezcumulus/teyrchains/pezpallets/identity-kyc/src/mock.rs
- bizinikiwi/pezframe/examples/tasks/src/tests.rs
## Status
- cargo clippy: PASSING
- Next: cargo fmt, zepter, workspace checks
This commit is contained in:
@@ -138,5 +138,5 @@ mod benchmarks {
|
||||
assert_eq!(EraLength::<T>::get(), new_era_length);
|
||||
}
|
||||
|
||||
impl_benchmark_test_suite!(ValidatorPool, crate::mock::new_test_ext(), crate::mock::Test);
|
||||
impl_benchmark_test_suite!(Pezpallet, crate::mock::new_test_ext(), crate::mock::Test);
|
||||
}
|
||||
|
||||
@@ -1034,8 +1034,7 @@ pub mod pezpallet {
|
||||
// Log shadow mode activity
|
||||
log::info!(
|
||||
target: "validator_pool",
|
||||
"Shadow mode: TNPoS selection calculated for session {}",
|
||||
new_index
|
||||
"Shadow mode: TNPoS selection calculated for session {new_index}"
|
||||
);
|
||||
|
||||
// Return None - let pezpallet-staking/NPoS provide validators
|
||||
@@ -1048,8 +1047,7 @@ pub mod pezpallet {
|
||||
|
||||
log::info!(
|
||||
target: "validator_pool",
|
||||
"Active mode: TNPoS providing validators for session {}",
|
||||
new_index
|
||||
"Active mode: TNPoS providing validators for session {new_index}"
|
||||
);
|
||||
|
||||
Self::current_validator_set().map(|set| set.all_validators())
|
||||
@@ -1082,8 +1080,7 @@ pub mod pezpallet {
|
||||
if Self::operation_mode() == OperationMode::Shadow {
|
||||
log::debug!(
|
||||
target: "validator_pool",
|
||||
"Session {} started in shadow mode, comparison data available",
|
||||
start_index
|
||||
"Session {start_index} started in shadow mode, comparison data available"
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -162,7 +162,7 @@ impl crate::WeightInfo for MockWeightInfo {
|
||||
pezframe_support::weights::Weight::from_parts(10_000, 0)
|
||||
}
|
||||
|
||||
fn force_new_era() -> pezframe_support::weights::Weight {
|
||||
fn force_new_era(_p: u32) -> pezframe_support::weights::Weight {
|
||||
pezframe_support::weights::Weight::from_parts(50_000, 0)
|
||||
}
|
||||
|
||||
@@ -176,7 +176,6 @@ impl crate::WeightInfo for MockWeightInfo {
|
||||
}
|
||||
|
||||
impl Config for Test {
|
||||
type RuntimeEvent = RuntimeEvent;
|
||||
type WeightInfo = MockWeightInfo;
|
||||
type Randomness = MockRandomness;
|
||||
type TrustSource = TestTrustProvider;
|
||||
@@ -251,6 +250,7 @@ pub fn run_to_block(n: u64) {
|
||||
}
|
||||
}
|
||||
|
||||
#[allow(dead_code)]
|
||||
pub fn advance_era() {
|
||||
let current_era_start = ValidatorPool::era_start();
|
||||
let era_length = ValidatorPool::era_length();
|
||||
|
||||
@@ -637,7 +637,7 @@ fn shadow_comparison_recorded() {
|
||||
let comparison = ValidatorPool::shadow_comparison();
|
||||
assert!(comparison.is_some());
|
||||
let comp = comparison.unwrap();
|
||||
assert!(comp.overlap_count > 0 || comp.tnpos_only.len() > 0 || comp.npos_only.len() > 0);
|
||||
assert!(comp.overlap_count > 0 || !comp.tnpos_only.is_empty() || !comp.npos_only.is_empty());
|
||||
});
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user