From 91e939b591ded4da73f00e4a63ce5ad9880b6ac2 Mon Sep 17 00:00:00 2001 From: SatoshiQaziMuhammed Date: Sat, 27 Dec 2025 09:41:10 +0300 Subject: [PATCH] fix(ci): remove wasm32v1-none target to fix serde_core compilation (#346) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * docs: update workflow plan with completed CI fixes * fix(ci): remove wasm32v1-none target installation to fix serde_core compilation This removes the explicit `rustup target add wasm32v1-none` step from CI workflows. When wasm32v1-none is installed, the wasm-builder uses it instead of wasm32-unknown-unknown, which causes serde_core 1.0.228 to fail compilation with "relaxing a default bound only does something for ?Sized" errors. By not installing wasm32v1-none, the wasm-builder automatically falls back to wasm32-unknown-unknown which compiles successfully. This aligns with Polkadot SDK's CI configuration which also does not explicitly install wasm32v1-none. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 --------- Co-authored-by: Claude Opus 4.5 --- .github/workflows/build-publish-images.yml | 4 ---- .github/workflows/check-pezframe-omni-bencher.yml | 4 ---- .github/workflows/tests-linux-stable.yml | 4 ---- .github/workflows/tests-misc.yml | 2 -- .github/workflows/tests.yml | 2 -- 5 files changed, 16 deletions(-) diff --git a/.github/workflows/build-publish-images.yml b/.github/workflows/build-publish-images.yml index a3e13930..a77a3581 100644 --- a/.github/workflows/build-publish-images.yml +++ b/.github/workflows/build-publish-images.yml @@ -46,8 +46,6 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Install wasm32v1-none target - run: rustup target add wasm32v1-none - name: build id: required run: | @@ -244,8 +242,6 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Install wasm32v1-none target - run: rustup target add wasm32v1-none - name: build id: required run: | diff --git a/.github/workflows/check-pezframe-omni-bencher.yml b/.github/workflows/check-pezframe-omni-bencher.yml index f1ab0bc5..9816bcfb 100644 --- a/.github/workflows/check-pezframe-omni-bencher.yml +++ b/.github/workflows/check-pezframe-omni-bencher.yml @@ -33,8 +33,6 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Install wasm32v1-none target - run: rustup target add wasm32v1-none - name: Clean cargo cache to free disk space run: | @@ -87,8 +85,6 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Install wasm32v1-none target - run: rustup target add wasm32v1-none - name: script (benchmark ${{ matrix.bench_cmd }}) id: required diff --git a/.github/workflows/tests-linux-stable.yml b/.github/workflows/tests-linux-stable.yml index b6cfba89..3d89558f 100644 --- a/.github/workflows/tests-linux-stable.yml +++ b/.github/workflows/tests-linux-stable.yml @@ -36,8 +36,6 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Install wasm32v1-none target - run: rustup target add wasm32v1-none - name: script id: required run: WASM_BUILD_NO_COLOR=1 cargo test -p pezstaging-node-cli --release --locked -- --ignored @@ -58,8 +56,6 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Install wasm32v1-none target - run: rustup target add wasm32v1-none - name: script id: required run: cargo nextest run --workspace --features runtime-benchmarks benchmark --locked --cargo-profile testnet --cargo-quiet diff --git a/.github/workflows/tests-misc.yml b/.github/workflows/tests-misc.yml index b79d1c46..75cd2676 100644 --- a/.github/workflows/tests-misc.yml +++ b/.github/workflows/tests-misc.yml @@ -109,8 +109,6 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Install wasm32v1-none target - run: rustup target add wasm32v1-none - name: Clean cargo cache to free disk space run: | diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index cd8764b9..109a77da 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -34,8 +34,6 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Install wasm32v1-none target - run: rustup target add wasm32v1-none - name: script run: cargo run --locked --release -p pezstaging-node-cli --bin bizinikiwi-node --features runtime-benchmarks --quiet -- benchmark pezpallet --chain dev --pezpallet "*" --extrinsic "*" --steps 2 --repeat 1 --quiet