From dcb3b72865338566d2ecb66dc329e1461a4efd96 Mon Sep 17 00:00:00 2001 From: Kurdistan Tech Ministry Date: Tue, 27 Jan 2026 23:24:37 +0300 Subject: [PATCH] fix: remove wasm32v1-none target for serde_core + Rust 1.88 bug WASM builds were failing with getrandom/serde_core error when using wasm32v1-none target. By removing the 'rustup target add wasm32v1-none' step, wasm-builder will automatically fallback to wasm32-unknown-unknown. Jobs fixed: - build-linux-stable - build-linux-stable-pezcumulus - build-test-teyrchain - build-test-collators - build-malus - build-linux-bizinikiwi - build-templates-node - tests-evm differential and evm-tests - test-node-metrics Tracking: https://github.com/pezkuwichain/pezkuwi-sdk/issues/358 --- .github/workflows/build-publish-images.yml | 29 +++++++++++----------- .github/workflows/checks.yml | 2 +- .github/workflows/tests-evm.yml | 8 +++--- .github/workflows/tests-misc.yml | 4 +-- 4 files changed, 22 insertions(+), 21 deletions(-) diff --git a/.github/workflows/build-publish-images.yml b/.github/workflows/build-publish-images.yml index 4ef4a354..a192c90a 100644 --- a/.github/workflows/build-publish-images.yml +++ b/.github/workflows/build-publish-images.yml @@ -48,8 +48,9 @@ jobs: uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Configure git safe.directory run: git config --global --add safe.directory '*' - - name: Add wasm32v1-none target - run: rustup target add wasm32v1-none + # NOTE: wasm32v1-none target removed - serde_core + Rust 1.88 bug + # wasm-builder will fallback to wasm32-unknown-unknown automatically + # Tracking: https://github.com/pezkuwichain/pezkuwi-sdk/issues/358 - name: build id: required run: | @@ -103,8 +104,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Add wasm32v1-none target - run: rustup target add wasm32v1-none + # NOTE: wasm32v1-none target removed - serde_core + Rust 1.88 bug + # wasm-builder will fallback to wasm32-unknown-unknown automatically - name: build id: required run: | @@ -139,8 +140,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Add wasm32v1-none target - run: rustup target add wasm32v1-none + # NOTE: wasm32v1-none target removed - serde_core + Rust 1.88 bug + # wasm-builder will fallback to wasm32-unknown-unknown automatically - name: build id: required run: | @@ -177,8 +178,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Add wasm32v1-none target - run: rustup target add wasm32v1-none + # NOTE: wasm32v1-none target removed - serde_core + Rust 1.88 bug + # wasm-builder will fallback to wasm32-unknown-unknown automatically - name: build id: required run: | @@ -216,8 +217,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Add wasm32v1-none target - run: rustup target add wasm32v1-none + # NOTE: wasm32v1-none target removed - serde_core + Rust 1.88 bug + # wasm-builder will fallback to wasm32-unknown-unknown automatically - name: build id: required run: | @@ -256,8 +257,8 @@ jobs: uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - name: Configure git safe.directory run: git config --global --add safe.directory '*' - - name: Add wasm32v1-none target - run: rustup target add wasm32v1-none + # NOTE: wasm32v1-none target removed - serde_core + Rust 1.88 bug + # wasm-builder will fallback to wasm32-unknown-unknown automatically - name: build id: required run: | @@ -299,8 +300,8 @@ jobs: steps: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Add wasm32v1-none target - run: rustup target add wasm32v1-none + # NOTE: wasm32v1-none target removed - serde_core + Rust 1.88 bug + # wasm-builder will fallback to wasm32-unknown-unknown automatically - name: build id: required run: | diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml index 5f1d8853..cad769c1 100644 --- a/.github/workflows/checks.yml +++ b/.github/workflows/checks.yml @@ -42,7 +42,7 @@ jobs: cache-on-failure: true - name: Add wasm32v1-none target - run: rustup target add wasm32v1-none + run: rustup target add wasm32v1-none || true - name: script id: required diff --git a/.github/workflows/tests-evm.yml b/.github/workflows/tests-evm.yml index bfa9a712..7e100e66 100644 --- a/.github/workflows/tests-evm.yml +++ b/.github/workflows/tests-evm.yml @@ -45,8 +45,8 @@ jobs: curl -Lsf --show-error -o resolc "$ASSET_URL" chmod +x resolc ./resolc --version - - name: Add wasm32v1-none target - run: rustup target add wasm32v1-none + # NOTE: wasm32v1-none target removed - serde_core + Rust 1.88 bug + # wasm-builder will fallback to wasm32-unknown-unknown automatically - name: Building the dependencies from the Pezkuwi SDK run: cargo build --locked --profile release -p pezpallet-revive-eth-rpc -p pez-revive-dev-node - name: Checkout the Differential Tests Repository @@ -119,8 +119,8 @@ jobs: - name: Checkout uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 - - name: Add wasm32v1-none target - run: rustup target add wasm32v1-none + # NOTE: wasm32v1-none target removed - serde_core + Rust 1.88 bug + # wasm-builder will fallback to wasm32-unknown-unknown automatically - name: script run: | cargo build --locked --release -p pezpallet-revive-eth-rpc --bin eth-rpc diff --git a/.github/workflows/tests-misc.yml b/.github/workflows/tests-misc.yml index 9398b6ea..8f99e1a9 100644 --- a/.github/workflows/tests-misc.yml +++ b/.github/workflows/tests-misc.yml @@ -281,8 +281,8 @@ jobs: rm -rf ~/.cargo/registry/cache 2>/dev/null || true rm -rf ~/.cargo/git/db 2>/dev/null || true - - name: Add wasm32v1-none target - run: rustup target add wasm32v1-none + # NOTE: wasm32v1-none target removed - serde_core + Rust 1.88 bug + # wasm-builder will fallback to wasm32-unknown-unknown automatically - name: Run tests id: tests