pezkuwichain
cf463fe8ee
- Fixed is_using_frame_crate() macro to check for pezframe/pezkuwi_sdk - Removed disable_pezframe_system_supertrait_check temporary bypasses - Feature-gated storage-benchmark and teyrchain-benchmarks code - Fixed dead_code warnings with underscore prefix (_Header) - Removed unused imports and shadowing use statements - Version bumps: procedural-tools 10.0.1, benchmarking-cli 32.0.1, docs 0.0.2, minimal-runtime 0.0.1, yet-another-teyrchain 0.6.1, umbrella 0.1.2 - Updated MAINNET_ROADMAP.md with FAZ 1 completion status
1018 lines
25 KiB
Rust
1018 lines
25 KiB
Rust
// This file is part of Bizinikiwi.
|
|
|
|
// Copyright (C) Parity Technologies (UK) Ltd. and Dijital Kurdistan Tech Institute
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
// Tests for Multisig Pezpallet
|
|
|
|
#![cfg(test)]
|
|
|
|
use super::*;
|
|
use crate as pezpallet_multisig;
|
|
use pezframe::{prelude::*, runtime::prelude::*, testing_prelude::*};
|
|
|
|
type Block = pezframe_system::mocking::MockBlockU32<Test>;
|
|
|
|
construct_runtime!(
|
|
pub struct Test {
|
|
System: pezframe_system,
|
|
Balances: pezpallet_balances,
|
|
Multisig: pezpallet_multisig,
|
|
}
|
|
);
|
|
|
|
#[derive_impl(pezframe_system::config_preludes::TestDefaultConfig)]
|
|
impl pezframe_system::Config for Test {
|
|
type Block = Block;
|
|
type AccountData = pezpallet_balances::AccountData<u64>;
|
|
// This pezpallet wishes to overwrite this.
|
|
type BaseCallFilter = TestBaseCallFilter;
|
|
}
|
|
|
|
#[derive_impl(pezpallet_balances::config_preludes::TestDefaultConfig)]
|
|
impl pezpallet_balances::Config for Test {
|
|
type ReserveIdentifier = [u8; 8];
|
|
type AccountStore = System;
|
|
}
|
|
|
|
pub struct TestBaseCallFilter;
|
|
impl Contains<RuntimeCall> for TestBaseCallFilter {
|
|
fn contains(c: &RuntimeCall) -> bool {
|
|
match *c {
|
|
RuntimeCall::Balances(_) => true,
|
|
// Needed for benchmarking
|
|
RuntimeCall::System(pezframe_system::Call::remark { .. }) => true,
|
|
_ => false,
|
|
}
|
|
}
|
|
}
|
|
|
|
parameter_types! {
|
|
pub static MultisigDepositBase: u64 = 1;
|
|
pub static MultisigDepositFactor: u64 = 1;
|
|
}
|
|
|
|
impl Config for Test {
|
|
type RuntimeEvent = RuntimeEvent;
|
|
type RuntimeCall = RuntimeCall;
|
|
type Currency = Balances;
|
|
type DepositBase = MultisigDepositBase;
|
|
type DepositFactor = MultisigDepositFactor;
|
|
type MaxSignatories = ConstU32<3>;
|
|
type WeightInfo = ();
|
|
type BlockNumberProvider = pezframe_system::Pezpallet<Test>;
|
|
}
|
|
|
|
use pezpallet_balances::{Call as BalancesCall, Error as BalancesError};
|
|
|
|
pub fn new_test_ext() -> TestState {
|
|
let mut t = pezframe_system::GenesisConfig::<Test>::default().build_storage().unwrap();
|
|
pezpallet_balances::GenesisConfig::<Test> {
|
|
balances: vec![(1, 10), (2, 10), (3, 10), (4, 5), (5, 2)],
|
|
..Default::default()
|
|
}
|
|
.assimilate_storage(&mut t)
|
|
.unwrap();
|
|
let mut ext = TestState::new(t);
|
|
ext.execute_with(|| System::set_block_number(1));
|
|
ext
|
|
}
|
|
|
|
fn now() -> Timepoint<u32> {
|
|
Multisig::timepoint()
|
|
}
|
|
|
|
fn call_transfer(dest: u64, value: u64) -> Box<RuntimeCall> {
|
|
Box::new(RuntimeCall::Balances(BalancesCall::transfer_allow_death { dest, value }))
|
|
}
|
|
|
|
#[test]
|
|
fn multisig_deposit_is_taken_and_returned() {
|
|
new_test_ext().execute_with(|| {
|
|
let multi = Multisig::multi_account_id(&[1, 2, 3][..], 2);
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(1), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(2), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(3), multi, 5));
|
|
|
|
let call = call_transfer(6, 15);
|
|
let call_weight = call.get_dispatch_info().call_weight;
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
2,
|
|
vec![2, 3],
|
|
None,
|
|
call.clone(),
|
|
Weight::zero()
|
|
));
|
|
assert_eq!(Balances::free_balance(1), 2);
|
|
assert_eq!(Balances::reserved_balance(1), 3);
|
|
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
2,
|
|
vec![1, 3],
|
|
Some(now()),
|
|
call,
|
|
call_weight
|
|
));
|
|
assert_eq!(Balances::free_balance(1), 5);
|
|
assert_eq!(Balances::reserved_balance(1), 0);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn cancel_multisig_returns_deposit() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = call_transfer(6, 15).encode();
|
|
let hash = blake2_256(&call);
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
3,
|
|
vec![2, 3],
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
3,
|
|
vec![1, 3],
|
|
Some(now()),
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
assert_eq!(Balances::free_balance(1), 6);
|
|
assert_eq!(Balances::reserved_balance(1), 4);
|
|
assert_ok!(Multisig::cancel_as_multi(RuntimeOrigin::signed(1), 3, vec![2, 3], now(), hash));
|
|
assert_eq!(Balances::free_balance(1), 10);
|
|
assert_eq!(Balances::reserved_balance(1), 0);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn timepoint_checking_works() {
|
|
new_test_ext().execute_with(|| {
|
|
let multi = Multisig::multi_account_id(&[1, 2, 3][..], 2);
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(1), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(2), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(3), multi, 5));
|
|
|
|
let call = call_transfer(6, 15);
|
|
let hash = blake2_256(&call.encode());
|
|
|
|
assert_noop!(
|
|
Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
2,
|
|
vec![1, 3],
|
|
Some(now()),
|
|
hash,
|
|
Weight::zero()
|
|
),
|
|
Error::<Test>::UnexpectedTimepoint,
|
|
);
|
|
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
2,
|
|
vec![2, 3],
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
|
|
assert_noop!(
|
|
Multisig::as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
2,
|
|
vec![1, 3],
|
|
None,
|
|
call.clone(),
|
|
Weight::zero()
|
|
),
|
|
Error::<Test>::NoTimepoint,
|
|
);
|
|
let later = Timepoint { index: 1, ..now() };
|
|
assert_noop!(
|
|
Multisig::as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
2,
|
|
vec![1, 3],
|
|
Some(later),
|
|
call,
|
|
Weight::zero()
|
|
),
|
|
Error::<Test>::WrongTimepoint,
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn multisig_2_of_3_works() {
|
|
new_test_ext().execute_with(|| {
|
|
let multi = Multisig::multi_account_id(&[1, 2, 3][..], 2);
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(1), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(2), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(3), multi, 5));
|
|
|
|
let call = call_transfer(6, 15);
|
|
let call_weight = call.get_dispatch_info().call_weight;
|
|
let hash = blake2_256(&call.encode());
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
2,
|
|
vec![2, 3],
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
assert_eq!(Balances::free_balance(6), 0);
|
|
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
2,
|
|
vec![1, 3],
|
|
Some(now()),
|
|
call,
|
|
call_weight
|
|
));
|
|
assert_eq!(Balances::free_balance(6), 15);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn multisig_3_of_3_works() {
|
|
new_test_ext().execute_with(|| {
|
|
let multi = Multisig::multi_account_id(&[1, 2, 3][..], 3);
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(1), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(2), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(3), multi, 5));
|
|
|
|
let call = call_transfer(6, 15);
|
|
let call_weight = call.get_dispatch_info().call_weight;
|
|
let hash = blake2_256(&call.encode());
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
3,
|
|
vec![2, 3],
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
3,
|
|
vec![1, 3],
|
|
Some(now()),
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
assert_eq!(Balances::free_balance(6), 0);
|
|
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(3),
|
|
3,
|
|
vec![1, 2],
|
|
Some(now()),
|
|
call,
|
|
call_weight
|
|
));
|
|
assert_eq!(Balances::free_balance(6), 15);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn cancel_multisig_works() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = call_transfer(6, 15).encode();
|
|
let hash = blake2_256(&call);
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
3,
|
|
vec![2, 3],
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
3,
|
|
vec![1, 3],
|
|
Some(now()),
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
assert_noop!(
|
|
Multisig::cancel_as_multi(RuntimeOrigin::signed(2), 3, vec![1, 3], now(), hash),
|
|
Error::<Test>::NotOwner,
|
|
);
|
|
assert_ok!(Multisig::cancel_as_multi(RuntimeOrigin::signed(1), 3, vec![2, 3], now(), hash),);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn multisig_2_of_3_as_multi_works() {
|
|
new_test_ext().execute_with(|| {
|
|
let multi = Multisig::multi_account_id(&[1, 2, 3][..], 2);
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(1), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(2), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(3), multi, 5));
|
|
|
|
let call = call_transfer(6, 15);
|
|
let call_weight = call.get_dispatch_info().call_weight;
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
2,
|
|
vec![2, 3],
|
|
None,
|
|
call.clone(),
|
|
Weight::zero()
|
|
));
|
|
assert_eq!(Balances::free_balance(6), 0);
|
|
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
2,
|
|
vec![1, 3],
|
|
Some(now()),
|
|
call,
|
|
call_weight
|
|
));
|
|
assert_eq!(Balances::free_balance(6), 15);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn multisig_2_of_3_as_multi_with_many_calls_works() {
|
|
new_test_ext().execute_with(|| {
|
|
let multi = Multisig::multi_account_id(&[1, 2, 3][..], 2);
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(1), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(2), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(3), multi, 5));
|
|
|
|
let call1 = call_transfer(6, 10);
|
|
let call1_weight = call1.get_dispatch_info().call_weight;
|
|
let call2 = call_transfer(7, 5);
|
|
let call2_weight = call2.get_dispatch_info().call_weight;
|
|
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
2,
|
|
vec![2, 3],
|
|
None,
|
|
call1.clone(),
|
|
Weight::zero()
|
|
));
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
2,
|
|
vec![1, 3],
|
|
None,
|
|
call2.clone(),
|
|
Weight::zero()
|
|
));
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(3),
|
|
2,
|
|
vec![1, 2],
|
|
Some(now()),
|
|
call1,
|
|
call1_weight
|
|
));
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(3),
|
|
2,
|
|
vec![1, 2],
|
|
Some(now()),
|
|
call2,
|
|
call2_weight
|
|
));
|
|
|
|
assert_eq!(Balances::free_balance(6), 10);
|
|
assert_eq!(Balances::free_balance(7), 5);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn multisig_2_of_3_cannot_reissue_same_call() {
|
|
new_test_ext().execute_with(|| {
|
|
let multi = Multisig::multi_account_id(&[1, 2, 3][..], 2);
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(1), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(2), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(3), multi, 5));
|
|
|
|
let call = call_transfer(6, 10);
|
|
let call_weight = call.get_dispatch_info().call_weight;
|
|
let hash = blake2_256(&call.encode());
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
2,
|
|
vec![2, 3],
|
|
None,
|
|
call.clone(),
|
|
Weight::zero()
|
|
));
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
2,
|
|
vec![1, 3],
|
|
Some(now()),
|
|
call.clone(),
|
|
call_weight
|
|
));
|
|
assert_eq!(Balances::free_balance(multi), 5);
|
|
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
2,
|
|
vec![2, 3],
|
|
None,
|
|
call.clone(),
|
|
Weight::zero()
|
|
));
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(3),
|
|
2,
|
|
vec![1, 2],
|
|
Some(now()),
|
|
call.clone(),
|
|
call_weight
|
|
));
|
|
|
|
System::assert_last_event(
|
|
pezpallet_multisig::Event::MultisigExecuted {
|
|
approving: 3,
|
|
timepoint: now(),
|
|
multisig: multi,
|
|
call_hash: hash,
|
|
result: Err(TokenError::FundsUnavailable.into()),
|
|
}
|
|
.into(),
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn minimum_threshold_check_works() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = call_transfer(6, 15);
|
|
assert_noop!(
|
|
Multisig::as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
0,
|
|
vec![2],
|
|
None,
|
|
call.clone(),
|
|
Weight::zero()
|
|
),
|
|
Error::<Test>::MinimumThreshold,
|
|
);
|
|
assert_noop!(
|
|
Multisig::as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
1,
|
|
vec![2],
|
|
None,
|
|
call.clone(),
|
|
Weight::zero()
|
|
),
|
|
Error::<Test>::MinimumThreshold,
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn too_many_signatories_fails() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = call_transfer(6, 15);
|
|
assert_noop!(
|
|
Multisig::as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
2,
|
|
vec![2, 3, 4],
|
|
None,
|
|
call.clone(),
|
|
Weight::zero()
|
|
),
|
|
Error::<Test>::TooManySignatories,
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn duplicate_approvals_are_ignored() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = call_transfer(6, 15).encode();
|
|
let hash = blake2_256(&call);
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
2,
|
|
vec![2, 3],
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
assert_noop!(
|
|
Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
2,
|
|
vec![2, 3],
|
|
Some(now()),
|
|
hash,
|
|
Weight::zero()
|
|
),
|
|
Error::<Test>::AlreadyApproved,
|
|
);
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
2,
|
|
vec![1, 3],
|
|
Some(now()),
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
assert_noop!(
|
|
Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(3),
|
|
2,
|
|
vec![1, 2],
|
|
Some(now()),
|
|
hash,
|
|
Weight::zero()
|
|
),
|
|
Error::<Test>::AlreadyApproved,
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn multisig_1_of_3_works() {
|
|
new_test_ext().execute_with(|| {
|
|
let multi = Multisig::multi_account_id(&[1, 2, 3][..], 1);
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(1), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(2), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(3), multi, 5));
|
|
|
|
let call = call_transfer(6, 15);
|
|
let hash = blake2_256(&call.encode());
|
|
assert_noop!(
|
|
Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
1,
|
|
vec![2, 3],
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
),
|
|
Error::<Test>::MinimumThreshold,
|
|
);
|
|
assert_noop!(
|
|
Multisig::as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
1,
|
|
vec![2, 3],
|
|
None,
|
|
call.clone(),
|
|
Weight::zero()
|
|
),
|
|
Error::<Test>::MinimumThreshold,
|
|
);
|
|
assert_ok!(Multisig::as_multi_threshold_1(
|
|
RuntimeOrigin::signed(1),
|
|
vec![2, 3],
|
|
call_transfer(6, 15)
|
|
));
|
|
|
|
System::assert_last_event(
|
|
pezpallet_multisig::Event::MultisigExecuted {
|
|
approving: 1,
|
|
timepoint: now(),
|
|
multisig: multi,
|
|
call_hash: hash,
|
|
result: Ok(()),
|
|
}
|
|
.into(),
|
|
);
|
|
assert_eq!(Balances::free_balance(6), 15);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn multisig_filters() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = Box::new(RuntimeCall::System(pezframe_system::Call::set_code { code: vec![] }));
|
|
assert_noop!(
|
|
Multisig::as_multi_threshold_1(RuntimeOrigin::signed(1), vec![2], call.clone()),
|
|
DispatchError::from(pezframe_system::Error::<Test>::CallFiltered),
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn weight_check_works() {
|
|
new_test_ext().execute_with(|| {
|
|
let multi = Multisig::multi_account_id(&[1, 2, 3][..], 2);
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(1), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(2), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(3), multi, 5));
|
|
|
|
let call = call_transfer(6, 15);
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
2,
|
|
vec![2, 3],
|
|
None,
|
|
call.clone(),
|
|
Weight::zero()
|
|
));
|
|
assert_eq!(Balances::free_balance(6), 0);
|
|
|
|
assert_noop!(
|
|
Multisig::as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
2,
|
|
vec![1, 3],
|
|
Some(now()),
|
|
call,
|
|
Weight::zero()
|
|
),
|
|
Error::<Test>::MaxWeightTooLow,
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn multisig_handles_no_preimage_after_all_approve() {
|
|
// This test checks the situation where everyone approves a multi-sig, but no-one provides the
|
|
// call data. In the end, any of the multisig callers can approve again with the call data and
|
|
// the call will go through.
|
|
new_test_ext().execute_with(|| {
|
|
let multi = Multisig::multi_account_id(&[1, 2, 3][..], 3);
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(1), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(2), multi, 5));
|
|
assert_ok!(Balances::transfer_allow_death(RuntimeOrigin::signed(3), multi, 5));
|
|
|
|
let call = call_transfer(6, 15);
|
|
let call_weight = call.get_dispatch_info().call_weight;
|
|
let hash = blake2_256(&call.encode());
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
3,
|
|
vec![2, 3],
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(2),
|
|
3,
|
|
vec![1, 3],
|
|
Some(now()),
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(3),
|
|
3,
|
|
vec![1, 2],
|
|
Some(now()),
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
assert_eq!(Balances::free_balance(6), 0);
|
|
|
|
assert_ok!(Multisig::as_multi(
|
|
RuntimeOrigin::signed(3),
|
|
3,
|
|
vec![1, 2],
|
|
Some(now()),
|
|
call,
|
|
call_weight
|
|
));
|
|
assert_eq!(Balances::free_balance(6), 15);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn poke_deposit_fails_for_threshold_less_than_two() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = call_transfer(6, 15);
|
|
let hash = blake2_256(&call.encode());
|
|
assert_noop!(
|
|
Multisig::poke_deposit(RuntimeOrigin::signed(1), 0, vec![2], hash),
|
|
Error::<Test>::MinimumThreshold,
|
|
);
|
|
assert_noop!(
|
|
Multisig::poke_deposit(RuntimeOrigin::signed(1), 1, vec![2], hash),
|
|
Error::<Test>::MinimumThreshold,
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn poke_deposit_fails_for_too_incorrect_number_of_signatories() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = call_transfer(6, 15);
|
|
let hash = blake2_256(&call.encode());
|
|
assert_noop!(
|
|
Multisig::poke_deposit(RuntimeOrigin::signed(1), 2, vec![], hash),
|
|
Error::<Test>::TooFewSignatories,
|
|
);
|
|
assert_noop!(
|
|
Multisig::poke_deposit(RuntimeOrigin::signed(1), 2, vec![2, 3, 4, 5], hash),
|
|
Error::<Test>::TooManySignatories,
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn poke_deposit_fails_for_signatories_out_of_order() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = call_transfer(6, 15);
|
|
let hash = blake2_256(&call.encode());
|
|
let threshold = 2;
|
|
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
threshold,
|
|
vec![2, 3],
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
|
|
assert_noop!(
|
|
Multisig::poke_deposit(
|
|
RuntimeOrigin::signed(1),
|
|
threshold,
|
|
vec![3, 2], // Unordered
|
|
hash
|
|
),
|
|
Error::<Test>::SignatoriesOutOfOrder
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn poke_deposit_fails_for_non_existent_multisig() {
|
|
new_test_ext().execute_with(|| {
|
|
assert_noop!(
|
|
Multisig::poke_deposit(RuntimeOrigin::signed(1), 2, vec![2, 3], [0; 32]),
|
|
Error::<Test>::NotFound
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn poke_deposit_fails_for_non_owner() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = call_transfer(6, 15);
|
|
let hash = blake2_256(&call.encode());
|
|
let threshold = 2;
|
|
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
threshold,
|
|
vec![2, 3],
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
|
|
// Try to poke from non-owner (account 2)
|
|
assert_noop!(
|
|
Multisig::poke_deposit(
|
|
RuntimeOrigin::signed(2),
|
|
threshold,
|
|
vec![1, 3], // Note: signatories adjusted for different caller
|
|
hash
|
|
),
|
|
Error::<Test>::NotOwner
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn poke_deposit_charges_fee_when_deposit_unchanged() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = call_transfer(6, 15);
|
|
let hash = blake2_256(&call.encode());
|
|
let threshold = 2;
|
|
let other_signatories = vec![2, 3];
|
|
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
threshold,
|
|
other_signatories.clone(),
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
|
|
let initial_deposit = Balances::reserved_balance(1);
|
|
let initial_free = Balances::free_balance(1);
|
|
|
|
// Poke without changing deposit requirements
|
|
let result =
|
|
Multisig::poke_deposit(RuntimeOrigin::signed(1), threshold, other_signatories, hash);
|
|
assert_ok!(result.as_ref());
|
|
assert_eq!(result.unwrap().pays_fee, Pays::Yes);
|
|
|
|
// Verify balances unchanged (except for fee)
|
|
assert_eq!(Balances::reserved_balance(1), initial_deposit);
|
|
assert!(Balances::free_balance(1) <= initial_free);
|
|
|
|
// Verify no event was emitted
|
|
assert!(!System::events().iter().any(|record| matches!(
|
|
record.event,
|
|
RuntimeEvent::Multisig(Event::DepositPoked { .. })
|
|
)));
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn poke_deposit_works_when_deposit_increases() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = call_transfer(6, 15);
|
|
let hash = blake2_256(&call.encode());
|
|
let threshold = 2;
|
|
let other_signatories = vec![2, 3];
|
|
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
threshold,
|
|
other_signatories.clone(),
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
|
|
// Record initial balances
|
|
let initial_deposit = Balances::reserved_balance(1);
|
|
let initial_free = Balances::free_balance(1);
|
|
let initial_base: u64 = MultisigDepositBase::get();
|
|
let initial_factor: u64 = MultisigDepositFactor::get();
|
|
let threshold_u64: u64 = threshold as u64;
|
|
let expected_initial_deposit = initial_base + (initial_factor * threshold_u64);
|
|
assert_eq!(
|
|
initial_deposit, expected_initial_deposit,
|
|
"Initial deposit should be 1 + (1 * 2)"
|
|
);
|
|
|
|
// Increase deposit requirements
|
|
MultisigDepositBase::set(3);
|
|
MultisigDepositFactor::set(2);
|
|
|
|
// Poke the deposit
|
|
let result =
|
|
Multisig::poke_deposit(RuntimeOrigin::signed(1), threshold, other_signatories, hash);
|
|
assert_ok!(result.as_ref());
|
|
assert_eq!(result.unwrap().pays_fee, Pays::No);
|
|
|
|
// New deposit should be 7 (base 3 + factor 2 * threshold 2)
|
|
let new_base: u64 = MultisigDepositBase::get();
|
|
let new_factor: u64 = MultisigDepositFactor::get();
|
|
let expected_new_deposit = new_base + (new_factor * threshold_u64);
|
|
let deposit_increase = expected_new_deposit.saturating_sub(initial_deposit);
|
|
|
|
// Verify exact balance changes
|
|
assert_eq!(
|
|
Balances::reserved_balance(1),
|
|
expected_new_deposit,
|
|
"Reserved balance should be exactly base(3) + factor(2) * threshold(2) = 7"
|
|
);
|
|
assert_eq!(
|
|
Balances::free_balance(1),
|
|
initial_free.saturating_sub(deposit_increase),
|
|
"Free balance should decrease by exactly the deposit increase"
|
|
);
|
|
|
|
// Verify event
|
|
System::assert_has_event(
|
|
Event::DepositPoked {
|
|
who: 1,
|
|
call_hash: hash,
|
|
old_deposit: initial_deposit,
|
|
new_deposit: expected_new_deposit,
|
|
}
|
|
.into(),
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn poke_deposit_works_when_deposit_decreases() {
|
|
new_test_ext().execute_with(|| {
|
|
// Start with higher deposit requirements
|
|
MultisigDepositBase::set(3);
|
|
MultisigDepositFactor::set(2);
|
|
|
|
let call = call_transfer(6, 15);
|
|
let hash = blake2_256(&call.encode());
|
|
let threshold = 2;
|
|
let other_signatories = vec![2, 3];
|
|
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(1),
|
|
threshold,
|
|
other_signatories.clone(),
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
|
|
let initial_deposit = Balances::reserved_balance(1);
|
|
let initial_free = Balances::free_balance(1);
|
|
|
|
// Verify initial deposit calculation (3 + 2 * 2 = 7)
|
|
let initial_base: u64 = MultisigDepositBase::get();
|
|
let initial_factor: u64 = MultisigDepositFactor::get();
|
|
let threshold_u64: u64 = threshold as u64;
|
|
let expected_initial_deposit = initial_base + (initial_factor * threshold_u64);
|
|
assert_eq!(
|
|
initial_deposit, expected_initial_deposit,
|
|
"Initial deposit should be exactly base(3) + factor(2) * threshold(2) = 7"
|
|
);
|
|
|
|
// Decrease deposit requirements
|
|
MultisigDepositBase::set(1);
|
|
MultisigDepositFactor::set(1);
|
|
|
|
// Poke the deposit
|
|
let result =
|
|
Multisig::poke_deposit(RuntimeOrigin::signed(1), threshold, other_signatories, hash);
|
|
assert_ok!(result.as_ref());
|
|
// Doesn't pay fee
|
|
assert_eq!(result.unwrap().pays_fee, Pays::No);
|
|
|
|
// Calculate expected new deposit (1 + 1 * 2 = 3)
|
|
let new_base: u64 = MultisigDepositBase::get();
|
|
let new_factor: u64 = MultisigDepositFactor::get();
|
|
let expected_new_deposit = new_base + (new_factor * threshold_u64);
|
|
let deposit_decrease = initial_deposit.saturating_sub(expected_new_deposit);
|
|
|
|
assert_eq!(
|
|
Balances::reserved_balance(1),
|
|
expected_new_deposit,
|
|
"Reserved balance should be exactly base(1) + factor(1) * threshold(2) = 3"
|
|
);
|
|
assert_eq!(
|
|
Balances::free_balance(1),
|
|
initial_free.saturating_add(deposit_decrease),
|
|
"Free balance should increase by exactly the deposit decrease"
|
|
);
|
|
|
|
System::assert_has_event(
|
|
Event::DepositPoked {
|
|
who: 1,
|
|
call_hash: hash,
|
|
old_deposit: initial_deposit,
|
|
new_deposit: expected_new_deposit,
|
|
}
|
|
.into(),
|
|
);
|
|
});
|
|
}
|
|
|
|
#[test]
|
|
fn poke_deposit_handles_insufficient_balance() {
|
|
new_test_ext().execute_with(|| {
|
|
let call = call_transfer(6, 15);
|
|
let hash = blake2_256(&call.encode());
|
|
let threshold = 2;
|
|
let other_signatories = vec![2, 3];
|
|
|
|
// Use account 4 which has only 5 balance
|
|
assert_ok!(Multisig::approve_as_multi(
|
|
RuntimeOrigin::signed(4),
|
|
threshold,
|
|
other_signatories.clone(),
|
|
None,
|
|
hash,
|
|
Weight::zero()
|
|
));
|
|
|
|
// Increase deposit requirement beyond available balance
|
|
MultisigDepositBase::set(3);
|
|
MultisigDepositFactor::set(3);
|
|
|
|
// Should fail due to insufficient balance
|
|
assert_noop!(
|
|
Multisig::poke_deposit(RuntimeOrigin::signed(4), threshold, other_signatories, hash),
|
|
BalancesError::<Test, _>::InsufficientBalance
|
|
);
|
|
});
|
|
}
|