Re-confirm unchanged stake, and never submit a partial total

People Chain now counts a staking duration only up to the last confirmation
of the stake plus MaxDataAge (fourteen days), so a stopped noter cannot leave
scores climbing on unchecked data. The bot submitted only on change, which
under that rule would freeze every account whose stake stays put.

confirm.js decides when unchanged stake is sent again: not while a
submission is pending (each one restarts the dispute window), not on
half-read data, and only once the last confirmation is CONFIRM_EVERY_BLOCKS
old (default three days). On a runtime without stakingScore.lastConfirmed
the bot behaves as before.

The direct-staking query failed silently into zeros, and a zero that lands
clears the account's stake clock on chain. It now reports the failure, and a
failure in either half skips the account for that scan.
This commit is contained in:
Satoshi Qazi Muhammed committed 2026-10-18 20:56:46 +04:00
1 parent e3ba45f449
commit 7a51810333
5 files changed
+133 -8

No files matched your search

+48
View File
@@ -0,0 +1,48 @@
// node --test noter/test
import { test } from 'node:test';
import assert from 'node:assert/strict';
import { needsReconfirmation, DEFAULT_CONFIRM_EVERY_BLOCKS } from '../confirm.js';
const EVERY = DEFAULT_CONFIRM_EVERY_BLOCKS;
const steady = {
supported: true, changed: false, pending: false, queryFailed: false,
recordedStake: 500n, lastConfirmedAt: 1_000, currentBlock: 1_000 + EVERY, everyBlocks: EVERY,
};
test('unchanged stake is confirmed again once the last confirmation is old enough', () => {
assert.equal(needsReconfirmation(steady), true);
});
test('not before then: every submission restarts the dispute window', () => {
assert.equal(needsReconfirmation({ ...steady, currentBlock: 1_000 + EVERY - 1 }), false);
});
test('never while a submission is still pending', () => {
assert.equal(needsReconfirmation({ ...steady, pending: true }), false);
});
test('a change is submitted as a change, not as a confirmation', () => {
assert.equal(needsReconfirmation({ ...steady, changed: true }), false);
});
test('half-read data is not confirmed', () => {
assert.equal(needsReconfirmation({ ...steady, queryFailed: true }), false);
});
test('there is nothing to confirm without a recorded stake', () => {
assert.equal(needsReconfirmation({ ...steady, recordedStake: null }), false);
assert.equal(needsReconfirmation({ ...steady, recordedStake: 0n }), false);
});
test('stake recorded before the chain kept confirmations is confirmed', () => {
assert.equal(needsReconfirmation({ ...steady, lastConfirmedAt: null, currentBlock: 5 }), true);
});
test('a chain that keeps no confirmations is left alone', () => {
assert.equal(needsReconfirmation({ ...steady, supported: false }), false);
});
test('the default leaves several tries inside the fourteen-day allowance', () => {
const allowance = 14 * 24 * 600;
assert.ok(allowance / EVERY >= 4);
});