Fix spelling mistakes across the whole repository (#3808)

**Update:** Pushed additional changes based on the review comments.

**This pull request fixes various spelling mistakes in this
repository.**

Most of the changes are contained in the first **3** commits:

- `Fix spelling mistakes in comments and docs`

- `Fix spelling mistakes in test names`

- `Fix spelling mistakes in error messages, panic messages, logs and
tracing`

Other source code spelling mistakes are separated into individual
commits for easier reviewing:

- `Fix the spelling of 'authority'`

- `Fix the spelling of 'REASONABLE_HEADERS_IN_JUSTIFICATION_ANCESTRY'`

- `Fix the spelling of 'prev_enqueud_messages'`

- `Fix the spelling of 'endpoint'`

- `Fix the spelling of 'children'`

- `Fix the spelling of 'PenpalSiblingSovereignAccount'`

- `Fix the spelling of 'PenpalSudoAccount'`

- `Fix the spelling of 'insufficient'`

- `Fix the spelling of 'PalletXcmExtrinsicsBenchmark'`

- `Fix the spelling of 'subtracted'`

- `Fix the spelling of 'CandidatePendingAvailability'`

- `Fix the spelling of 'exclusive'`

- `Fix the spelling of 'until'`

- `Fix the spelling of 'discriminator'`

- `Fix the spelling of 'nonexistent'`

- `Fix the spelling of 'subsystem'`

- `Fix the spelling of 'indices'`

- `Fix the spelling of 'committed'`

- `Fix the spelling of 'topology'`

- `Fix the spelling of 'response'`

- `Fix the spelling of 'beneficiary'`

- `Fix the spelling of 'formatted'`

- `Fix the spelling of 'UNKNOWN_PROOF_REQUEST'`

- `Fix the spelling of 'succeeded'`

- `Fix the spelling of 'reopened'`

- `Fix the spelling of 'proposer'`

- `Fix the spelling of 'InstantiationNonce'`

- `Fix the spelling of 'depositor'`

- `Fix the spelling of 'expiration'`

- `Fix the spelling of 'phantom'`

- `Fix the spelling of 'AggregatedKeyValue'`

- `Fix the spelling of 'randomness'`

- `Fix the spelling of 'defendant'`

- `Fix the spelling of 'AquaticMammal'`

- `Fix the spelling of 'transactions'`

- `Fix the spelling of 'PassingTracingSubscriber'`

- `Fix the spelling of 'TxSignaturePayload'`

- `Fix the spelling of 'versioning'`

- `Fix the spelling of 'descendant'`

- `Fix the spelling of 'overridden'`

- `Fix the spelling of 'network'`

Let me know if this structure is adequate.

**Note:** The usage of the words `Merkle`, `Merkelize`, `Merklization`,
`Merkelization`, `Merkleization`, is somewhat inconsistent but I left it
as it is.

~~**Note:** In some places the term `Receival` is used to refer to
message reception, IMO `Reception` is the correct word here, but I left
it as it is.~~

~~**Note:** In some places the term `Overlayed` is used instead of the
more acceptable version `Overlaid` but I also left it as it is.~~

~~**Note:** In some places the term `Applyable` is used instead of the
correct version `Applicable` but I also left it as it is.~~

**Note:** Some usage of British vs American english e.g. `judgement` vs
`judgment`, `initialise` vs `initialize`, `optimise` vs `optimize` etc.
are both present in different places, but I suppose that's
understandable given the number of contributors.

~~**Note:** There is a spelling mistake in `.github/CODEOWNERS` but it
triggers errors in CI when I make changes to it, so I left it as it
is.~~

substrate/frame/contracts/src/benchmarking/code.rs

@@ -164,7 +164,7 @@ impl<T: Config> From<ModuleDefinition> for WasmModule<T> {
 
 		// Grant access to linear memory.
 		// Every contract module is required to have an imported memory.
-		// If no memory is specified in the passed ModuleDefenition, then
+		// If no memory is specified in the passed ModuleDefinition, then
 		// default to (1, 1).
 		let (init, max) = if let Some(memory) = &def.memory {
 			(memory.min_pages, Some(memory.max_pages))

substrate/frame/contracts/src/benchmarking/mod.rs

@@ -340,7 +340,7 @@ mod benchmarks {
 		assert_eq!(StorageVersion::get::<Pallet<T>>(), version);
 	}
 
-	// This benchmarks the weight of dispatching migrate to execute 1 `NoopMigraton`
+	// This benchmarks the weight of dispatching migrate to execute 1 `NoopMigration`
 	#[benchmark(pov_mode = Measured)]
 	fn migrate() {
 		let latest_version = LATEST_MIGRATION_VERSION;
@@ -1859,7 +1859,7 @@ mod benchmarks {
 
 	// We call unique accounts.
 	//
-	// This is a slow call: We redeuce the number of runs.
+	// This is a slow call: We reduce the number of runs.
 	#[benchmark(pov_mode = Measured)]
 	fn seal_call(r: Linear<0, { API_BENCHMARK_RUNS / 2 }>) -> Result<(), BenchmarkError> {
 		let dummy_code = WasmModule::<T>::dummy_with_bytes(0);
@@ -1937,7 +1937,7 @@ mod benchmarks {
 		Ok(())
 	}
 
-	// This is a slow call: We redeuce the number of runs.
+	// This is a slow call: We reduce the number of runs.
 	#[benchmark(pov_mode = Measured)]
 	fn seal_delegate_call(r: Linear<0, { API_BENCHMARK_RUNS / 2 }>) -> Result<(), BenchmarkError> {
 		let hashes = (0..r)
@@ -2473,7 +2473,7 @@ mod benchmarks {
 
 	// Only calling the function itself for the list of
 	// generated different ECDSA keys.
-	// This is a slow call: We redeuce the number of runs.
+	// This is a slow call: We reduce the number of runs.
 	#[benchmark(pov_mode = Measured)]
 	fn seal_ecdsa_to_eth_address(
 		r: Linear<0, { API_BENCHMARK_RUNS / 10 }>,

substrate/frame/contracts/src/exec.rs

@@ -531,9 +531,9 @@ enum FrameArgs<'a, T: Config, E> {
 		nonce: u64,
 		/// The executable whose `deploy` function is run.
 		executable: E,
-		/// A salt used in the contract address deriviation of the new contract.
+		/// A salt used in the contract address derivation of the new contract.
 		salt: &'a [u8],
-		/// The input data is used in the contract address deriviation of the new contract.
+		/// The input data is used in the contract address derivation of the new contract.
 		input_data: &'a [u8],
 	},
 }

substrate/frame/contracts/src/gas.rs

@@ -352,7 +352,7 @@ mod tests {
 		assert!(gas_meter.charge(SimpleToken(1)).is_err());
 	}
 
-	// Make sure that the gas meter does not charge in case of overcharger
+	// Make sure that the gas meter does not charge in case of overcharge
 	#[test]
 	fn overcharge_does_not_charge() {
 		let mut gas_meter = GasMeter::<Test>::new(Weight::from_parts(200, 0));

substrate/frame/contracts/src/lib.rs

@@ -1104,7 +1104,7 @@ pub mod pallet {
 		/// A more detailed error can be found on the node console if debug messages are enabled
 		/// by supplying `-lruntime::contracts=debug`.
 		CodeRejected,
-		/// An indetermistic code was used in a context where this is not permitted.
+		/// An indeterministic code was used in a context where this is not permitted.
 		Indeterministic,
 		/// A pending migration needs to complete before the extrinsic can be called.
 		MigrationInProgress,

substrate/frame/contracts/src/migration/v09.rs

@@ -131,7 +131,7 @@ impl<T: Config> MigrationStep for Migration<T> {
 			let module = CodeStorage::<T>::get(&code_hash).unwrap();
 			ensure!(
 				module.instruction_weights_version == old.instruction_weights_version,
-				"invalid isntruction weights version"
+				"invalid instruction weights version"
 			);
 			ensure!(module.determinism == Determinism::Enforced, "invalid determinism");
 			ensure!(module.initial == old.initial, "invalid initial");

substrate/frame/contracts/src/schedule.rs

@@ -193,7 +193,7 @@ pub struct HostFnWeights<T: Config> {
 	/// Weight of calling `seal_set_storage`.
 	pub set_storage: Weight,
 
-	/// Weight per written byten of an item stored with `seal_set_storage`.
+	/// Weight per written byte of an item stored with `seal_set_storage`.
 	pub set_storage_per_new_byte: Weight,
 
 	/// Weight per overwritten byte of an item stored with `seal_set_storage`.

substrate/frame/contracts/src/tests.rs

@@ -1347,7 +1347,7 @@ fn transfer_expendable_cannot_kill_account() {
 }
 
 #[test]
-fn cannot_self_destruct_through_draning() {
+fn cannot_self_destruct_through_draining() {
 	let (wasm, _code_hash) = compile_module::<Test>("drain").unwrap();
 	ExtBuilder::default().existential_deposit(200).build().execute_with(|| {
 		let _ = <Test as Config>::Currency::set_balance(&ALICE, 1_000_000);
@@ -1662,7 +1662,7 @@ fn cannot_self_destruct_in_constructor() {
 	ExtBuilder::default().existential_deposit(50).build().execute_with(|| {
 		let _ = <Test as Config>::Currency::set_balance(&ALICE, 1_000_000);
 
-		// Fail to instantiate the BOB because the contructor calls seal_terminate.
+		// Fail to instantiate the BOB because the constructor calls seal_terminate.
 		assert_err_ignore_postinfo!(
 			Contracts::instantiate_with_code(
 				RuntimeOrigin::signed(ALICE),
@@ -5096,7 +5096,7 @@ fn cannot_instantiate_indeterministic_code() {
 			<Error<Test>>::CodeRejected,
 		);
 
-		// Try to upload a non deterministic code as deterministic
+		// Try to upload a non-deterministic code as deterministic
 		assert_err!(
 			Contracts::upload_code(
 				RuntimeOrigin::signed(ALICE),
@@ -5176,7 +5176,7 @@ fn cannot_instantiate_indeterministic_code() {
 			<Error<Test>>::Indeterministic,
 		);
 
-		// Instantiations are not allowed even in non determinism mode
+		// Instantiations are not allowed even in non-determinism mode
 		assert_err!(
 			<Pallet<Test>>::bare_call(
 				ALICE,
@@ -5202,7 +5202,7 @@ fn cannot_set_code_indeterministic_code() {
 	ExtBuilder::default().existential_deposit(200).build().execute_with(|| {
 		let _ = <Test as Config>::Currency::set_balance(&ALICE, 1_000_000);
 
-		// Put the non deterministic contract on-chain
+		// Put the non-deterministic contract on-chain
 		assert_ok!(Contracts::upload_code(
 			RuntimeOrigin::signed(ALICE),
 			wasm,
@@ -5226,7 +5226,7 @@ fn cannot_set_code_indeterministic_code() {
 		.unwrap()
 		.account_id;
 
-		// We do not allow to set the code hash to a non determinstic wasm
+		// We do not allow to set the code hash to a non-deterministic wasm
 		assert_err!(
 			<Pallet<Test>>::bare_call(
 				ALICE,
@@ -5252,7 +5252,7 @@ fn delegate_call_indeterministic_code() {
 	ExtBuilder::default().existential_deposit(200).build().execute_with(|| {
 		let _ = <Test as Config>::Currency::set_balance(&ALICE, 1_000_000);
 
-		// Put the non deterministic contract on-chain
+		// Put the non-deterministic contract on-chain
 		assert_ok!(Contracts::upload_code(
 			RuntimeOrigin::signed(ALICE),
 			wasm,
@@ -5293,7 +5293,7 @@ fn delegate_call_indeterministic_code() {
 			<Error<Test>>::Indeterministic,
 		);
 
-		// The delegate call will work on non deterministic mode
+		// The delegate call will work on non-deterministic mode
 		assert_ok!(
 			<Pallet<Test>>::bare_call(
 				ALICE,
@@ -5429,7 +5429,7 @@ fn locking_delegate_dependency_works() {
 			contract.storage_base_deposit() - ED
 		);
 
-		// Removing an unexisting dependency should fail.
+		// Removing a nonexistent dependency should fail.
 		assert_err!(
 			call(&addr_caller, &unlock_delegate_dependency_input).result,
 			Error::<Test>::DelegateDependencyNotFound

substrate/frame/contracts/src/wasm/mod.rs

@@ -1425,7 +1425,7 @@ mod tests {
 
 	#[test]
 	fn contract_ecdsa_to_eth_address() {
-		/// calls `seal_ecdsa_to_eth_address` for the contstant and ensures the result equals the
+		/// calls `seal_ecdsa_to_eth_address` for the constant and ensures the result equals the
 		/// expected one.
 		const CODE_ECDSA_TO_ETH_ADDRESS: &str = r#"
 (module

substrate/frame/contracts/src/wasm/runtime.rs

@@ -245,7 +245,7 @@ pub enum RuntimeCosts {
 	/// Weight of calling `account_reentrance_count`
 	AccountEntranceCount,
 	/// Weight of calling `instantiation_nonce`
-	InstantationNonce,
+	InstantiationNonce,
 	/// Weight of calling `lock_delegate_dependency`
 	LockDelegateDependency,
 	/// Weight of calling `unlock_delegate_dependency`
@@ -337,7 +337,7 @@ impl<T: Config> Token<T> for RuntimeCosts {
 			EcdsaToEthAddress => s.ecdsa_to_eth_address,
 			ReentrantCount => s.reentrance_count,
 			AccountEntranceCount => s.account_reentrance_count,
-			InstantationNonce => s.instantiation_nonce,
+			InstantiationNonce => s.instantiation_nonce,
 			LockDelegateDependency => s.lock_delegate_dependency,
 			UnlockDelegateDependency => s.unlock_delegate_dependency,
 		}
@@ -2298,7 +2298,7 @@ pub mod env {
 	/// Returns a nonce that is unique per contract instantiation.
 	/// See [`pallet_contracts_uapi::HostFn::instantiation_nonce`].
 	fn instantiation_nonce(ctx: _, _memory: _) -> Result<u64, TrapReason> {
-		ctx.charge_gas(RuntimeCosts::InstantationNonce)?;
+		ctx.charge_gas(RuntimeCosts::InstantiationNonce)?;
 		Ok(ctx.ext.nonce())
 	}