Move erasure root out of candidate commitments and into descriptor (#2010)

* guide: move erasure-root to candidate descriptor

* primitives: move erasure root to descriptor

* guide: unify candidate commitments and validation outputs

* primitives: unify validation outputs and candidate commitments

* parachains-runtime: fix fallout

* runtimes: fix fallout

* collation generation: fix fallout

* fix stray reference in primitives

* fix fallout in node-primitives

* fix remaining fallout in collation generation

* fix fallout in candidate validation

* fix fallout in runtime API subsystem

* fix fallout in subsystem messages

* fix fallout in candidate backing

* fix fallout in availability distribution

* don't clone

* clone

Co-authored-by: Sergei Shulepov <sergei@parity.io>

polkadot/runtime/parachains/src/inclusion.rs

@@ -562,7 +562,7 @@ impl<T: Trait> Module<T> {
 	/// Run the acceptance criteria checks on the given candidate commitments.
 	pub(crate) fn check_validation_outputs(
 		para_id: ParaId,
-		validation_outputs: primitives::v1::ValidationOutputs,
+		validation_outputs: primitives::v1::CandidateCommitments,
 	) -> bool {
 		if let Err(err) = CandidateCheckContext::<T>::new().check_validation_outputs(
 			para_id,

polkadot/runtime/parachains/src/runtime_api_impl/v1.rs

@@ -221,7 +221,7 @@ pub fn persisted_validation_data<T: initializer::Trait>(
 /// Implementation for the `check_validation_outputs` function of the runtime API.
 pub fn check_validation_outputs<T: initializer::Trait>(
 	para_id: ParaId,
-	outputs: primitives::v1::ValidationOutputs,
+	outputs: primitives::v1::CandidateCommitments,
 ) -> bool {
 	<inclusion::Module<T>>::check_validation_outputs(para_id, outputs)
 }