mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-27 13:57:58 +00:00
remove Default from CandidateDescriptor (#4484)
* remove Default from CandidateHash * Apply suggestions from code review Co-authored-by: Andronik Ordian <write@reusable.software> * chore: fmt * remove backed candidate default * Partial migration away from CandidateReceipt::default * Remove more CandidateReceipt defaults * fmt * Mostly remove CommittedCandidateReceipt default usage * Remove CommittedCandidateReceipt * Remove more Defaults from polakdot primitives v1 + fmt * Remove more Default from polkadot primites v1 * WIP trying to get overseer example + tests to compile * feat: add primitives test helpers * reduce deps of helper * update primitive helpers * make candidate validation compile * fixup cargo lock * make av-store compile * fixup disputes coordinator tests * test: fixup backing * test: fixup approval voting * fixup bitfield signing * test: fixup runtime-api * test: fixup availability dist * foxi[ pverseer test] * remove some Defaults, remove bounds from `dummy` All `fn dummy` in primitives need to be removed anyways. This aids in the transition. * it's a test helper, so always use std * test: fixup parachains runtime tests Excluding benches. * fix keyring * fix paras runtime properly, no more default * Remove fn dummy() usage from approval voting * Move TestCandidateBuilder out of av store to test helpers * Make candidate validation tests pass * Make most dispute coirdinator tests pass * Make provisioner tests work * Make availability recovery tests work with test helpers * Update polkadot-collator-protocol tests * Update statement distribution tests * Update polkadot overseer examples and tests * Derive default for validation code so we don't break unrelated things * Make para runtime test pass (no bench) * Some more work * chore: cargo fmt * cargo fix * avoid some Default::default * fixup dispute coordinator test * remove unused crate deps * remove Default::default wherever possible, replace by dummy_* for the most part * chore: cargo fmt * Remove some warnings * Remove CommittedCandidateReceipt dummy * Remove CandidateReceipt dummy * Remove CandidateDescriptor dummy * Remove commented out code * Fix para runtime tests * chore: nightly * Some updates to the builder * Dynamically adjust mock head data size * Make dispute cooridinator tests work * Fix test candidate_backing_reorders_votes work * +nightly-2021-10-29 fmt * Spelling and remove a default use in builder * Various clean up * More small updates * fmt * More small updates * Doc comments for test helpers * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_paras_inherent.rs * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::paras_inherent --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_paras_inherent.rs * Update lib.rs * review comments * fix warnings * fix test by using correct candidate receipt relay parent Co-authored-by: Andronik Ordian <write@reusable.software> Co-authored-by: emostov <32168567+emostov@users.noreply.github.com> Co-authored-by: Parity Bot <admin@parity.io> Co-authored-by: Gavin Wood <gavin@parity.io>
This commit is contained in:
Bernhard Schuster
committed by
GitHub
GitHub
parent
916497e5db
commit
0f1a9fb1eb
@@ -15,12 +15,16 @@
|
||||
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
use super::*;
|
||||
use ::test_helpers::{
|
||||
dummy_candidate_receipt_bad_sig, dummy_collator, dummy_collator_signature,
|
||||
dummy_committed_candidate_receipt, dummy_hash, dummy_validation_code,
|
||||
};
|
||||
use assert_matches::assert_matches;
|
||||
use futures::{future, Future};
|
||||
use polkadot_node_primitives::{BlockData, InvalidCandidate};
|
||||
use polkadot_node_subsystem_test_helpers as test_helpers;
|
||||
use polkadot_primitives::v1::{
|
||||
GroupRotationInfo, HeadData, PersistedValidationData, ScheduledCore,
|
||||
CollatorId, GroupRotationInfo, HeadData, PersistedValidationData, ScheduledCore,
|
||||
};
|
||||
use polkadot_subsystem::{
|
||||
messages::{CollatorProtocolMessage, RuntimeApiMessage, RuntimeApiRequest},
|
||||
@@ -118,9 +122,9 @@ impl Default for TestState {
|
||||
|
||||
let validation_data = PersistedValidationData {
|
||||
parent_head: HeadData(vec![7, 8, 9]),
|
||||
relay_parent_number: Default::default(),
|
||||
relay_parent_number: 0_u32.into(),
|
||||
max_pov_size: 1024,
|
||||
relay_parent_storage_root: Default::default(),
|
||||
relay_parent_storage_root: dummy_hash(),
|
||||
};
|
||||
|
||||
Self {
|
||||
@@ -189,9 +193,20 @@ impl TestCandidateBuilder {
|
||||
pov_hash: self.pov_hash,
|
||||
relay_parent: self.relay_parent,
|
||||
erasure_root: self.erasure_root,
|
||||
..Default::default()
|
||||
collator: dummy_collator(),
|
||||
signature: dummy_collator_signature(),
|
||||
para_head: dummy_hash(),
|
||||
validation_code_hash: dummy_validation_code().hash(),
|
||||
persisted_validation_data_hash: dummy_hash(),
|
||||
},
|
||||
commitments: CandidateCommitments {
|
||||
head_data: self.head_data,
|
||||
upward_messages: vec![],
|
||||
horizontal_messages: vec![],
|
||||
new_validation_code: None,
|
||||
processed_downward_messages: 0,
|
||||
hrmp_watermark: 0_u32,
|
||||
},
|
||||
commitments: CandidateCommitments { head_data: self.head_data, ..Default::default() },
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -1445,7 +1460,8 @@ fn candidate_backing_reorders_votes() {
|
||||
};
|
||||
|
||||
let fake_attestation = |idx: u32| {
|
||||
let candidate: CommittedCandidateReceipt = Default::default();
|
||||
let candidate =
|
||||
dummy_candidate_receipt_bad_sig(Default::default(), Some(Default::default()));
|
||||
let hash = candidate.hash();
|
||||
let mut data = vec![0; 64];
|
||||
data[0..32].copy_from_slice(hash.0.as_bytes());
|
||||
@@ -1456,7 +1472,7 @@ fn candidate_backing_reorders_votes() {
|
||||
};
|
||||
|
||||
let attested = TableAttestedCandidate {
|
||||
candidate: Default::default(),
|
||||
candidate: dummy_committed_candidate_receipt(dummy_hash()),
|
||||
validity_votes: vec![
|
||||
(ValidatorIndex(5), fake_attestation(5)),
|
||||
(ValidatorIndex(3), fake_attestation(3)),
|
||||
|
||||
Reference in New Issue
Block a user