pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-05-31 05:11:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not refetch completion data instantly (#649)

Browse Source 
* do not refetch completion data instantly

* clippy
This commit is contained in:
Svyatoslav Nikolsky
2021-01-15 11:17:40 +03:00
committed by Bastian Köcher
parent f3ea6a8d3d
commit 0f7a096d55
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bridges/relays/headers-relay/src/headers.rs
+14 -7
View File
@@ -368,7 +368,10 @@ impl<P: HeadersSyncPipeline> QueuedHeaders<P> {
// completion 'notification' // completion 'notification'
// this could lead to duplicate completion retrieval (if completion transaction isn't mined // this could lead to duplicate completion retrieval (if completion transaction isn't mined
// for too long) // for too long)
if self.incomplete_headers.get(id).is_some() { //
// instead, we're moving entry to the end of the queue, so that completion data won't be
// refetched instantly
if self.incomplete_headers.remove(id).is_some() {
log::debug!( log::debug!(
target: "bridge", target: "bridge",
"Received completion data from {} for header: {:?}", "Received completion data from {} for header: {:?}",
@@ -377,6 +380,7 @@ impl<P: HeadersSyncPipeline> QueuedHeaders<P> {
); );
self.completion_data.insert(*id, completion); self.completion_data.insert(*id, completion);
self.incomplete_headers.insert(*id, Some(Instant::now()));
} }
} }
@@ -1410,26 +1414,29 @@ pub(crate) mod tests {
let mut queue = QueuedHeaders::<TestHeadersSyncPipeline>::default(); let mut queue = QueuedHeaders::<TestHeadersSyncPipeline>::default();
queue.incomplete_headers.insert(id(100), None); queue.incomplete_headers.insert(id(100), None);
queue.incomplete_headers.insert(id(200), Some(Instant::now())); queue.incomplete_headers.insert(id(200), Some(Instant::now()));
queue.incomplete_headers.insert(id(300), Some(Instant::now()));
// when headers isn't incompete, nothing changes // when header isn't incompete, nothing changes
queue.completion_response(&id(300), None); queue.completion_response(&id(400), None);
assert_eq!(queue.incomplete_headers.len(), 2); assert_eq!(queue.incomplete_headers.len(), 3);
assert_eq!(queue.completion_data.len(), 0); assert_eq!(queue.completion_data.len(), 0);
assert_eq!(queue.header_to_complete(), None); assert_eq!(queue.header_to_complete(), None);
// when response is None, nothing changes // when response is None, nothing changes
queue.completion_response(&id(100), None); queue.completion_response(&id(100), None);
assert_eq!(queue.incomplete_headers.len(), 2); assert_eq!(queue.incomplete_headers.len(), 3);
assert_eq!(queue.completion_data.len(), 0); assert_eq!(queue.completion_data.len(), 0);
assert_eq!(queue.header_to_complete(), None); assert_eq!(queue.header_to_complete(), None);
// when response is Some, we're scheduling completion // when response is Some, we're scheduling completion
queue.completion_response(&id(200), Some(200_200)); queue.completion_response(&id(200), Some(200_200));
assert_eq!(queue.incomplete_headers.len(), 2);
assert_eq!(queue.completion_data.len(), 1); assert_eq!(queue.completion_data.len(), 1);
assert!(queue.incomplete_headers.contains_key(&id(100)));
assert!(queue.completion_data.contains_key(&id(200))); assert!(queue.completion_data.contains_key(&id(200)));
assert_eq!(queue.header_to_complete(), Some((id(200), &200_200))); assert_eq!(queue.header_to_complete(), Some((id(200), &200_200)));
assert_eq!(
queue.incomplete_headers.keys().collect::<Vec<_>>(),
vec![&id(100), &id(300), &id(200)],
);
} }
#[test] #[test]