pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-14 04:01:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Nomination pool configurations can be managed by custom origin (#3959)

Browse Source 
closes https://github.com/paritytech/polkadot-sdk/issues/3894

Allows Nomination Pool configuration to be set by a custom origin
instead of root.

In runtimes, we would set this to be `StakingAdmin`, same as for
pallet-staking.

---------

Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
This commit is contained in:
Ankan
2024-04-09 12:14:19 +02:00
committed by GitHub
parent 6ce126a88d
commit 10ed76437f
9 changed files with 61 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/frame/nomination-pools/src/tests.rs
+23 -5
View File
@@ -19,7 +19,11 @@ use super::*;
use crate::{mock::*, Event};
use frame_support::{assert_err, assert_noop, assert_ok, assert_storage_noop};
use pallet_balances::Event as BEvent;
use sp_runtime::{bounded_btree_map, traits::Dispatchable, FixedU128};
use sp_runtime::{
bounded_btree_map,
traits::{BadOrigin, Dispatchable},
FixedU128,
};
macro_rules! unbonding_pools_with_era {
($($k:expr => $v:expr),* $(,)?) => {{
@@ -4996,9 +5000,23 @@ mod set_configs {
#[test]
fn set_configs_works() {
ExtBuilder::default().build_and_execute(|| {
// Setting works
// only admin origin can set configs
assert_noop!(
Pools::set_configs(
RuntimeOrigin::signed(20),
ConfigOp::Set(1 as Balance),
ConfigOp::Set(2 as Balance),
ConfigOp::Set(3u32),
ConfigOp::Set(4u32),
ConfigOp::Set(5u32),
ConfigOp::Set(Perbill::from_percent(6))
),
BadOrigin
);
// Setting works by Admin (42)
assert_ok!(Pools::set_configs(
RuntimeOrigin::root(),
RuntimeOrigin::signed(42),
ConfigOp::Set(1 as Balance),
ConfigOp::Set(2 as Balance),
ConfigOp::Set(3u32),
@@ -5015,7 +5033,7 @@ mod set_configs {
// Noop does nothing
assert_storage_noop!(assert_ok!(Pools::set_configs(
RuntimeOrigin::root(),
RuntimeOrigin::signed(42),
ConfigOp::Noop,
ConfigOp::Noop,
ConfigOp::Noop,
@@ -5026,7 +5044,7 @@ mod set_configs {
// Removing works
assert_ok!(Pools::set_configs(
RuntimeOrigin::root(),
RuntimeOrigin::signed(42),
ConfigOp::Remove,
ConfigOp::Remove,
ConfigOp::Remove,