Add field names to pallet Event variants (#9993)

* convert pallet-assets events to struct types

* updated events of a couple pallets

* updated pallet event field names

* update pallet event field names

* updated events in test files

* cargo fmt

* minorfixes

* fix assertion error

* minor fix

* formatting fix

* fmt
This commit is contained in:
David Salami
2021-11-16 02:56:00 +01:00
committed by GitHub
parent fb3c7326c2
commit 120894fdb7
48 changed files with 1181 additions and 681 deletions
+15 -15
View File
@@ -89,16 +89,16 @@ pub mod pallet {
#[pallet::event]
#[pallet::generate_deposit(pub(super) fn deposit_event)]
pub enum Event<T: Config> {
/// A name was set. \[who\]
NameSet(T::AccountId),
/// A name was forcibly set. \[target\]
NameForced(T::AccountId),
/// A name was changed. \[who\]
NameChanged(T::AccountId),
/// A name was cleared, and the given balance returned. \[who, deposit\]
NameCleared(T::AccountId, BalanceOf<T>),
/// A name was removed and the given balance slashed. \[target, deposit\]
NameKilled(T::AccountId, BalanceOf<T>),
/// A name was set.
NameSet { who: T::AccountId },
/// A name was forcibly set.
NameForced { target: T::AccountId },
/// A name was changed.
NameChanged { who: T::AccountId },
/// A name was cleared, and the given balance returned.
NameCleared { who: T::AccountId, deposit: BalanceOf<T> },
/// A name was removed and the given balance slashed.
NameKilled { target: T::AccountId, deposit: BalanceOf<T> },
}
/// Error for the nicks pallet.
@@ -147,12 +147,12 @@ pub mod pallet {
ensure!(name.len() <= T::MaxLength::get() as usize, Error::<T>::TooLong);
let deposit = if let Some((_, deposit)) = <NameOf<T>>::get(&sender) {
Self::deposit_event(Event::<T>::NameChanged(sender.clone()));
Self::deposit_event(Event::<T>::NameChanged { who: sender.clone() });
deposit
} else {
let deposit = T::ReservationFee::get();
T::Currency::reserve(&sender, deposit.clone())?;
Self::deposit_event(Event::<T>::NameSet(sender.clone()));
Self::deposit_event(Event::<T>::NameSet { who: sender.clone() });
deposit
};
@@ -179,7 +179,7 @@ pub mod pallet {
let err_amount = T::Currency::unreserve(&sender, deposit.clone());
debug_assert!(err_amount.is_zero());
Self::deposit_event(Event::<T>::NameCleared(sender, deposit));
Self::deposit_event(Event::<T>::NameCleared { who: sender, deposit });
Ok(())
}
@@ -210,7 +210,7 @@ pub mod pallet {
// Slash their deposit from them.
T::Slashed::on_unbalanced(T::Currency::slash_reserved(&target, deposit.clone()).0);
Self::deposit_event(Event::<T>::NameKilled(target, deposit));
Self::deposit_event(Event::<T>::NameKilled { target, deposit });
Ok(())
}
@@ -238,7 +238,7 @@ pub mod pallet {
let deposit = <NameOf<T>>::get(&target).map(|x| x.1).unwrap_or_else(Zero::zero);
<NameOf<T>>::insert(&target, (name, deposit));
Self::deposit_event(Event::<T>::NameForced(target));
Self::deposit_event(Event::<T>::NameForced { target });
Ok(())
}
}