cargo: Switch to workspace lints (#1299)

* subxt: Remove unstable lints that cause compile warnings

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* cargo: Switch to workspace lints

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* cargo: Fix codec package at root level

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* cargo: Move profiles to the root level

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Fix lightclient and metadata crates

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* Revert "cargo: Fix codec package at root level"

This reverts commit cdf9e1628d708a972673eb3a9e967b6896edbd73.

* Fix complexity clippy

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* cargo: Remove lints to be replaced by `cargo machete`

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* cargo: Remove unused dependencies (detected by machete)

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* ci: Add machete step

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* cargo: Bump rust version

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* ci: Rename machete step

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

* ci: Rename cargo machete step

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

---------

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

lightclient/Cargo.toml

@@ -14,6 +14,9 @@ homepage.workspace = true
 description = "Light Client for chain interaction"
 keywords = ["parity", "substrate", "blockchain"]
 
+[lints]
+workspace = true
+
 [features]
 default = ["native"]
 
@@ -72,17 +75,7 @@ wasm-bindgen = { workspace = true, optional = true }
 wasm-bindgen-futures = { workspace = true, optional = true }
 futures-timer = { workspace = true, optional = true }
 instant = { workspace = true, optional = true }
-tokio-util = { workspace = true, optional = true }
 pin-project = { workspace = true, optional = true }
 
 # Included if "web" feature is enabled, to enable its js feature.
 getrandom = { workspace = true, optional = true }
-
-[profile.dev.package.smoldot-light]
-opt-level = 2
-[profile.test.package.smoldot-light]
-opt-level = 2
-[profile.dev.package.smoldot]
-opt-level = 2
-[profile.test.package.smoldot]
-opt-level = 2

lightclient/src/background.rs

@@ -55,6 +55,7 @@ pub enum FromSubxt {
 }
 
 /// Background task data.
+#[allow(clippy::type_complexity)]
 pub struct BackgroundTask<TPlatform: PlatformRef, TChain> {
     /// Smoldot light client implementation that leverages the exposed platform.
     client: smoldot_light::Client<TPlatform, TChain>,

lightclient/src/client.rs

@@ -1,7 +1,6 @@
 // Copyright 2019-2023 Parity Technologies (UK) Ltd.
 // This file is dual-licensed as Apache-2.0 or GPL-3.0.
 // see LICENSE for license details.
-
 use std::iter;
 
 use super::{
@@ -175,6 +174,7 @@ impl LightClientRpc {
     ///
     /// This method sends a request to the light-client to establish an RPC subscription with the provided parameters.
     /// The parameters are parsed into a valid JSON object in the background.
+    #[allow(clippy::type_complexity)]
     pub fn subscription_request(
         &self,
         method: String,

lightclient/src/lib.rs

@@ -10,14 +10,6 @@
 //!
 //! This leverages the smoldot crate to connect to the chain.
 
-#![deny(
-    missing_docs,
-    unused_crate_dependencies,
-    unused_extern_crates,
-    clippy::all
-)]
-#![allow(clippy::type_complexity)]
-
 #[cfg(any(
     all(feature = "web", feature = "native"),
     not(any(feature = "web", feature = "native"))