From 1c5729c2de167434cefb07f4fbeac60ca3b29578 Mon Sep 17 00:00:00 2001 From: Javier Bullrich Date: Thu, 22 Jun 2023 17:01:57 +0200 Subject: [PATCH] fixed one member of two teams prs counting individually (#2770) Fixed the problem that, if a member of two of the required teams reviews a Pr that belongs to `^parachains/runtimes/assets/(asset-hub-kusama|asset-hub-polkadot)/src/[^/]+\.rs$|^parachains/runtimes/bridge-hubs/(bridge-hub-kusama|bridge-hub-polkadot)/src/[^/]+\.rs$|^parachains/runtimes/collectives/collectives-polkadot/src/[^/]+\.rs$|^parachains/common/src/[^/]+\.rs$` it won't count as enough reviews. By changing the `all_distinct` to `all` this will allow one member of both teams to fulfill the requirements for the PR --- cumulus/.github/pr-custom-review.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cumulus/.github/pr-custom-review.yml b/cumulus/.github/pr-custom-review.yml index fc26ee677f..e8cb400877 100644 --- a/cumulus/.github/pr-custom-review.yml +++ b/cumulus/.github/pr-custom-review.yml @@ -7,7 +7,7 @@ rules: - name: Runtime files check_type: changed_files condition: ^parachains/runtimes/assets/(asset-hub-kusama|asset-hub-polkadot)/src/[^/]+\.rs$|^parachains/runtimes/bridge-hubs/(bridge-hub-kusama|bridge-hub-polkadot)/src/[^/]+\.rs$|^parachains/runtimes/collectives/collectives-polkadot/src/[^/]+\.rs$|^parachains/common/src/[^/]+\.rs$ - all_distinct: + all: - min_approvals: 1 teams: - cumulus-locks-review