Network crate cleanups (#3049)

* Remove useless internal messages

* Remove NetworkService::disconnect_peer

* Remove NetworkMsg altogether

* Rename ProtocolMsg ServerToWorkerMsg

* Remove useless code

* Add example for parse_str_addr

* Move parse_str_addr and ProtocolId to config

* Don't reexport the content of config

* Rework the imports

* More reexports rework

* Add documentation

* Move finalization report to network future

* Move on_block_imported to worker

* get_value/put_value no longer locking

* local_peer_id() no longer locks

* Remove FetchFuture

* Service imports cleanup

* Produce the network state in the network task

* Merge network task and RPC network task

* Move network methods to NetworkWorker

* Remove Arc peers system from network

* add_reserved_peer now goes through the channel

* Remove Mutex around network swarm

* Remove the FnOnce alias traits

* Replace is_offline with num_connected

* Improve style of poll()

* Fix network tests

* Some doc in service module

* Remove macro export

* Minor doc changes

* Remove the synchronized() method of the import queue

* Line width

* Line widths

* Fix import queue tests

* Fix CLI tests
This commit is contained in:
Pierre Krieger
2019-07-08 15:33:29 +02:00
committed by Gavin Wood
parent 7df8e52cfe
commit 1e126eab2f
24 changed files with 598 additions and 814 deletions
@@ -16,6 +16,8 @@
//! Specializations of the substrate network protocol to allow more complex forms of communication.
pub use crate::protocol::event::{DhtEvent, Event};
use crate::protocol::Context;
use libp2p::PeerId;
use runtime_primitives::traits::Block as BlockT;
@@ -40,10 +42,7 @@ pub trait NetworkSpecialization<B: BlockT>: Send + Sync + 'static {
);
/// Called when a network-specific event arrives.
fn on_event(
&mut self,
event: crate::protocol::event::Event
);
fn on_event(&mut self, event: Event);
/// Called on abort.
#[deprecated(note = "This method is never called; aborting corresponds to dropping the object")]
@@ -138,7 +137,7 @@ macro_rules! construct_simple_protocol {
fn on_event(
&mut self,
_event: $crate::event::Event
_event: $crate::specialization::Event
) {
$( self.$sub_protocol_name.on_event(_event); )*
}