mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-01 01:01:01 +00:00
Remove Default bound for AccountId (#10403)
* Remove Default for AccountId * More removals of default * Update frame/authorship/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update frame/authorship/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update frame/authorship/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update frame/authorship/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * More work * More work * Remove old code * More work * pallet-asset-tx-payment * tips * sc-consensus-babe * sc-finality-grandpa * sc-consensus-babe-rpc * sc-cli * make npos crates accept non-default account (#10420) * minimal changes to make npos pallets all work * make this pesky reduce.rs a bit cleaner * more work * more work * Tests build * Fix imonline tests * Formatting * Fixes * Fixes * Fix bench * Fixes * Fixes * Fixes * Fixes * Fixes * Formatting * Fixes * Formatting * Fixes * Formatting * Fixes * Formatting * Fixes * Formatting * Update client/keystore/src/local.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/finality-grandpa/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/keystore/src/local.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/keystore/src/local.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update frame/staking/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update frame/staking/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update primitives/runtime/src/traits.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Formatting Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: kianenigma <kian@parity.io>
This commit is contained in:
@@ -753,7 +753,7 @@ impl<N: Ord + Clone> AuthoritySetChanges<N> {
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
use sp_core::crypto::Public;
|
||||
use sp_core::crypto::{ByteArray, UncheckedFrom};
|
||||
|
||||
fn static_is_descendent_of<A>(value: bool) -> impl Fn(&A, &A) -> Result<bool, std::io::Error> {
|
||||
move |_, _| Ok(value)
|
||||
@@ -768,7 +768,7 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn current_limit_filters_min() {
|
||||
let current_authorities = vec![(AuthorityId::from_slice(&[1; 32]), 1)];
|
||||
let current_authorities = vec![(AuthorityId::from_slice(&[1; 32]).unwrap(), 1)];
|
||||
|
||||
let mut authorities = AuthoritySet {
|
||||
current_authorities: current_authorities.clone(),
|
||||
@@ -802,7 +802,7 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn changes_iterated_in_pre_order() {
|
||||
let current_authorities = vec![(AuthorityId::from_slice(&[1; 32]), 1)];
|
||||
let current_authorities = vec![(AuthorityId::from_slice(&[1; 32]).unwrap(), 1)];
|
||||
|
||||
let mut authorities = AuthoritySet {
|
||||
current_authorities: current_authorities.clone(),
|
||||
@@ -894,8 +894,8 @@ mod tests {
|
||||
authority_set_changes: AuthoritySetChanges::empty(),
|
||||
};
|
||||
|
||||
let set_a = vec![(AuthorityId::from_slice(&[1; 32]), 5)];
|
||||
let set_b = vec![(AuthorityId::from_slice(&[2; 32]), 5)];
|
||||
let set_a = vec![(AuthorityId::from_slice(&[1; 32]).unwrap(), 5)];
|
||||
let set_b = vec![(AuthorityId::from_slice(&[2; 32]).unwrap(), 5)];
|
||||
|
||||
// two competing changes at the same height on different forks
|
||||
let change_a = PendingChange {
|
||||
@@ -977,8 +977,8 @@ mod tests {
|
||||
authority_set_changes: AuthoritySetChanges::empty(),
|
||||
};
|
||||
|
||||
let set_a = vec![(AuthorityId::from_slice(&[1; 32]), 5)];
|
||||
let set_c = vec![(AuthorityId::from_slice(&[2; 32]), 5)];
|
||||
let set_a = vec![(AuthorityId::from_slice(&[1; 32]).unwrap(), 5)];
|
||||
let set_c = vec![(AuthorityId::from_slice(&[2; 32]).unwrap(), 5)];
|
||||
|
||||
// two competing changes at the same height on different forks
|
||||
let change_a = PendingChange {
|
||||
@@ -1057,7 +1057,7 @@ mod tests {
|
||||
authority_set_changes: AuthoritySetChanges::empty(),
|
||||
};
|
||||
|
||||
let set_a = vec![(AuthorityId::from_slice(&[1; 32]), 5)];
|
||||
let set_a = vec![(AuthorityId::from_slice(&[1; 32]).unwrap(), 5)];
|
||||
|
||||
let change_a = PendingChange {
|
||||
next_authorities: set_a.clone(),
|
||||
@@ -1128,8 +1128,8 @@ mod tests {
|
||||
authority_set_changes: AuthoritySetChanges::empty(),
|
||||
};
|
||||
|
||||
let set_a = vec![(AuthorityId::from_slice(&[1; 32]), 5)];
|
||||
let set_b = vec![(AuthorityId::from_slice(&[2; 32]), 5)];
|
||||
let set_a = vec![(AuthorityId::from_slice(&[1; 32]).unwrap(), 5)];
|
||||
let set_b = vec![(AuthorityId::from_slice(&[2; 32]).unwrap(), 5)];
|
||||
|
||||
let change_a = PendingChange {
|
||||
next_authorities: set_a.clone(),
|
||||
@@ -1228,7 +1228,7 @@ mod tests {
|
||||
authority_set_changes: AuthoritySetChanges::empty(),
|
||||
};
|
||||
|
||||
let set_a = vec![(AuthorityId::from_slice(&[1; 32]), 5)];
|
||||
let set_a = vec![(AuthorityId::from_slice(&[1; 32]).unwrap(), 5)];
|
||||
|
||||
// we create a forced change with no delay
|
||||
let change_a = PendingChange {
|
||||
@@ -1253,7 +1253,7 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn forced_changes_blocked_by_standard_changes() {
|
||||
let set_a = vec![(AuthorityId::from_slice(&[1; 32]), 1)];
|
||||
let set_a = vec![(AuthorityId::from_slice(&[1; 32]).unwrap(), 1)];
|
||||
|
||||
let mut authorities = AuthoritySet {
|
||||
current_authorities: set_a.clone(),
|
||||
@@ -1378,7 +1378,7 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn next_change_works() {
|
||||
let current_authorities = vec![(AuthorityId::from_slice(&[1; 32]), 1)];
|
||||
let current_authorities = vec![(AuthorityId::from_slice(&[1; 32]).unwrap(), 1)];
|
||||
|
||||
let mut authorities = AuthoritySet {
|
||||
current_authorities: current_authorities.clone(),
|
||||
@@ -1493,8 +1493,10 @@ mod tests {
|
||||
None,
|
||||
);
|
||||
|
||||
let invalid_authorities_weight =
|
||||
vec![(AuthorityId::from_slice(&[1; 32]), 5), (AuthorityId::from_slice(&[2; 32]), 0)];
|
||||
let invalid_authorities_weight = vec![
|
||||
(AuthorityId::from_slice(&[1; 32]).unwrap(), 5),
|
||||
(AuthorityId::from_slice(&[2; 32]).unwrap(), 0),
|
||||
];
|
||||
|
||||
// authority weight of zero is invalid
|
||||
assert_eq!(AuthoritySet::<(), ()>::genesis(invalid_authorities_weight.clone()), None);
|
||||
@@ -1510,7 +1512,8 @@ mod tests {
|
||||
);
|
||||
|
||||
let mut authority_set =
|
||||
AuthoritySet::<(), u64>::genesis(vec![(AuthorityId::from_slice(&[1; 32]), 5)]).unwrap();
|
||||
AuthoritySet::<(), u64>::genesis(vec![(AuthorityId::unchecked_from([1; 32]), 5)])
|
||||
.unwrap();
|
||||
|
||||
let invalid_change_empty_authorities = PendingChange {
|
||||
next_authorities: vec![],
|
||||
@@ -1550,7 +1553,7 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn cleans_up_stale_forced_changes_when_applying_standard_change() {
|
||||
let current_authorities = vec![(AuthorityId::from_slice(&[1; 32]), 1)];
|
||||
let current_authorities = vec![(AuthorityId::from_slice(&[1; 32]).unwrap(), 1)];
|
||||
|
||||
let mut authorities = AuthoritySet {
|
||||
current_authorities: current_authorities.clone(),
|
||||
|
||||
Reference in New Issue
Block a user