pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-05-30 22:11:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Eliminate experimental feature (#3654)

Browse Source 
Totally removes the `experimental` feature. Closes #3648.

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
This commit is contained in:
s0me0ne-unkn0wn
2024-03-17 21:02:11 +01:00
committed by GitHub
parent d2a7100e3b
commit 1f9505c0d3
41 changed files with 15 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cumulus/pallets/collator-selection/Cargo.toml
-2
View File
@@ -77,5 +77,3 @@ try-runtime = [
"pallet-timestamp/try-runtime",
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
cumulus/pallets/collator-selection/src/mock.rs
-1
View File
@@ -125,7 +125,6 @@ impl pallet_aura::Config for Test {
type MaxAuthorities = ConstU32<100_000>;
type DisabledValidators = ();
type AllowMultipleBlocksPerSlot = ConstBool<false>;
#[cfg(feature = "experimental")]
type SlotDuration = pallet_aura::MinimumPeriodTimesTwo<Self>;
}
cumulus/parachains/runtimes/assets/asset-hub-rococo/Cargo.toml
-2
View File
@@ -251,8 +251,6 @@ std = [
"xcm/std",
]
experimental = ["pallet-aura/experimental"]
# A feature that should be enabled when the runtime should be built for on-chain
# deployment. This will disable stuff that shouldn't be part of the on-chain wasm
# to make it smaller, like logging for example.
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/lib.rs
-4
View File
@@ -187,10 +187,7 @@ impl pallet_timestamp::Config for Runtime {
/// A timestamp: milliseconds since the unix epoch.
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
}
@@ -723,7 +720,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<true>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
cumulus/parachains/runtimes/assets/asset-hub-westend/Cargo.toml
-2
View File
@@ -236,8 +236,6 @@ std = [
"xcm/std",
]
experimental = ["pallet-aura/experimental"]
# A feature that should be enabled when the runtime should be built for on-chain
# deployment. This will disable stuff that shouldn't be part of the on-chain wasm
# to make it smaller, like logging for example.
cumulus/parachains/runtimes/assets/asset-hub-westend/src/lib.rs
-4
View File
@@ -171,10 +171,7 @@ impl pallet_timestamp::Config for Runtime {
/// A timestamp: milliseconds since the unix epoch.
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
}
@@ -703,7 +700,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<true>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/Cargo.toml
-1
View File
@@ -296,7 +296,6 @@ try-runtime = [
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
fast-runtime = []
# A feature that should be enabled when the runtime should be built for on-chain
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/lib.rs
-4
View File
@@ -277,10 +277,7 @@ impl pallet_timestamp::Config for Runtime {
/// A timestamp: milliseconds since the unix epoch.
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
}
@@ -445,7 +442,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<true>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/Cargo.toml
-2
View File
@@ -246,8 +246,6 @@ try-runtime = [
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
# A feature that should be enabled when the runtime should be built for on-chain
# deployment. This will disable stuff that shouldn't be part of the on-chain wasm
# to make it smaller, like logging for example.
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/lib.rs
-4
View File
@@ -251,10 +251,7 @@ impl pallet_timestamp::Config for Runtime {
/// A timestamp: milliseconds since the unix epoch.
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
}
@@ -407,7 +404,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<true>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
cumulus/parachains/runtimes/collectives/collectives-westend/Cargo.toml
-2
View File
@@ -232,8 +232,6 @@ std = [
"xcm/std",
]
experimental = ["pallet-aura/experimental"]
# A feature that should be enabled when the runtime should be built for on-chain
# deployment. This will disable stuff that shouldn't be part of the on-chain wasm
# to make it smaller, like logging for example.
cumulus/parachains/runtimes/collectives/collectives-westend/src/lib.rs
-4
View File
@@ -184,10 +184,7 @@ impl pallet_timestamp::Config for Runtime {
/// A timestamp: milliseconds since the unix epoch.
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
}
@@ -483,7 +480,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<true>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
cumulus/parachains/runtimes/contracts/contracts-rococo/Cargo.toml
-2
View File
@@ -196,8 +196,6 @@ try-runtime = [
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
# A feature that should be enabled when the runtime should be built for on-chain
# deployment. This will disable stuff that shouldn't be part of the on-chain wasm
# to make it smaller, like logging for example.
cumulus/parachains/runtimes/contracts/contracts-rococo/src/lib.rs
-4
View File
@@ -193,10 +193,7 @@ impl pallet_timestamp::Config for Runtime {
/// A timestamp: milliseconds since the unix epoch.
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
type WeightInfo = pallet_timestamp::weights::SubstrateWeight<Runtime>;
}
@@ -349,7 +346,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<true>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
cumulus/parachains/runtimes/coretime/coretime-rococo/Cargo.toml
-2
View File
@@ -194,6 +194,4 @@ try-runtime = [
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
fast-runtime = []
cumulus/parachains/runtimes/coretime/coretime-rococo/src/lib.rs
-4
View File
@@ -206,10 +206,7 @@ impl pallet_timestamp::Config for Runtime {
/// A timestamp: milliseconds since the unix epoch.
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
}
@@ -369,7 +366,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<true>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
cumulus/parachains/runtimes/coretime/coretime-westend/Cargo.toml
-2
View File
@@ -190,6 +190,4 @@ try-runtime = [
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
fast-runtime = []
cumulus/parachains/runtimes/coretime/coretime-westend/src/lib.rs
-4
View File
@@ -206,10 +206,7 @@ impl pallet_timestamp::Config for Runtime {
/// A timestamp: milliseconds since the unix epoch.
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
}
@@ -369,7 +366,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<true>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
cumulus/parachains/runtimes/glutton/glutton-westend/Cargo.toml
-2
View File
@@ -135,8 +135,6 @@ try-runtime = [
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
# A feature that should be enabled when the runtime should be built for on-chain
# deployment. This will disable stuff that shouldn't be part of the on-chain wasm
# to make it smaller, like logging for example.
cumulus/parachains/runtimes/glutton/glutton-westend/src/lib.rs
-4
View File
@@ -221,10 +221,7 @@ impl cumulus_pallet_aura_ext::Config for Runtime {}
impl pallet_timestamp::Config for Runtime {
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
}
@@ -233,7 +230,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<true>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
cumulus/parachains/runtimes/people/people-rococo/Cargo.toml
-2
View File
@@ -188,5 +188,3 @@ try-runtime = [
"polkadot-runtime-common/try-runtime",
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
cumulus/parachains/runtimes/people/people-rococo/src/lib.rs
-4
View File
@@ -187,10 +187,7 @@ impl pallet_timestamp::Config for Runtime {
/// A timestamp: milliseconds since the unix epoch.
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
}
@@ -337,7 +334,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<true>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
cumulus/parachains/runtimes/people/people-westend/Cargo.toml
-2
View File
@@ -188,5 +188,3 @@ try-runtime = [
"polkadot-runtime-common/try-runtime",
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
cumulus/parachains/runtimes/people/people-westend/src/lib.rs
-4
View File
@@ -187,10 +187,7 @@ impl pallet_timestamp::Config for Runtime {
/// A timestamp: milliseconds since the unix epoch.
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
type WeightInfo = weights::pallet_timestamp::WeightInfo<Runtime>;
}
@@ -337,7 +334,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<true>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
cumulus/parachains/runtimes/starters/seedling/Cargo.toml
-2
View File
@@ -79,5 +79,3 @@ std = [
"sp-version/std",
"substrate-wasm-builder",
]
experimental = ["pallet-aura/experimental"]
cumulus/parachains/runtimes/starters/seedling/src/lib.rs
-4
View File
@@ -213,17 +213,13 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<false>;
#[cfg(feature = "experimental")]
type SlotDuration = pallet_aura::MinimumPeriodTimesTwo<Self>;
}
impl pallet_timestamp::Config for Runtime {
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ parachains_common::SLOT_DURATION / 2 }>;
type WeightInfo = ();
}
cumulus/parachains/runtimes/starters/shell/Cargo.toml
-2
View File
@@ -99,5 +99,3 @@ try-runtime = [
"parachain-info/try-runtime",
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
cumulus/parachains/runtimes/starters/shell/src/lib.rs
-4
View File
@@ -241,17 +241,13 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<false>;
#[cfg(feature = "experimental")]
type SlotDuration = pallet_aura::MinimumPeriodTimesTwo<Self>;
}
impl pallet_timestamp::Config for Runtime {
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ parachains_common::SLOT_DURATION / 2 }>;
type WeightInfo = ();
}
cumulus/parachains/runtimes/testing/penpal/Cargo.toml
-2
View File
@@ -191,5 +191,3 @@ try-runtime = [
"polkadot-runtime-common/try-runtime",
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
cumulus/parachains/runtimes/testing/penpal/src/lib.rs
-1
View File
@@ -582,7 +582,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<false>;
#[cfg(feature = "experimental")]
type SlotDuration = pallet_aura::MinimumPeriodTimesTwo<Self>;
}
cumulus/parachains/runtimes/testing/rococo-parachain/Cargo.toml
-2
View File
@@ -134,5 +134,3 @@ runtime-benchmarks = [
"xcm-builder/runtime-benchmarks",
"xcm-executor/runtime-benchmarks",
]
experimental = ["pallet-aura/experimental"]
cumulus/parachains/runtimes/testing/rococo-parachain/src/lib.rs
-4
View File
@@ -228,10 +228,7 @@ impl pallet_timestamp::Config for Runtime {
/// A timestamp: milliseconds since the unix epoch.
type Moment = u64;
type OnTimestampSet = Aura;
#[cfg(feature = "experimental")]
type MinimumPeriod = ConstU64<0>;
#[cfg(not(feature = "experimental"))]
type MinimumPeriod = ConstU64<{ SLOT_DURATION / 2 }>;
type WeightInfo = ();
}
@@ -594,7 +591,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<true>;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
docs/sdk/Cargo.toml
-3
View File
@@ -86,6 +86,3 @@ sp-version = { path = "../../substrate/primitives/version" }
# XCM
xcm = { package = "staging-xcm", path = "../../polkadot/xcm" }
[features]
experimental = ["pallet-aura/experimental"]
docs/sdk/src/polkadot_sdk/cumulus.rs
-1
View File
@@ -110,7 +110,6 @@ mod tests {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<false>;
#[cfg(feature = "experimental")]
type SlotDuration = pallet_aura::MinimumPeriodTimesTwo<Self>;
}
prdoc/pr_3654.prdoc
+14
View File
@@ -0,0 +1,14 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json
title: Remove `experimental` feature from `pallet-aura`
doc:
- audience: Runtime Dev
description: |
The `experimental` feature in `pallet-aura`, previously used to gate different experimental
changes, became redundant with the introduction of the async backing which relies on the
mentioned changes, therefore, it is removed.
crates:
- name: pallet-aura
substrate/frame/aura/src/lib.rs
-17
View File
@@ -66,9 +66,6 @@ const LOG_TARGET: &str = "runtime::aura";
///
/// This was the default behavior of the Aura pallet and may be used for
/// backwards compatibility.
///
/// Note that this type is likely not useful without the `experimental`
/// feature.
pub struct MinimumPeriodTimesTwo<T>(sp_std::marker::PhantomData<T>);
impl<T: pallet_timestamp::Config> Get<T::Moment> for MinimumPeriodTimesTwo<T> {
@@ -117,10 +114,6 @@ pub mod pallet {
/// The effective value of this type should not change while the chain is running.
///
/// For backwards compatibility either use [`MinimumPeriodTimesTwo`] or a const.
///
/// This associated type is only present when compiled with the `experimental`
/// feature.
#[cfg(feature = "experimental")]
type SlotDuration: Get<<Self as pallet_timestamp::Config>::Moment>;
}
@@ -250,19 +243,9 @@ impl<T: Config> Pallet<T> {
/// Determine the Aura slot-duration based on the Timestamp module configuration.
pub fn slot_duration() -> T::Moment {
#[cfg(feature = "experimental")]
{
T::SlotDuration::get()
}
#[cfg(not(feature = "experimental"))]
{
// we double the minimum block-period so each author can always propose within
// the majority of its slot.
<T as pallet_timestamp::Config>::MinimumPeriod::get().saturating_mul(2u32.into())
}
}
/// Ensure the correctness of the state of this pallet.
///
/// This should be valid before or after each state transition of this pallet.
substrate/frame/aura/src/mock.rs
-2
View File
@@ -84,8 +84,6 @@ impl pallet_aura::Config for Test {
type DisabledValidators = MockDisabledValidators;
type MaxAuthorities = ConstU32<10>;
type AllowMultipleBlocksPerSlot = AllowMultipleBlocksPerSlot;
#[cfg(feature = "experimental")]
type SlotDuration = ConstU64<SLOT_DURATION>;
}
templates/parachain/runtime/Cargo.toml
-2
View File
@@ -194,5 +194,3 @@ try-runtime = [
"polkadot-runtime-common/try-runtime",
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
templates/parachain/runtime/src/lib.rs
-1
View File
@@ -453,7 +453,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<100_000>;
type AllowMultipleBlocksPerSlot = ConstBool<false>;
#[cfg(feature = "experimental")]
type SlotDuration = pallet_aura::MinimumPeriodTimesTwo<Self>;
}
templates/solochain/runtime/Cargo.toml
-2
View File
@@ -147,5 +147,3 @@ try-runtime = [
"pallet-transaction-payment/try-runtime",
"sp-runtime/try-runtime",
]
experimental = ["pallet-aura/experimental"]
templates/solochain/runtime/src/lib.rs
-2
View File
@@ -180,8 +180,6 @@ impl pallet_aura::Config for Runtime {
type DisabledValidators = ();
type MaxAuthorities = ConstU32<32>;
type AllowMultipleBlocksPerSlot = ConstBool<false>;
#[cfg(feature = "experimental")]
type SlotDuration = pallet_aura::MinimumPeriodTimesTwo<Runtime>;
}