Clean up the wasm-builder and release 1.0.8 (#3858)

substrate/core/utils/wasm-builder/src/lib.rs

@@ -205,9 +205,7 @@ impl CargoCommand {
 	}
 
 	fn args(&mut self, args: &[&str]) -> &mut Self {
-		for arg in args {
-			self.arg(arg);
-		}
+		args.into_iter().for_each(|a| { self.arg(a); });
 		self
 	}
 
@@ -227,12 +225,17 @@ impl CargoCommand {
 
 	/// Check if the supplied cargo command is a nightly version
 	fn is_nightly(&self) -> bool {
-		self.command()
-			.arg("--version")
-			.output()
-			.map_err(|_| ())
-			.and_then(|o| String::from_utf8(o.stdout).map_err(|_| ()))
-			.unwrap_or_default()
-			.contains("-nightly")
+		// `RUSTC_BOOTSTRAP` tells a stable compiler to behave like a nightly. So, when this env
+		// variable is set, we can assume that whatever rust compiler we have, it is a nightly compiler.
+		// For "more" information, see:
+		// https://github.com/rust-lang/rust/blob/fa0f7d0080d8e7e9eb20aa9cbf8013f96c81287f/src/libsyntax/feature_gate/check.rs#L891
+		env::var("RUSTC_BOOTSTRAP").is_ok() ||
+			self.command()
+				.arg("--version")
+				.output()
+				.map_err(|_| ())
+				.and_then(|o| String::from_utf8(o.stdout).map_err(|_| ()))
+				.unwrap_or_default()
+				.contains("-nightly")
 	}
 }

substrate/core/utils/wasm-builder/src/prerequisites.rs

@@ -14,7 +14,8 @@
 // You should have received a copy of the GNU General Public License
 // along with Substrate.  If not, see <http://www.gnu.org/licenses/>.
 
-use std::{env, fs};
+use std::fs;
+
 use tempfile::tempdir;
 
 /// Checks that all prerequisites are installed.
@@ -22,20 +23,15 @@ use tempfile::tempdir;
 /// # Returns
 /// Returns `None` if everything was found and `Some(ERR_MSG)` if something could not be found.
 pub fn check() -> Option<&'static str> {
-	if !rustc_stable_forced_to_nightly() && !check_nightly_installed(){
+	if !check_nightly_installed(){
 		return Some("Rust nightly not installed, please install it!")
 	}
 
 	check_wasm_toolchain_installed()
 }
 
-fn rustc_stable_forced_to_nightly() -> bool {
-  env::var("RUSTC_BOOTSTRAP") == Ok("1".to_string())
-}
-
 fn check_nightly_installed() -> bool {
-	let command = crate::get_nightly_cargo();
-	command.is_nightly()
+	crate::get_nightly_cargo().is_nightly()
 }
 
 fn check_wasm_toolchain_installed() -> Option<&'static str> {