Remove TransientValidationData (#2272)

* collation-generation: use persisted validation data

* node: remote FullValidationData API

* runtime: remove FullValidationData API

* backing tests: use persisted validation data

* FullCandidateReceipt: use persisted validation data

This is not a big change since this type is not used anywhere

* Remove ValidationData and TransientValidationData

Also update the guide

polkadot/parachain/test-parachains/adder/collator/src/lib.rs

@@ -148,7 +148,7 @@ impl Collator {
 		let state = self.state.clone();
 
 		Box::new(move |relay_parent, validation_data| {
-			let parent = HeadData::decode(&mut &validation_data.persisted.parent_head.0[..])
+			let parent = HeadData::decode(&mut &validation_data.parent_head.0[..])
 				.expect("Decodes parent head");
 
 			let (block_data, head_data) = state.lock().unwrap().advance(parent);
@@ -168,7 +168,7 @@ impl Collator {
 					block_data: block_data.encode().into(),
 				},
 				processed_downward_messages: 0,
-				hrmp_watermark: validation_data.persisted.block_number,
+				hrmp_watermark: validation_data.block_number,
 			};
 
 			async move { Some(collation) }.boxed()
@@ -196,7 +196,7 @@ mod tests {
 
 	use futures::executor::block_on;
 	use polkadot_parachain::{primitives::ValidationParams, wasm_executor::IsolationStrategy};
-	use polkadot_primitives::v1::{PersistedValidationData, ValidationData};
+	use polkadot_primitives::v1::PersistedValidationData;
 
 	#[test]
 	fn collator_works() {
@@ -213,11 +213,8 @@ mod tests {
 				.unwrap()
 				.clone();
 
-			let validation_data = ValidationData {
-				persisted: PersistedValidationData {
-					parent_head: parent_head.encode().into(),
-					..Default::default()
-				},
+			let validation_data = PersistedValidationData {
+				parent_head: parent_head.encode().into(),
 				..Default::default()
 			};