Remove TransientValidationData (#2272)

* collation-generation: use persisted validation data

* node: remote FullValidationData API

* runtime: remove FullValidationData API

* backing tests: use persisted validation data

* FullCandidateReceipt: use persisted validation data

This is not a big change since this type is not used anywhere

* Remove ValidationData and TransientValidationData

Also update the guide

polkadot/runtime/parachains/src/runtime_api_impl/v1.rs

@@ -21,7 +21,7 @@ use sp_std::prelude::*;
 use sp_std::collections::btree_map::BTreeMap;
 use sp_runtime::traits::One;
 use primitives::v1::{
-	ValidatorId, ValidatorIndex, GroupRotationInfo, CoreState, ValidationData,
+	ValidatorId, ValidatorIndex, GroupRotationInfo, CoreState,
 	Id as ParaId, OccupiedCoreAssumption, SessionIndex, ValidationCode,
 	CommittedCandidateReceipt, ScheduledCore, OccupiedCore, CoreOccupied, CoreIndex,
 	GroupIndex, CandidateEvent, PersistedValidationData, SessionInfo,
@@ -193,30 +193,6 @@ fn with_assumption<Config, T, F>(
 	}
 }
 
-/// Implementation for the `full_validation_data` function of the runtime API.
-pub fn full_validation_data<T: initializer::Config>(
-	para_id: ParaId,
-	assumption: OccupiedCoreAssumption,
-) -> Option<ValidationData<T::BlockNumber>> {
-	use parity_scale_codec::Decode as _;
-	let relay_parent_number = <frame_system::Module<T>>::block_number();
-	let relay_storage_root = Hash::decode(&mut &sp_io::storage::root()[..])
-		.expect("storage root must decode to the Hash type; qed");
-	with_assumption::<T, _, _>(para_id, assumption, || {
-		Some(ValidationData {
-			persisted: crate::util::make_persisted_validation_data::<T>(
-				para_id,
-				relay_parent_number,
-				relay_storage_root,
-			)?,
-			transient: crate::util::make_transient_validation_data::<T>(
-				para_id,
-				relay_parent_number,
-			)?,
-		})
-	})
-}
-
 /// Implementation for the `persisted_validation_data` function of the runtime API.
 pub fn persisted_validation_data<T: initializer::Config>(
 	para_id: ParaId,