pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-07-24 20:35:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

client/network-gossip/state_machine: Fix log message (#5350)

Browse Source 
A gossip validator returns `ValidationResult::Discard` for messages that
should not be processed nor kept due to not being useful for the node.
Examples are out-of-scope messages or messages with bad signatures. The
corresponding log message did not reflect this, thus the update through
this patch.

One caveat is a finality grandpa neighbor packet. Given that the concept
of neighbor packets is handled in the finality grandpa gossip validator
only, valid neighbor packets are always discarded on the
`client/network-gossip` layer.
This commit is contained in:
Max Inden
2020-03-23 11:04:48 +01:00
committed by GitHub
parent 28ae4042fd
commit 26a204da21
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/client/network-gossip/src/state_machine.rs
+2 -3
View File
@@ -353,8 +353,7 @@ impl<B: BlockT> ConsensusGossip<B> {
/// Handle an incoming message for topic by who via protocol. Discard message if topic already /// Handle an incoming message for topic by who via protocol. Discard message if topic already
/// known, the message is old, its source peers isn't a registered peer or the connection to /// known, the message is old, its source peers isn't a registered peer or the connection to
/// them is broken. Return `Some(topic, message)` if it was added to the internal queue, `None` /// them is broken.
/// in all other cases.
pub fn on_incoming( pub fn on_incoming(
&mut self, &mut self,
network: &mut dyn Network<B>, network: &mut dyn Network<B>,
@@ -421,7 +420,7 @@ impl<B: BlockT> ConsensusGossip<B> {
network.report_peer(who.clone(), rep::UNREGISTERED_TOPIC); network.report_peer(who.clone(), rep::UNREGISTERED_TOPIC);
} }
} else { } else {
trace!(target:"gossip", "Handled valid one hop message from peer {}", who); trace!(target:"gossip", "Discard message from peer {}", who);
} }
} }
} }