Remove candidate selection (#3148)

* Create validator_side module

* Subsume Candidate Selection

* Add test to ensure candidate backing logic is correct

* Ensure secondings are adequately cleaned up and address test flakyness

* Address Feedback

polkadot/node/network/bridge/src/lib.rs

@@ -2365,7 +2365,6 @@ mod tests {
 			match msg {
 				AllMessages::CandidateValidation(_) => unreachable!("Not interested in network events"),
 				AllMessages::CandidateBacking(_) => unreachable!("Not interested in network events"),
-				AllMessages::CandidateSelection(_) => unreachable!("Not interested in network events"),
 				AllMessages::ChainApi(_) => unreachable!("Not interested in network events"),
 				AllMessages::CollatorProtocol(_) => unreachable!("Not interested in network events"),
 				AllMessages::StatementDistribution(_) => { cnt += 1; }

polkadot/node/network/collator-protocol/src/collator_side.rs

@@ -570,30 +570,12 @@ async fn process_msg(
 				}
 			}
 		}
-		FetchCollation(_, _, _, _) => {
-			tracing::warn!(
-				target: LOG_TARGET,
-				"FetchCollation message is not expected on the collator side of the protocol",
-			);
-		}
 		ReportCollator(_) => {
 			tracing::warn!(
 				target: LOG_TARGET,
 				"ReportCollator message is not expected on the collator side of the protocol",
 			);
 		}
-		NoteGoodCollation(_) => {
-			tracing::warn!(
-				target: LOG_TARGET,
-				"NoteGoodCollation message is not expected on the collator side of the protocol",
-			);
-		}
-		NotifyCollationSeconded(_, _, _) => {
-			tracing::warn!(
-				target: LOG_TARGET,
-				"NotifyCollationSeconded message is not expected on the collator side of the protocol",
-			);
-		}
 		NetworkBridgeUpdateV1(event) => {
 			if let Err(e) = handle_network_msg(
 				ctx,
@@ -646,6 +628,7 @@ async fn process_msg(
 				}
 			}
 		}
+		_ => {},
 	}
 
 	Ok(())

polkadot/node/network/protocol/src/lib.rs

@@ -294,8 +294,9 @@ pub mod v1 {
 	use polkadot_primitives::v1::{
 		CandidateHash, CandidateIndex, CollatorId, CollatorSignature,
 		CompactStatement, Hash, Id as ParaId, UncheckedSignedAvailabilityBitfield,
-		ValidatorIndex, ValidatorSignature
+		ValidatorIndex, ValidatorSignature,
 	};
+
 	use polkadot_node_primitives::{
 		approval::{IndirectAssignmentCert, IndirectSignedApprovalVote},
 		UncheckedSignedFullStatement,