[pallet-staking] Refund unused weight for payout_stakers (#8458)

* [pallet-staking] Refund unused weight for `payout_stakers` 

fixes #8428

* Use periods in comments

* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs

* Address Shawn's Feedback

* Assert monotomic weights && improve test note

* Remove stray new line

* debug_assert payout_count <= max

* Only track payouts to nominators; not validators

* Trivial comment update

Co-authored-by: Parity Benchmarking Bot <admin@parity.io>
This commit is contained in:
Zeke Mostov
2021-03-28 01:09:32 -07:00
committed by GitHub
parent 49e79967c8
commit 2af0de50c9
4 changed files with 280 additions and 124 deletions
+103 -103
View File
@@ -18,7 +18,7 @@
//! Autogenerated weights for pallet_staking
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 3.0.0
//! DATE: 2021-03-19, STEPS: `[50, ]`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! DATE: 2021-03-25, STEPS: `[50, ]`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("dev"), DB CACHE: 128
// Executed Command:
@@ -76,155 +76,155 @@ pub trait WeightInfo {
pub struct SubstrateWeight<T>(PhantomData<T>);
impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn bond() -> Weight {
(82_121_000 as Weight)
(79_895_000 as Weight)
.saturating_add(T::DbWeight::get().reads(5 as Weight))
.saturating_add(T::DbWeight::get().writes(4 as Weight))
}
fn bond_extra() -> Weight {
(61_899_000 as Weight)
(60_561_000 as Weight)
.saturating_add(T::DbWeight::get().reads(3 as Weight))
.saturating_add(T::DbWeight::get().writes(2 as Weight))
}
fn unbond() -> Weight {
(56_392_000 as Weight)
(54_996_000 as Weight)
.saturating_add(T::DbWeight::get().reads(4 as Weight))
.saturating_add(T::DbWeight::get().writes(3 as Weight))
}
fn withdraw_unbonded_update(s: u32, ) -> Weight {
(57_382_000 as Weight)
(56_056_000 as Weight)
// Standard Error: 0
.saturating_add((70_000 as Weight).saturating_mul(s as Weight))
.saturating_add((67_000 as Weight).saturating_mul(s as Weight))
.saturating_add(T::DbWeight::get().reads(4 as Weight))
.saturating_add(T::DbWeight::get().writes(3 as Weight))
}
fn withdraw_unbonded_kill(s: u32, ) -> Weight {
(92_185_000 as Weight)
(90_267_000 as Weight)
// Standard Error: 1_000
.saturating_add((2_844_000 as Weight).saturating_mul(s as Weight))
.saturating_add((2_787_000 as Weight).saturating_mul(s as Weight))
.saturating_add(T::DbWeight::get().reads(6 as Weight))
.saturating_add(T::DbWeight::get().writes(8 as Weight))
.saturating_add(T::DbWeight::get().writes((1 as Weight).saturating_mul(s as Weight)))
}
fn validate() -> Weight {
(16_892_000 as Weight)
(16_345_000 as Weight)
.saturating_add(T::DbWeight::get().reads(1 as Weight))
.saturating_add(T::DbWeight::get().writes(2 as Weight))
}
fn kick(k: u32, ) -> Weight {
(27_411_000 as Weight)
(27_080_000 as Weight)
// Standard Error: 14_000
.saturating_add((19_272_000 as Weight).saturating_mul(k as Weight))
.saturating_add((18_739_000 as Weight).saturating_mul(k as Weight))
.saturating_add(T::DbWeight::get().reads(1 as Weight))
.saturating_add(T::DbWeight::get().reads((1 as Weight).saturating_mul(k as Weight)))
.saturating_add(T::DbWeight::get().writes((1 as Weight).saturating_mul(k as Weight)))
}
fn nominate(n: u32, ) -> Weight {
(30_188_000 as Weight)
// Standard Error: 24_000
.saturating_add((5_666_000 as Weight).saturating_mul(n as Weight))
(29_101_000 as Weight)
// Standard Error: 23_000
.saturating_add((5_670_000 as Weight).saturating_mul(n as Weight))
.saturating_add(T::DbWeight::get().reads(3 as Weight))
.saturating_add(T::DbWeight::get().reads((1 as Weight).saturating_mul(n as Weight)))
.saturating_add(T::DbWeight::get().writes(2 as Weight))
}
fn chill() -> Weight {
(15_870_000 as Weight)
(15_771_000 as Weight)
.saturating_add(T::DbWeight::get().reads(1 as Weight))
.saturating_add(T::DbWeight::get().writes(2 as Weight))
}
fn set_payee() -> Weight {
(13_853_000 as Weight)
(13_329_000 as Weight)
.saturating_add(T::DbWeight::get().reads(1 as Weight))
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
fn set_controller() -> Weight {
(30_291_000 as Weight)
(29_807_000 as Weight)
.saturating_add(T::DbWeight::get().reads(3 as Weight))
.saturating_add(T::DbWeight::get().writes(3 as Weight))
}
fn set_validator_count() -> Weight {
(2_397_000 as Weight)
(2_323_000 as Weight)
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
fn force_no_eras() -> Weight {
(2_627_000 as Weight)
(2_528_000 as Weight)
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
fn force_new_era() -> Weight {
(2_679_000 as Weight)
(2_529_000 as Weight)
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
fn force_new_era_always() -> Weight {
(2_643_000 as Weight)
(2_527_000 as Weight)
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
fn set_invulnerables(v: u32, ) -> Weight {
(2_871_000 as Weight)
(2_661_000 as Weight)
// Standard Error: 0
.saturating_add((35_000 as Weight).saturating_mul(v as Weight))
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
fn force_unstake(s: u32, ) -> Weight {
(65_876_000 as Weight)
(64_650_000 as Weight)
// Standard Error: 1_000
.saturating_add((2_832_000 as Weight).saturating_mul(s as Weight))
.saturating_add((2_755_000 as Weight).saturating_mul(s as Weight))
.saturating_add(T::DbWeight::get().reads(4 as Weight))
.saturating_add(T::DbWeight::get().writes(8 as Weight))
.saturating_add(T::DbWeight::get().writes((1 as Weight).saturating_mul(s as Weight)))
}
fn cancel_deferred_slash(s: u32, ) -> Weight {
(5_896_640_000 as Weight)
// Standard Error: 391_000
.saturating_add((34_808_000 as Weight).saturating_mul(s as Weight))
(5_904_642_000 as Weight)
// Standard Error: 393_000
.saturating_add((34_810_000 as Weight).saturating_mul(s as Weight))
.saturating_add(T::DbWeight::get().reads(1 as Weight))
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
fn payout_stakers_dead_controller(n: u32, ) -> Weight {
(137_975_000 as Weight)
// Standard Error: 20_000
.saturating_add((54_061_000 as Weight).saturating_mul(n as Weight))
(131_368_000 as Weight)
// Standard Error: 17_000
.saturating_add((52_611_000 as Weight).saturating_mul(n as Weight))
.saturating_add(T::DbWeight::get().reads(10 as Weight))
.saturating_add(T::DbWeight::get().reads((3 as Weight).saturating_mul(n as Weight)))
.saturating_add(T::DbWeight::get().writes(2 as Weight))
.saturating_add(T::DbWeight::get().writes((1 as Weight).saturating_mul(n as Weight)))
}
fn payout_stakers_alive_staked(n: u32, ) -> Weight {
(163_885_000 as Weight)
// Standard Error: 20_000
.saturating_add((68_096_000 as Weight).saturating_mul(n as Weight))
(165_079_000 as Weight)
// Standard Error: 27_000
.saturating_add((66_740_000 as Weight).saturating_mul(n as Weight))
.saturating_add(T::DbWeight::get().reads(11 as Weight))
.saturating_add(T::DbWeight::get().reads((5 as Weight).saturating_mul(n as Weight)))
.saturating_add(T::DbWeight::get().writes(3 as Weight))
.saturating_add(T::DbWeight::get().writes((3 as Weight).saturating_mul(n as Weight)))
}
fn rebond(l: u32, ) -> Weight {
(37_847_000 as Weight)
// Standard Error: 1_000
.saturating_add((89_000 as Weight).saturating_mul(l as Weight))
(37_039_000 as Weight)
// Standard Error: 2_000
.saturating_add((93_000 as Weight).saturating_mul(l as Weight))
.saturating_add(T::DbWeight::get().reads(3 as Weight))
.saturating_add(T::DbWeight::get().writes(3 as Weight))
}
fn set_history_depth(e: u32, ) -> Weight {
(0 as Weight)
// Standard Error: 69_000
.saturating_add((34_413_000 as Weight).saturating_mul(e as Weight))
// Standard Error: 71_000
.saturating_add((34_403_000 as Weight).saturating_mul(e as Weight))
.saturating_add(T::DbWeight::get().reads(2 as Weight))
.saturating_add(T::DbWeight::get().writes(4 as Weight))
.saturating_add(T::DbWeight::get().writes((7 as Weight).saturating_mul(e as Weight)))
}
fn reap_stash(s: u32, ) -> Weight {
(69_257_000 as Weight)
// Standard Error: 1_000
.saturating_add((2_819_000 as Weight).saturating_mul(s as Weight))
(67_561_000 as Weight)
// Standard Error: 0
.saturating_add((2_766_000 as Weight).saturating_mul(s as Weight))
.saturating_add(T::DbWeight::get().reads(4 as Weight))
.saturating_add(T::DbWeight::get().writes(8 as Weight))
.saturating_add(T::DbWeight::get().writes((1 as Weight).saturating_mul(s as Weight)))
}
fn new_era(v: u32, n: u32, ) -> Weight {
(0 as Weight)
// Standard Error: 1_013_000
.saturating_add((382_529_000 as Weight).saturating_mul(v as Weight))
// Standard Error: 50_000
.saturating_add((63_170_000 as Weight).saturating_mul(n as Weight))
// Standard Error: 1_016_000
.saturating_add((389_979_000 as Weight).saturating_mul(v as Weight))
// Standard Error: 51_000
.saturating_add((63_208_000 as Weight).saturating_mul(n as Weight))
.saturating_add(T::DbWeight::get().reads(10 as Weight))
.saturating_add(T::DbWeight::get().reads((3 as Weight).saturating_mul(v as Weight)))
.saturating_add(T::DbWeight::get().reads((3 as Weight).saturating_mul(n as Weight)))
@@ -233,12 +233,12 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
}
fn get_npos_voters(v: u32, n: u32, s: u32, ) -> Weight {
(0 as Weight)
// Standard Error: 90_000
.saturating_add((27_108_000 as Weight).saturating_mul(v as Weight))
// Standard Error: 90_000
.saturating_add((29_962_000 as Weight).saturating_mul(n as Weight))
// Standard Error: 1_228_000
.saturating_add((26_080_000 as Weight).saturating_mul(s as Weight))
// Standard Error: 95_000
.saturating_add((26_419_000 as Weight).saturating_mul(v as Weight))
// Standard Error: 95_000
.saturating_add((29_033_000 as Weight).saturating_mul(n as Weight))
// Standard Error: 1_305_000
.saturating_add((23_680_000 as Weight).saturating_mul(s as Weight))
.saturating_add(T::DbWeight::get().reads(3 as Weight))
.saturating_add(T::DbWeight::get().reads((3 as Weight).saturating_mul(v as Weight)))
.saturating_add(T::DbWeight::get().reads((3 as Weight).saturating_mul(n as Weight)))
@@ -247,7 +247,7 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
fn get_npos_targets(v: u32, ) -> Weight {
(0 as Weight)
// Standard Error: 32_000
.saturating_add((11_220_000 as Weight).saturating_mul(v as Weight))
.saturating_add((11_317_000 as Weight).saturating_mul(v as Weight))
.saturating_add(T::DbWeight::get().reads(1 as Weight))
.saturating_add(T::DbWeight::get().reads((1 as Weight).saturating_mul(v as Weight)))
}
@@ -256,155 +256,155 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// For backwards compatibility and tests
impl WeightInfo for () {
fn bond() -> Weight {
(82_121_000 as Weight)
(79_895_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(5 as Weight))
.saturating_add(RocksDbWeight::get().writes(4 as Weight))
}
fn bond_extra() -> Weight {
(61_899_000 as Weight)
(60_561_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(3 as Weight))
.saturating_add(RocksDbWeight::get().writes(2 as Weight))
}
fn unbond() -> Weight {
(56_392_000 as Weight)
(54_996_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(4 as Weight))
.saturating_add(RocksDbWeight::get().writes(3 as Weight))
}
fn withdraw_unbonded_update(s: u32, ) -> Weight {
(57_382_000 as Weight)
(56_056_000 as Weight)
// Standard Error: 0
.saturating_add((70_000 as Weight).saturating_mul(s as Weight))
.saturating_add((67_000 as Weight).saturating_mul(s as Weight))
.saturating_add(RocksDbWeight::get().reads(4 as Weight))
.saturating_add(RocksDbWeight::get().writes(3 as Weight))
}
fn withdraw_unbonded_kill(s: u32, ) -> Weight {
(92_185_000 as Weight)
(90_267_000 as Weight)
// Standard Error: 1_000
.saturating_add((2_844_000 as Weight).saturating_mul(s as Weight))
.saturating_add((2_787_000 as Weight).saturating_mul(s as Weight))
.saturating_add(RocksDbWeight::get().reads(6 as Weight))
.saturating_add(RocksDbWeight::get().writes(8 as Weight))
.saturating_add(RocksDbWeight::get().writes((1 as Weight).saturating_mul(s as Weight)))
}
fn validate() -> Weight {
(16_892_000 as Weight)
(16_345_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(1 as Weight))
.saturating_add(RocksDbWeight::get().writes(2 as Weight))
}
fn kick(k: u32, ) -> Weight {
(27_411_000 as Weight)
(27_080_000 as Weight)
// Standard Error: 14_000
.saturating_add((19_272_000 as Weight).saturating_mul(k as Weight))
.saturating_add((18_739_000 as Weight).saturating_mul(k as Weight))
.saturating_add(RocksDbWeight::get().reads(1 as Weight))
.saturating_add(RocksDbWeight::get().reads((1 as Weight).saturating_mul(k as Weight)))
.saturating_add(RocksDbWeight::get().writes((1 as Weight).saturating_mul(k as Weight)))
}
fn nominate(n: u32, ) -> Weight {
(30_188_000 as Weight)
// Standard Error: 24_000
.saturating_add((5_666_000 as Weight).saturating_mul(n as Weight))
(29_101_000 as Weight)
// Standard Error: 23_000
.saturating_add((5_670_000 as Weight).saturating_mul(n as Weight))
.saturating_add(RocksDbWeight::get().reads(3 as Weight))
.saturating_add(RocksDbWeight::get().reads((1 as Weight).saturating_mul(n as Weight)))
.saturating_add(RocksDbWeight::get().writes(2 as Weight))
}
fn chill() -> Weight {
(15_870_000 as Weight)
(15_771_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(1 as Weight))
.saturating_add(RocksDbWeight::get().writes(2 as Weight))
}
fn set_payee() -> Weight {
(13_853_000 as Weight)
(13_329_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(1 as Weight))
.saturating_add(RocksDbWeight::get().writes(1 as Weight))
}
fn set_controller() -> Weight {
(30_291_000 as Weight)
(29_807_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(3 as Weight))
.saturating_add(RocksDbWeight::get().writes(3 as Weight))
}
fn set_validator_count() -> Weight {
(2_397_000 as Weight)
(2_323_000 as Weight)
.saturating_add(RocksDbWeight::get().writes(1 as Weight))
}
fn force_no_eras() -> Weight {
(2_627_000 as Weight)
(2_528_000 as Weight)
.saturating_add(RocksDbWeight::get().writes(1 as Weight))
}
fn force_new_era() -> Weight {
(2_679_000 as Weight)
(2_529_000 as Weight)
.saturating_add(RocksDbWeight::get().writes(1 as Weight))
}
fn force_new_era_always() -> Weight {
(2_643_000 as Weight)
(2_527_000 as Weight)
.saturating_add(RocksDbWeight::get().writes(1 as Weight))
}
fn set_invulnerables(v: u32, ) -> Weight {
(2_871_000 as Weight)
(2_661_000 as Weight)
// Standard Error: 0
.saturating_add((35_000 as Weight).saturating_mul(v as Weight))
.saturating_add(RocksDbWeight::get().writes(1 as Weight))
}
fn force_unstake(s: u32, ) -> Weight {
(65_876_000 as Weight)
(64_650_000 as Weight)
// Standard Error: 1_000
.saturating_add((2_832_000 as Weight).saturating_mul(s as Weight))
.saturating_add((2_755_000 as Weight).saturating_mul(s as Weight))
.saturating_add(RocksDbWeight::get().reads(4 as Weight))
.saturating_add(RocksDbWeight::get().writes(8 as Weight))
.saturating_add(RocksDbWeight::get().writes((1 as Weight).saturating_mul(s as Weight)))
}
fn cancel_deferred_slash(s: u32, ) -> Weight {
(5_896_640_000 as Weight)
// Standard Error: 391_000
.saturating_add((34_808_000 as Weight).saturating_mul(s as Weight))
(5_904_642_000 as Weight)
// Standard Error: 393_000
.saturating_add((34_810_000 as Weight).saturating_mul(s as Weight))
.saturating_add(RocksDbWeight::get().reads(1 as Weight))
.saturating_add(RocksDbWeight::get().writes(1 as Weight))
}
fn payout_stakers_dead_controller(n: u32, ) -> Weight {
(137_975_000 as Weight)
// Standard Error: 20_000
.saturating_add((54_061_000 as Weight).saturating_mul(n as Weight))
(131_368_000 as Weight)
// Standard Error: 17_000
.saturating_add((52_611_000 as Weight).saturating_mul(n as Weight))
.saturating_add(RocksDbWeight::get().reads(10 as Weight))
.saturating_add(RocksDbWeight::get().reads((3 as Weight).saturating_mul(n as Weight)))
.saturating_add(RocksDbWeight::get().writes(2 as Weight))
.saturating_add(RocksDbWeight::get().writes((1 as Weight).saturating_mul(n as Weight)))
}
fn payout_stakers_alive_staked(n: u32, ) -> Weight {
(163_885_000 as Weight)
// Standard Error: 20_000
.saturating_add((68_096_000 as Weight).saturating_mul(n as Weight))
(165_079_000 as Weight)
// Standard Error: 27_000
.saturating_add((66_740_000 as Weight).saturating_mul(n as Weight))
.saturating_add(RocksDbWeight::get().reads(11 as Weight))
.saturating_add(RocksDbWeight::get().reads((5 as Weight).saturating_mul(n as Weight)))
.saturating_add(RocksDbWeight::get().writes(3 as Weight))
.saturating_add(RocksDbWeight::get().writes((3 as Weight).saturating_mul(n as Weight)))
}
fn rebond(l: u32, ) -> Weight {
(37_847_000 as Weight)
// Standard Error: 1_000
.saturating_add((89_000 as Weight).saturating_mul(l as Weight))
(37_039_000 as Weight)
// Standard Error: 2_000
.saturating_add((93_000 as Weight).saturating_mul(l as Weight))
.saturating_add(RocksDbWeight::get().reads(3 as Weight))
.saturating_add(RocksDbWeight::get().writes(3 as Weight))
}
fn set_history_depth(e: u32, ) -> Weight {
(0 as Weight)
// Standard Error: 69_000
.saturating_add((34_413_000 as Weight).saturating_mul(e as Weight))
// Standard Error: 71_000
.saturating_add((34_403_000 as Weight).saturating_mul(e as Weight))
.saturating_add(RocksDbWeight::get().reads(2 as Weight))
.saturating_add(RocksDbWeight::get().writes(4 as Weight))
.saturating_add(RocksDbWeight::get().writes((7 as Weight).saturating_mul(e as Weight)))
}
fn reap_stash(s: u32, ) -> Weight {
(69_257_000 as Weight)
// Standard Error: 1_000
.saturating_add((2_819_000 as Weight).saturating_mul(s as Weight))
(67_561_000 as Weight)
// Standard Error: 0
.saturating_add((2_766_000 as Weight).saturating_mul(s as Weight))
.saturating_add(RocksDbWeight::get().reads(4 as Weight))
.saturating_add(RocksDbWeight::get().writes(8 as Weight))
.saturating_add(RocksDbWeight::get().writes((1 as Weight).saturating_mul(s as Weight)))
}
fn new_era(v: u32, n: u32, ) -> Weight {
(0 as Weight)
// Standard Error: 1_013_000
.saturating_add((382_529_000 as Weight).saturating_mul(v as Weight))
// Standard Error: 50_000
.saturating_add((63_170_000 as Weight).saturating_mul(n as Weight))
// Standard Error: 1_016_000
.saturating_add((389_979_000 as Weight).saturating_mul(v as Weight))
// Standard Error: 51_000
.saturating_add((63_208_000 as Weight).saturating_mul(n as Weight))
.saturating_add(RocksDbWeight::get().reads(10 as Weight))
.saturating_add(RocksDbWeight::get().reads((3 as Weight).saturating_mul(v as Weight)))
.saturating_add(RocksDbWeight::get().reads((3 as Weight).saturating_mul(n as Weight)))
@@ -413,12 +413,12 @@ impl WeightInfo for () {
}
fn get_npos_voters(v: u32, n: u32, s: u32, ) -> Weight {
(0 as Weight)
// Standard Error: 90_000
.saturating_add((27_108_000 as Weight).saturating_mul(v as Weight))
// Standard Error: 90_000
.saturating_add((29_962_000 as Weight).saturating_mul(n as Weight))
// Standard Error: 1_228_000
.saturating_add((26_080_000 as Weight).saturating_mul(s as Weight))
// Standard Error: 95_000
.saturating_add((26_419_000 as Weight).saturating_mul(v as Weight))
// Standard Error: 95_000
.saturating_add((29_033_000 as Weight).saturating_mul(n as Weight))
// Standard Error: 1_305_000
.saturating_add((23_680_000 as Weight).saturating_mul(s as Weight))
.saturating_add(RocksDbWeight::get().reads(3 as Weight))
.saturating_add(RocksDbWeight::get().reads((3 as Weight).saturating_mul(v as Weight)))
.saturating_add(RocksDbWeight::get().reads((3 as Weight).saturating_mul(n as Weight)))
@@ -427,7 +427,7 @@ impl WeightInfo for () {
fn get_npos_targets(v: u32, ) -> Weight {
(0 as Weight)
// Standard Error: 32_000
.saturating_add((11_220_000 as Weight).saturating_mul(v as Weight))
.saturating_add((11_317_000 as Weight).saturating_mul(v as Weight))
.saturating_add(RocksDbWeight::get().reads(1 as Weight))
.saturating_add(RocksDbWeight::get().reads((1 as Weight).saturating_mul(v as Weight)))
}