Create issues for all TODOs/FIXMEs (#224)

* network and validation

* remainder of todos

* ref new issue

* change issue number
This commit is contained in:
joe petrowski
2019-04-08 17:46:20 +02:00
committed by Robert Habermeier
parent 33df0a4adf
commit 2bbfa0ae98
11 changed files with 13 additions and 8 deletions
+2 -1
View File
@@ -184,7 +184,7 @@ impl CollatorPool {
if let Some(para_id) = self.collators.get(&collator_id) {
debug_assert_eq!(para_id, &collation.receipt.parachain_index);
// TODO: punish if not primary?
// TODO: punish if not primary? (https://github.com/paritytech/polkadot/issues/213)
self.collations.entry((relay_parent, para_id.clone()))
.or_insert_with(CollationSlot::blank_now)
@@ -205,6 +205,7 @@ impl CollatorPool {
/// Returns a set of actions to perform on the network level.
pub fn maintain_peers(&mut self) -> Vec<Action> {
// TODO: rearrange periodically to new primary, evaluate based on latency etc.
// https://github.com/paritytech/polkadot/issues/214
Vec::new()
}
+1
View File
@@ -145,6 +145,7 @@ impl PeerInfo {
pub enum Message {
/// As a validator, tell the peer your current session key.
// TODO: do this with a cryptographic proof of some kind
// https://github.com/paritytech/polkadot/issues/47
SessionKey(SessionKey),
/// Requesting parachain block data by (relay_parent, candidate_hash).
RequestBlockData(RequestId, Hash, Hash),
+1
View File
@@ -148,6 +148,7 @@ impl NetworkService for TestNetwork {
let mut context = TestContext::default();
let res = with(&mut *self.proto.lock(), &mut context);
// TODO: send context to worker for message routing.
// https://github.com/paritytech/polkadot/issues/215
res
}
}