Create issues for all TODOs/FIXMEs (#224)

* network and validation

* remainder of todos

* ref new issue

* change issue number
This commit is contained in:
joe petrowski
2019-04-08 17:46:20 +02:00
committed by Robert Habermeier
parent 33df0a4adf
commit 2bbfa0ae98
11 changed files with 13 additions and 8 deletions
+1 -1
View File
@@ -59,7 +59,7 @@ use primitives::bytes;
/// An index to a block.
/// 32-bits will allow for 136 years of blocks assuming 1 block per second.
/// TODO: switch to u32
/// TODO: switch to u32 (https://github.com/paritytech/polkadot/issues/221)
pub type BlockNumber = u64;
/// Alias to 512-bit hash when used in the context of a signature on the relay chain.
+1
View File
@@ -152,6 +152,7 @@ impl PartialOrd for CandidateReceipt {
impl Ord for CandidateReceipt {
fn cmp(&self, other: &Self) -> Ordering {
// TODO: compare signatures or something more sane
// https://github.com/paritytech/polkadot/issues/222
self.parachain_index.cmp(&other.parachain_index)
.then_with(|| self.head_data.cmp(&other.head_data))
}