Create issues for all TODOs/FIXMEs (#224)

* network and validation

* remainder of todos

* ref new issue

* change issue number
This commit is contained in:
joe petrowski
2019-04-08 17:46:20 +02:00
committed by Robert Habermeier
parent 33df0a4adf
commit 2bbfa0ae98
11 changed files with 13 additions and 8 deletions
+1 -1
View File
@@ -48,7 +48,7 @@ pub trait Collators: Clone {
/// will be passed to the `TableRouter` instance.
fn collate(&self, parachain: ParaId, relay_parent: Hash) -> Self::Collation;
/// Note a bad collator. TODO: take proof
/// Note a bad collator. TODO: take proof (https://github.com/paritytech/polkadot/issues/217)
fn note_bad_collator(&self, collator: CollatorId);
}
+1 -1
View File
@@ -797,7 +797,7 @@ impl<C, TxApi> CreateProposal<C, TxApi> where
.join(", ")
);
// TODO: full re-evaluation
// TODO: full re-evaluation (https://github.com/paritytech/polkadot/issues/216)
let active_parachains = runtime_api.active_parachains(&self.parent_id)?;
assert!(evaluation::evaluate_initial(
&new_block,
@@ -139,6 +139,7 @@ impl SharedTableInner {
let digest = &summary.candidate;
// TODO: consider a strategy based on the number of candidate votes as well.
// https://github.com/paritytech/polkadot/issues/218
let do_validation = para_member && match self.validated.entry(digest.clone()) {
Entry::Occupied(_) => false,
Entry::Vacant(entry) => {