Proposal: Flatten AllPallets and similar types (#11813)

* flratten AllPallets types

* feature flag it

* fix

* fix

* fmt

* remove todo

* Update frame/support/src/traits/metadata.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update frame/support/src/migrations.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* fix

* mark as deprecated

* add docs

* fix ui test?

* fmt

Co-authored-by: parity-processbot <>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
This commit is contained in:
Kian Paimani
2022-08-14 20:06:02 +01:00
committed by GitHub
parent 6b0203c8c4
commit 2d988e5f60
15 changed files with 122 additions and 109 deletions
+8 -5
View File
@@ -1597,8 +1597,9 @@ fn test_storage_info() {
#[test]
fn assert_type_all_pallets_reversed_with_system_first_is_correct() {
// Just ensure the 2 types are same.
#[allow(deprecated)]
fn _a(_t: AllPalletsReversedWithSystemFirst) {}
fn _b(t: (System, (Example4, (Example2, (Example,))))) {
fn _b(t: (System, Example4, Example2, Example)) {
_a(t)
}
}
@@ -1607,7 +1608,7 @@ fn assert_type_all_pallets_reversed_with_system_first_is_correct() {
fn assert_type_all_pallets_with_system_is_correct() {
// Just ensure the 2 types are same.
fn _a(_t: AllPalletsWithSystem) {}
fn _b(t: (System, (Example, (Example2, (Example4,))))) {
fn _b(t: (System, Example, Example2, Example4)) {
_a(t)
}
}
@@ -1616,7 +1617,7 @@ fn assert_type_all_pallets_with_system_is_correct() {
fn assert_type_all_pallets_without_system_is_correct() {
// Just ensure the 2 types are same.
fn _a(_t: AllPalletsWithoutSystem) {}
fn _b(t: (Example, (Example2, (Example4,)))) {
fn _b(t: (Example, Example2, Example4)) {
_a(t)
}
}
@@ -1624,8 +1625,9 @@ fn assert_type_all_pallets_without_system_is_correct() {
#[test]
fn assert_type_all_pallets_with_system_reversed_is_correct() {
// Just ensure the 2 types are same.
#[allow(deprecated)]
fn _a(_t: AllPalletsWithSystemReversed) {}
fn _b(t: (Example4, (Example2, (Example, (System,))))) {
fn _b(t: (Example4, Example2, Example, System)) {
_a(t)
}
}
@@ -1633,8 +1635,9 @@ fn assert_type_all_pallets_with_system_reversed_is_correct() {
#[test]
fn assert_type_all_pallets_without_system_reversed_is_correct() {
// Just ensure the 2 types are same.
#[allow(deprecated)]
fn _a(_t: AllPalletsWithoutSystemReversed) {}
fn _b(t: (Example4, (Example2, (Example,)))) {
fn _b(t: (Example4, Example2, Example)) {
_a(t)
}
}
@@ -1,13 +1,13 @@
error[E0107]: missing generics for trait `Hooks`
--> $DIR/hooks_invalid_item.rs:12:18
--> tests/pallet_ui/hooks_invalid_item.rs:12:18
|
12 | impl<T: Config> Hooks for Pallet<T> {}
| ^^^^^ expected 1 generic argument
|
note: trait defined here, with 1 generic parameter: `BlockNumber`
--> $DIR/hooks.rs:214:11
--> $WORKSPACE/frame/support/src/traits/hooks.rs
|
214 | pub trait Hooks<BlockNumber> {
| pub trait Hooks<BlockNumber> {
| ^^^^^ -----------
help: add missing generic argument
|