Correct FIXME/TODO in service module (#164)

* remove TODO

TODO should have been removed after the last update

* add issue link to grandpa config

* add todo with link

* update issue link to substrate
This commit is contained in:
joe petrowski
2019-02-28 10:40:02 +01:00
committed by Bastian Köcher
parent 1348af4df2
commit 30472a18ab
2 changed files with 5 additions and 2 deletions
+2 -1
View File
@@ -54,7 +54,8 @@ fn staging_testnet_config_genesis() -> GenesisConfig {
const DAYS: u64 = HOURS * 24; const DAYS: u64 = HOURS * 24;
GenesisConfig { GenesisConfig {
consensus: Some(ConsensusConfig { consensus: Some(ConsensusConfig {
code: include_bytes!("../../runtime/wasm/target/wasm32-unknown-unknown/release/polkadot_runtime.compact.wasm").to_vec(), // TODO change // TODO: Change after Substrate 1252 is fixed (https://github.com/paritytech/substrate/issues/1252)
code: include_bytes!("../../runtime/wasm/target/wasm32-unknown-unknown/release/polkadot_runtime.compact.wasm").to_vec(),
authorities: initial_authorities.clone(), authorities: initial_authorities.clone(),
}), }),
system: None, system: None,
+3 -1
View File
@@ -178,7 +178,9 @@ construct_service_factory! {
{ {
let voter = grandpa::run_grandpa( let voter = grandpa::run_grandpa(
grandpa::Config { grandpa::Config {
gossip_duration: Duration::new(4, 0), // FIXME: make this available through chainspec? // TODO: make gossip_duration available through chainspec
// https://github.com/paritytech/substrate/issues/1578
gossip_duration: Duration::new(4, 0),
local_key: key.clone(), local_key: key.clone(),
justification_period: 4096, justification_period: 4096,
name: Some(service.config.name.clone()), name: Some(service.config.name.clone()),