pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-21 04:01:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extinguish DispatchResult (#1667)

Browse Source
This commit is contained in:
Sergei Shulepov
2020-09-02 15:13:56 +02:00
committed by GitHub
parent 27f4f42e74
commit 30d2db67e6
2 changed files with 6 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
polkadot/roadmap/implementers-guide/src/runtime/router.md
+6 -10
View File
@@ -214,21 +214,17 @@ any of dispatchables return an error.
`process_upward_dispatchables()`: `process_upward_dispatchables()`:
1. Initialize a cumulative weight counter `T` to 0 1. Initialize a cumulative weight counter `T` to 0
1. Initialize a local in memory dictionary `R` that maps `ParaId` to a vector of `DispatchResult`.
1. Iterate over items in `NeedsDispatch` cyclically, starting with `NextDispatchRoundStartWith`. If the item specified is `None` start from the beginning. For each `P` encountered: 1. Iterate over items in `NeedsDispatch` cyclically, starting with `NextDispatchRoundStartWith`. If the item specified is `None` start from the beginning. For each `P` encountered:
1. Dequeue `D` the first dispatchable `D` from `RelayDispatchQueues` for `P` 1. Dequeue `D` the first dispatchable `D` from `RelayDispatchQueues` for `P`
1. Decrement the size of the message from `RelayDispatchQueueSize` for `P` 1. Decrement the size of the message from `RelayDispatchQueueSize` for `P`
1. Decode `D` into a dispatchable. If failed append `DispatchResult::DecodeFailed` into `R` for `P`. Otherwise, if succeeded: 1. Decode `D` into a dispatchable. Otherwise, if succeeded:
1. If `weight_of(D) > config.dispatchable_upward_message_critical_weight` then append `DispatchResult::CriticalWeightExceeded` into `R` for `P`. Otherwise: 1. If `weight_of(D) > config.dispatchable_upward_message_critical_weight` then skip the dispatchable. Otherwise:
1. Execute `D` and add the actual amount of weight consumed to `T`. Add the `DispatchResult` into `R` for `P`. 1. Execute `D` and add the actual amount of weight consumed to `T`.
1. If `weight_of(D) + T > config.preferred_dispatchable_upward_messages_step_weight`, set `NextDispatchRoundStartWith` to `P` and finish processing. 1. If `weight_of(D) + T > config.preferred_dispatchable_upward_messages_step_weight`, set `NextDispatchRoundStartWith` to `P` and finish processing.
> NOTE that in practice we would need to approach the weight calculation more thoroughly, i.e. incorporate all operations > NOTE that in practice we would need to approach the weight calculation more thoroughly, i.e. incorporate all operations
> that could take place on the course of handling these dispatchables. > that could take place on the course of handling these dispatchables.
1. If `RelayDispatchQueues` for `P` became empty, remove `P` from `NeedsDispatch`. 1. If `RelayDispatchQueues` for `P` became empty, remove `P` from `NeedsDispatch`.
1. If `NeedsDispatch` became empty then finish processing and set `NextDispatchRoundStartWith` to `None`. 1. If `NeedsDispatch` became empty then finish processing and set `NextDispatchRoundStartWith` to `None`.
1. Then, for each `P` and the vector of `DispatchResult` in `R`:
1. Obtain a message by wrapping the vector into `DownwardMessage::DispatchResult`
1. Append the resulting message to `DownwardMessageQueues` for `P`.
## Session Change ## Session Change
polkadot/roadmap/implementers-guide/src/types/messages.md
-13
View File
@@ -106,20 +106,7 @@ could be seen as a notification, however, it is conceivable that they might be u
chain to send a request to the parachain (likely, through the `ParachainSpecific` variant). chain to send a request to the parachain (likely, through the `ParachainSpecific` variant).
```rust,ignore ```rust,ignore
enum DispatchResult {
Executed {
success: bool,
},
/// Decoding `RawDispatchable` into an executable runtime representation has failed.
DecodeFailed,
/// A dispatchable in question exceeded the maximum amount of weight allowed.
CriticalWeightExceeded,
}
enum DownwardMessage { enum DownwardMessage {
/// The parachain receives a dispatch result for each sent dispatchable upward message in order
/// they were sent.
DispatchResult(Vec<DispatchResult>),
/// Some funds were transferred into the parachain's account. The hash is the identifier that /// Some funds were transferred into the parachain's account. The hash is the identifier that
/// was given with the transfer. /// was given with the transfer.
TransferInto(AccountId, Balance, Remark), TransferInto(AccountId, Balance, Remark),