Use same fmt and clippy configs as in Substrate (#7611)

* Use same rustfmt.toml as Substrate

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* format format file

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Format with new config

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add Substrate Clippy config

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Print Clippy version in CI

Otherwise its difficult to reproduce locally.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Make fmt happy

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update node/core/pvf/src/error.rs

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>

* Update node/core/pvf/src/error.rs

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>

polkadot/node/network/dispute-distribution/src/lib.rs

@@ -60,8 +60,8 @@ use self::sender::{DisputeSender, DisputeSenderMessage};
 
 /// ## The receiver [`DisputesReceiver`]
 ///
-/// The receiving side is implemented as `DisputesReceiver` and is run as a separate long running task within
-/// this subsystem ([`DisputesReceiver::run`]).
+/// The receiving side is implemented as `DisputesReceiver` and is run as a separate long running
+/// task within this subsystem ([`DisputesReceiver::run`]).
 ///
 /// Conceptually all the receiver has to do, is waiting for incoming requests which are passed in
 /// via a dedicated channel and forwarding them to the dispute coordinator via
@@ -101,8 +101,8 @@ const LOG_TARGET: &'static str = "parachain::dispute-distribution";
 
 /// Rate limit on the `receiver` side.
 ///
-/// If messages from one peer come in at a higher rate than every `RECEIVE_RATE_LIMIT` on average, we
-/// start dropping messages from that peer to enforce that limit.
+/// If messages from one peer come in at a higher rate than every `RECEIVE_RATE_LIMIT` on average,
+/// we start dropping messages from that peer to enforce that limit.
 pub const RECEIVE_RATE_LIMIT: Duration = Duration::from_millis(100);
 
 /// Rate limit on the `sender` side.

polkadot/node/network/dispute-distribution/src/receiver/batches/batch.rs

@@ -192,8 +192,8 @@ impl Batch {
 
 	/// Calculate when the next tick should happen.
 	///
-	/// This will usually return `now + BATCH_COLLECTING_INTERVAL`, except if the lifetime of this batch
-	/// would exceed `MAX_BATCH_LIFETIME`.
+	/// This will usually return `now + BATCH_COLLECTING_INTERVAL`, except if the lifetime of this
+	/// batch would exceed `MAX_BATCH_LIFETIME`.
 	///
 	/// # Arguments
 	///

polkadot/node/network/dispute-distribution/src/receiver/batches/waiting_queue.rs

@@ -50,8 +50,8 @@ impl<Payload: Eq + Ord> WaitingQueue<Payload> {
 
 	/// Push a `PendingWake`.
 	///
-	/// The next call to `wait_ready` will make sure to wake soon enough to process that new event in a
-	/// timely manner.
+	/// The next call to `wait_ready` will make sure to wake soon enough to process that new event
+	/// in a timely manner.
 	pub fn push(&mut self, wake: PendingWake<Payload>) {
 		self.pending_wakes.push(wake);
 		// Reset timer as it is potentially obsolete now:

polkadot/node/network/dispute-distribution/src/receiver/mod.rs

@@ -382,11 +382,11 @@ where
 				if let Err(pending_response) = batch_result {
 					// We don't expect honest peers to send redundant votes within a single batch,
 					// as the timeout for retry is much higher. Still we don't want to punish the
-					// node as it might not be the node's fault. Some other (malicious) node could have been
-					// faster sending the same votes in order to harm the reputation of that honest
-					// node. Given that we already have a rate limit, if a validator chooses to
-					// waste available rate with redundant votes - so be it. The actual dispute
-					// resolution is unaffected.
+					// node as it might not be the node's fault. Some other (malicious) node could
+					// have been faster sending the same votes in order to harm the reputation of
+					// that honest node. Given that we already have a rate limit, if a validator
+					// chooses to waste available rate with redundant votes - so be it. The actual
+					// dispute resolution is unaffected.
 					gum::debug!(
 						target: LOG_TARGET,
 						?peer,

polkadot/node/network/dispute-distribution/src/sender/send_task.rs

@@ -45,8 +45,8 @@ use crate::{
 ///
 /// The unit of work for a `SendTask` is an authority/validator.
 pub struct SendTask<M> {
-	/// The request we are supposed to get out to all `parachain` validators of the dispute's session
-	/// and to all current authorities.
+	/// The request we are supposed to get out to all `parachain` validators of the dispute's
+	/// session and to all current authorities.
 	request: DisputeRequest,
 
 	/// The set of authorities we need to send our messages to. This set will change at session
@@ -185,7 +185,8 @@ impl<M: 'static + Send + Sync> SendTask<M> {
 
 	/// Handle a finished response waiting task.
 	///
-	/// Called by `DisputeSender` upon reception of the corresponding message from our spawned `wait_response_task`.
+	/// Called by `DisputeSender` upon reception of the corresponding message from our spawned
+	/// `wait_response_task`.
 	pub fn on_finished_send(&mut self, authority: &AuthorityDiscoveryId, result: TaskResult) {
 		match result {
 			TaskResult::Failed(err) => {
@@ -204,8 +205,8 @@ impl<M: 'static + Send + Sync> SendTask<M> {
 			TaskResult::Succeeded => {
 				let status = match self.deliveries.get_mut(&authority) {
 					None => {
-						// Can happen when a sending became irrelevant while the response was already
-						// queued.
+						// Can happen when a sending became irrelevant while the response was
+						// already queued.
 						gum::debug!(
 							target: LOG_TARGET,
 							candidate = ?self.request.0.candidate_receipt.hash(),