mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-30 18:57:57 +00:00
Use same fmt and clippy configs as in Substrate (#7611)
* Use same rustfmt.toml as Substrate Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * format format file Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Format with new config Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Add Substrate Clippy config Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Print Clippy version in CI Otherwise its difficult to reproduce locally. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Make fmt happy Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update node/core/pvf/src/error.rs Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> * Update node/core/pvf/src/error.rs Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>
This commit is contained in:
Oliver Tale-Yazdi
committed by
GitHub
GitHub
parent
ac435c96cf
commit
342d720573
@@ -185,8 +185,8 @@ struct VcPerPeerTracker {
|
||||
}
|
||||
|
||||
impl VcPerPeerTracker {
|
||||
/// Note that the remote should now be aware that a validator has seconded a given candidate (by hash)
|
||||
/// based on a message that we have sent it from our local pool.
|
||||
/// Note that the remote should now be aware that a validator has seconded a given candidate (by
|
||||
/// hash) based on a message that we have sent it from our local pool.
|
||||
fn note_local(&mut self, h: CandidateHash) {
|
||||
if !note_hash(&mut self.local_observed, h) {
|
||||
gum::warn!(
|
||||
@@ -198,8 +198,8 @@ impl VcPerPeerTracker {
|
||||
}
|
||||
}
|
||||
|
||||
/// Note that the remote should now be aware that a validator has seconded a given candidate (by hash)
|
||||
/// based on a message that it has sent us.
|
||||
/// Note that the remote should now be aware that a validator has seconded a given candidate (by
|
||||
/// hash) based on a message that it has sent us.
|
||||
///
|
||||
/// Returns `true` if the peer was allowed to send us such a message, `false` otherwise.
|
||||
fn note_remote(&mut self, h: CandidateHash) -> bool {
|
||||
@@ -226,8 +226,8 @@ fn note_hash(
|
||||
/// knowledge that a peer has about goings-on in a relay parent.
|
||||
#[derive(Default)]
|
||||
struct PeerRelayParentKnowledge {
|
||||
/// candidates that the peer is aware of because we sent statements to it. This indicates that we can
|
||||
/// send other statements pertaining to that candidate.
|
||||
/// candidates that the peer is aware of because we sent statements to it. This indicates that
|
||||
/// we can send other statements pertaining to that candidate.
|
||||
sent_candidates: HashSet<CandidateHash>,
|
||||
/// candidates that peer is aware of, because we received statements from it.
|
||||
received_candidates: HashSet<CandidateHash>,
|
||||
@@ -321,13 +321,13 @@ impl PeerRelayParentKnowledge {
|
||||
}
|
||||
}
|
||||
|
||||
/// Attempt to update our view of the peer's knowledge with this statement's fingerprint based on
|
||||
/// a message we are receiving from the peer.
|
||||
/// Attempt to update our view of the peer's knowledge with this statement's fingerprint based
|
||||
/// on a message we are receiving from the peer.
|
||||
///
|
||||
/// Provide the maximum message count that we can receive per candidate. In practice we should
|
||||
/// not receive more statements for any one candidate than there are members in the group assigned
|
||||
/// to that para, but this maximum needs to be lenient to account for equivocations that may be
|
||||
/// cross-group. As such, a maximum of 2 * `n_validators` is recommended.
|
||||
/// not receive more statements for any one candidate than there are members in the group
|
||||
/// assigned to that para, but this maximum needs to be lenient to account for equivocations
|
||||
/// that may be cross-group. As such, a maximum of 2 * `n_validators` is recommended.
|
||||
///
|
||||
/// This returns an error if the peer should not have sent us this message according to protocol
|
||||
/// rules for flood protection.
|
||||
@@ -490,13 +490,13 @@ impl PeerData {
|
||||
self.view_knowledge.get(relay_parent).map_or(false, |k| k.can_send(fingerprint))
|
||||
}
|
||||
|
||||
/// Attempt to update our view of the peer's knowledge with this statement's fingerprint based on
|
||||
/// a message we are receiving from the peer.
|
||||
/// Attempt to update our view of the peer's knowledge with this statement's fingerprint based
|
||||
/// on a message we are receiving from the peer.
|
||||
///
|
||||
/// Provide the maximum message count that we can receive per candidate. In practice we should
|
||||
/// not receive more statements for any one candidate than there are members in the group assigned
|
||||
/// to that para, but this maximum needs to be lenient to account for equivocations that may be
|
||||
/// cross-group. As such, a maximum of 2 * `n_validators` is recommended.
|
||||
/// not receive more statements for any one candidate than there are members in the group
|
||||
/// assigned to that para, but this maximum needs to be lenient to account for equivocations
|
||||
/// that may be cross-group. As such, a maximum of 2 * `n_validators` is recommended.
|
||||
///
|
||||
/// This returns an error if the peer should not have sent us this message according to protocol
|
||||
/// rules for flood protection.
|
||||
@@ -600,8 +600,8 @@ enum NotedStatement<'a> {
|
||||
|
||||
/// Large statement fetching status.
|
||||
enum LargeStatementStatus {
|
||||
/// We are currently fetching the statement data from a remote peer. We keep a list of other nodes
|
||||
/// claiming to have that data and will fallback on them.
|
||||
/// We are currently fetching the statement data from a remote peer. We keep a list of other
|
||||
/// nodes claiming to have that data and will fallback on them.
|
||||
Fetching(FetchingInfo),
|
||||
/// Statement data is fetched or we got it locally via `StatementDistributionMessage::Share`.
|
||||
FetchedOrShared(CommittedCandidateReceipt),
|
||||
@@ -712,8 +712,8 @@ impl ActiveHeadData {
|
||||
/// to have been checked, including that the validator index is not out-of-bounds and
|
||||
/// the signature is valid.
|
||||
///
|
||||
/// Any other statements or those that reference a candidate we are not aware of cannot be accepted
|
||||
/// and will return `NotedStatement::NotUseful`.
|
||||
/// Any other statements or those that reference a candidate we are not aware of cannot be
|
||||
/// accepted and will return `NotedStatement::NotUseful`.
|
||||
fn note_statement(&mut self, statement: SignedFullStatement) -> NotedStatement {
|
||||
let validator_index = statement.validator_index();
|
||||
let comparator = StoredStatementComparator {
|
||||
@@ -1272,9 +1272,9 @@ async fn retrieve_statement_from_message<'a, Context>(
|
||||
}
|
||||
},
|
||||
protocol_v1::StatementDistributionMessage::Statement(_, s) => {
|
||||
// No fetch in progress, safe to return any statement immediately (we don't bother
|
||||
// about normal network jitter which might cause `Valid` statements to arrive early
|
||||
// for now.).
|
||||
// No fetch in progress, safe to return any statement immediately (we don't
|
||||
// bother about normal network jitter which might cause `Valid` statements to
|
||||
// arrive early for now.).
|
||||
return Some(s)
|
||||
},
|
||||
}
|
||||
@@ -1470,7 +1470,8 @@ async fn handle_incoming_message<'a, Context>(
|
||||
);
|
||||
|
||||
match rep {
|
||||
// This happens when a Valid statement has been received but there is no corresponding Seconded
|
||||
// This happens when a Valid statement has been received but there is no corresponding
|
||||
// Seconded
|
||||
COST_UNEXPECTED_STATEMENT_UNKNOWN_CANDIDATE => {
|
||||
metrics.on_unexpected_statement_valid();
|
||||
// Report peer merely if this is not a duplicate out-of-view statement that
|
||||
|
||||
Reference in New Issue
Block a user