Use same fmt and clippy configs as in Substrate (#7611)

* Use same rustfmt.toml as Substrate

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* format format file

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Format with new config

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add Substrate Clippy config

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Print Clippy version in CI

Otherwise its difficult to reproduce locally.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Make fmt happy

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update node/core/pvf/src/error.rs

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>

* Update node/core/pvf/src/error.rs

Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io>

polkadot/node/subsystem-util/src/lib.rs

@@ -20,7 +20,8 @@
 //! or determining what their validator ID is. These common interests are factored into
 //! this module.
 //!
-//! This crate also reexports Prometheus metric types which are expected to be implemented by subsystems.
+//! This crate also reexports Prometheus metric types which are expected to be implemented by
+//! subsystems.
 
 #![warn(missing_docs)]
 
@@ -60,7 +61,8 @@ pub use polkadot_node_network_protocol::MIN_GOSSIP_PEERS;
 
 pub use determine_new_blocks::determine_new_blocks;
 
-/// These reexports are required so that external crates can use the `delegated_subsystem` macro properly.
+/// These reexports are required so that external crates can use the `delegated_subsystem` macro
+/// properly.
 pub mod reexports {
 	pub use polkadot_overseer::gen::{SpawnedSubsystem, Spawner, Subsystem, SubsystemContext};
 }
@@ -367,7 +369,8 @@ pub struct Validator {
 }
 
 impl Validator {
-	/// Get a struct representing this node's validator if this node is in fact a validator in the context of the given block.
+	/// Get a struct representing this node's validator if this node is in fact a validator in the
+	/// context of the given block.
 	pub async fn new<S>(parent: Hash, keystore: KeystorePtr, sender: &mut S) -> Result<Self, Error>
 	where
 		S: SubsystemSender<RuntimeApiMessage>,

polkadot/node/subsystem-util/src/nesting_sender.rs

@@ -33,14 +33,14 @@
 //!
 //! This module helps with this in part. It does not break the multithreaded by default approach,
 //! but it breaks the `spawn everything` approach. So once you `spawn` you will still be
-//! multithreaded by default, despite that for most tasks we spawn (which just wait for network or some
-//! message to arrive), that is very much pointless and needless overhead. You will just spawn less in
-//! the first place.
+//! multithreaded by default, despite that for most tasks we spawn (which just wait for network or
+//! some message to arrive), that is very much pointless and needless overhead. You will just spawn
+//! less in the first place.
 //!
 //! By default your code is single threaded, except when actually needed:
-//!		- need to wait for long running synchronous IO (a threaded runtime is actually useful here)
-//!		- need to wait for some async event (message to arrive)
-//!		- need to do some hefty CPU bound processing (a thread is required here as well)
+//! 		- need to wait for long running synchronous IO (a threaded runtime is actually useful here)
+//! 		- need to wait for some async event (message to arrive)
+//! 		- need to do some hefty CPU bound processing (a thread is required here as well)
 //!
 //! and it is not acceptable to block the main task for waiting for the result, because we actually
 //! really have other things to do or at least need to stay responsive just in case.
@@ -48,7 +48,8 @@
 //! With the types and traits in this module you can achieve exactly that: You write modules which
 //! just execute logic and can call into the functions of other modules - yes we are calling normal
 //! functions. For the case a module you are calling into requires an occasional background task,
-//! you provide it with a `NestingSender<M, ChildModuleMessage>` that it can pass to any spawned tasks.
+//! you provide it with a `NestingSender<M, ChildModuleMessage>` that it can pass to any spawned
+//! tasks.
 //!
 //! This way you don't have to spawn a task for each module just for it to be able to handle
 //! asynchronous events. The module relies on the using/enclosing code/module to forward it any
@@ -65,9 +66,9 @@
 //! Because the wrapping is optional and transparent to the lower modules, each module can also be
 //! used at the top directly without any wrapping, e.g. for standalone use or for testing purposes.
 //!
-//! Checkout the documentation of [`NestingSender`][nesting_sender::NestingSender] below for a basic usage example. For a real
-//! world usage I would like to point you to the dispute-distribution subsystem which makes use of
-//! this architecture.
+//! Checkout the documentation of [`NestingSender`][nesting_sender::NestingSender] below for a basic
+//! usage example. For a real world usage I would like to point you to the dispute-distribution
+//! subsystem which makes use of this architecture.
 //!
 //! ## Limitations
 //!

polkadot/node/subsystem-util/src/reputation.rs

@@ -48,7 +48,8 @@ impl ReputationAggregator {
 	///
 	/// * `send_immediately_if` - A function, takes `UnifiedReputationChange`,
 	/// results shows if we need to send the changes right away.
-	/// By default, it is used for sending `UnifiedReputationChange::Malicious` changes immediately and for testing.
+	/// By default, it is used for sending `UnifiedReputationChange::Malicious` changes immediately
+	/// and for testing.
 	pub fn new(send_immediately_if: fn(UnifiedReputationChange) -> bool) -> Self {
 		Self { by_peer: Default::default(), send_immediately_if }
 	}