f+1 validators always approve (#2699)

* f+1 always approves

* guide

* grumbles

* grumbles

* fix test

* fix tests

* Update roadmap/implementers-guide/src/node/approval/approval-voting.md

Co-authored-by: Sergei Shulepov <sergei@parity.io>

Co-authored-by: Sergei Shulepov <sergei@parity.io>
This commit is contained in:
Robert Habermeier
2021-03-25 13:47:00 +01:00
committed by GitHub
parent e4d0afabce
commit 349879df6b
4 changed files with 178 additions and 115 deletions
@@ -1316,7 +1316,7 @@ fn check_and_apply_full_approval(
required_tranches.clone(),
);
if let approval_checking::Check::Approved(no_shows) = check {
if check.is_approved() {
tracing::trace!(
target: LOG_TARGET,
?candidate_hash,
@@ -1324,6 +1324,8 @@ fn check_and_apply_full_approval(
"Candidate approved under block.",
);
let no_shows = check.known_no_shows();
let was_approved = block_entry.is_fully_approved();
newly_approved.push(*block_hash);