Make sure the commit hash is always of the same length in impl_version (#11404)

* Make sure the commit hash is always of the same length in `impl_version`

* Add a comment regarding the length of the commit hash
This commit is contained in:
Koute
2022-05-16 21:25:15 +09:00
committed by GitHub
parent 83b774fa7f
commit 359849b169
@@ -22,7 +22,10 @@ pub fn generate_cargo_keys() {
let commit = if let Ok(hash) = std::env::var("SUBSTRATE_CLI_GIT_COMMIT_HASH") {
Cow::from(hash.trim().to_owned())
} else {
match Command::new("git").args(&["rev-parse", "--short", "HEAD"]).output() {
// We deliberately set the length here to `11` to ensure that
// the emitted hash is always of the same length; otherwise
// it can (and will!) vary between different build environments.
match Command::new("git").args(&["rev-parse", "--short=11", "HEAD"]).output() {
Ok(o) if o.status.success() => {
let sha = String::from_utf8_lossy(&o.stdout).trim().to_owned();
Cow::from(sha)