diff --git a/polkadot/scripts/github/check_labels.sh b/polkadot/scripts/github/check_labels.sh index 880253cfa1..0d3a7ea79f 100755 --- a/polkadot/scripts/github/check_labels.sh +++ b/polkadot/scripts/github/check_labels.sh @@ -23,10 +23,10 @@ releasenotes_labels=( ) priority_labels=( - 'C1-low' - 'C3-medium' - 'C7-high' - 'C9-critical' + 'C1-low 📌' + 'C3-medium 📣' + 'C7-high ❗️' + 'C9-critical ‼️' ) echo "[+] Checking release notes (B) labels for $CI_COMMIT_BRANCH" diff --git a/polkadot/scripts/github/generate_release_text.rb b/polkadot/scripts/github/generate_release_text.rb index 3b2a885eed..7df6122e3e 100644 --- a/polkadot/scripts/github/generate_release_text.rb +++ b/polkadot/scripts/github/generate_release_text.rb @@ -66,19 +66,27 @@ runtime_changes = Changelog.changes_with_label(all_changes, 'B7-runtimenoteworth # Add the audit status for runtime changes runtime_changes.each do |c| - if c.labels.any? { |l| l[:name] == 'D1-audited👍' } + if c.labels.any? { |l| l[:name] == 'D1-audited 👍' } c[:pretty_title] = "✅ `audited` #{c[:pretty_title]}" next end - if c.labels.any? { |l| l[:name] == 'D9-needsaudit👮' } - c[:pretty_title] = "❌ `AWAITING AUDIT` #{c[:pretty_title]}" + if c.labels.any? { |l| l[:name] == 'D2-notlive 💤' } + c[:pretty_title] = "✅ `not live` #{c[:pretty_title]}" next end - if c.labels.any? { |l| l[:name] == 'D5-nicetohaveaudit⚠️' } + if c.labels.any? { |l| l[:name] == 'D3-trivial 🧸' } + c[:pretty_title] = "✅ `trivial` #{c[:pretty_title]}" + next + end + if c.labels.any? { |l| l[:name] == 'D5-nicetohaveaudit ⚠️' } c[:pretty_title] = "⏳ `pending non-critical audit` #{c[:pretty_title]}" next end - c[:pretty_title] = "✅ `trivial` #{c[:pretty_title]}" + if c.labels.any? { |l| l[:name] == 'D9-needsaudit 👮' } + c[:pretty_title] = "❌ `AWAITING AUDIT` #{c[:pretty_title]}" + next + end + c[:pretty_title] = "⭕️ `unknown audit requirements` #{c[:pretty_title]}" end # The priority of users upgraded is determined by the highest-priority diff --git a/polkadot/scripts/gitlab/check_runtime.sh b/polkadot/scripts/gitlab/check_runtime.sh index 520b7c1c02..89b91a4cb2 100755 --- a/polkadot/scripts/gitlab/check_runtime.sh +++ b/polkadot/scripts/gitlab/check_runtime.sh @@ -4,14 +4,11 @@ # well as directories common to all runtimes (e.g., ^runtime/common). If there # are no changes, check if the Substrate git SHA in Cargo.lock has been # changed. If so, pull the repo and verify if {spec,impl}_versions have been -# altered since the previous Substrate version used. Also, if any of the -# Substrate changes between the previous and current version referenced by -# Cargo.lock were labelled with 'D2-breaksapi', label this PR the same. +# altered since the previous Substrate version used. # # If there were changes to any runtimes or common dirs, we iterate over each # runtime (defined in the $runtimes() array), and check if {spec,impl}_version -# have been changed since the last release. Also, if there have been changes to -# the runtime since the last commit to master, label the PR with 'D2-breaksapi' +# have been changed since the last release. set -e # fail on any error @@ -115,21 +112,6 @@ spec_version or or impl_version have changed in substrate after updating Cargo.l please make sure versions are bumped in polkadot accordingly EOT - # Now check if any of the substrate changes have been tagged D2-breaksapi - ( - cd "${SUBSTRATE_CLONE_DIR}" - substrate_changes="$(sanitised_git_logs "${SUBSTRATE_PREV_REF}" "${SUBSTRATE_NEW_REF}")" - echo "$substrate_changes" | while read -r line; do - pr_id=$(echo "$line" | sed -E 's/.*#([0-9]+)\)$/\1/') - - if has_label 'paritytech/substrate' "$pr_id" 'D2-breaksapi'; then - boldprint "Substrate change labelled with D2-breaksapi. Labelling..." - github_label "D2-breaksapi" - exit 1 - fi - done - ) - fi failed_runtime_checks=() @@ -164,13 +146,6 @@ do if [ "${add_spec_version}" != "${sub_spec_version}" ] then - if git diff --name-only "origin/master...${CI_COMMIT_SHA}" \ - | grep -E -q -e "$regex" - then - # add label breaksapi only if this pr altered the runtime sources - github_label "D2-breaksapi" - fi - boldcat <