mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-25 18:47:56 +00:00
[prdoc] Validate crate names (#3467)
Changes: - Add CI script to check that the `crate` names that are mentioned in prdocs are valid. We can extend it lateron to also validate the correct SemVer bumps as introduced in https://github.com/paritytech/polkadot-sdk/pull/3441. Example output: ```pre $ python3 .github/scripts/check-prdoc.py Cargo.toml prdoc/*.prdoc 🔎 Reading workspace polkadot-sdk/Cargo.toml. 📦 Checking 36 prdocs against 494 crates. ✅ All prdocs are valid. ``` Note that not all old prdocs pass the check since crates have been renamed: ```pre $ python3 .github/scripts/check-prdoc.py Cargo.toml prdoc/**/*.prdoc 🔎 Reading workspace polkadot-sdk/Cargo.toml. 📦 Checking 186 prdocs against 494 crates. ❌ Some prdocs are invalid. 💥 prdoc/1.4.0/pr_1926.prdoc lists invalid crate: node-cli 💥 prdoc/1.4.0/pr_2086.prdoc lists invalid crate: xcm-executor 💥 prdoc/1.4.0/pr_2107.prdoc lists invalid crate: xcm 💥 prdoc/1.6.0/pr_2684.prdoc lists invalid crate: xcm-builder ``` --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
This commit is contained in:
committed by
GitHub
parent
d05f8c57fb
commit
4080632ee0
@@ -0,0 +1,71 @@
|
||||
#!/usr/bin/env python3
|
||||
|
||||
'''
|
||||
Ensure that the prdoc files are valid.
|
||||
|
||||
# Example
|
||||
|
||||
```sh
|
||||
python3 -m pip install cargo-workspace
|
||||
python3 .github/scripts/check-prdoc.py Cargo.toml prdoc/*.prdoc
|
||||
```
|
||||
|
||||
Produces example output:
|
||||
```pre
|
||||
🔎 Reading workspace polkadot-sdk/Cargo.toml
|
||||
📦 Checking 32 prdocs against 493 crates.
|
||||
✅ All prdocs are valid
|
||||
```
|
||||
'''
|
||||
|
||||
import os
|
||||
import yaml
|
||||
import argparse
|
||||
import cargo_workspace
|
||||
|
||||
def check_prdoc_crate_names(root, paths):
|
||||
'''
|
||||
Check that all crates of the `crates` section of each prdoc is present in the workspace.
|
||||
'''
|
||||
|
||||
print(f'🔎 Reading workspace {root}.')
|
||||
workspace = cargo_workspace.Workspace.from_path(root)
|
||||
crate_names = [crate.name for crate in workspace.crates]
|
||||
|
||||
print(f'📦 Checking {len(paths)} prdocs against {len(crate_names)} crates.')
|
||||
faulty = {}
|
||||
|
||||
for path in paths:
|
||||
with open(path, 'r') as f:
|
||||
prdoc = yaml.safe_load(f)
|
||||
|
||||
for crate in prdoc.get('crates', []):
|
||||
crate = crate['name']
|
||||
if crate in crate_names:
|
||||
continue
|
||||
|
||||
faulty.setdefault(path, []).append(crate)
|
||||
|
||||
if len(faulty) == 0:
|
||||
print('✅ All prdocs are valid.')
|
||||
else:
|
||||
print('❌ Some prdocs are invalid.')
|
||||
for path, crates in faulty.items():
|
||||
print(f'💥 {path} lists invalid crate: {", ".join(crates)}')
|
||||
exit(1)
|
||||
|
||||
def parse_args():
|
||||
parser = argparse.ArgumentParser(description='Check prdoc files')
|
||||
parser.add_argument('root', help='The cargo workspace manifest', metavar='root', type=str, nargs=1)
|
||||
parser.add_argument('prdoc', help='The prdoc files', metavar='prdoc', type=str, nargs='*')
|
||||
args = parser.parse_args()
|
||||
|
||||
if len(args.prdoc) == 0:
|
||||
print('❌ Need at least one prdoc file as argument.')
|
||||
exit(1)
|
||||
|
||||
return { 'root': os.path.abspath(args.root[0]), 'prdocs': args.prdoc }
|
||||
|
||||
if __name__ == '__main__':
|
||||
args = parse_args()
|
||||
check_prdoc_crate_names(args['root'], args['prdocs'])
|
||||
@@ -57,3 +57,11 @@ jobs:
|
||||
echo "Checking for PR#${GITHUB_PR}"
|
||||
echo "You can find more information about PRDoc at $PRDOC_DOC"
|
||||
$ENGINE run --rm -v $PWD:/repo -e RUST_LOG=info $IMAGE check -n ${GITHUB_PR}
|
||||
|
||||
- name: Validate prdoc for PR#${{ github.event.pull_request.number }}
|
||||
if: ${{ !contains(steps.get-labels.outputs.labels, 'R0') }}
|
||||
run: |
|
||||
echo "Validating PR#${GITHUB_PR}"
|
||||
python3 --version
|
||||
python3 -m pip install cargo-workspace==1.2.1
|
||||
python3 .github/scripts/check-prdoc.py Cargo.toml prdoc/pr_${GITHUB_PR}.prdoc
|
||||
|
||||
Reference in New Issue
Block a user