Fix 1.89 clippy warnings (#2055)

* Fix 1.89 clippy warnings

* WASM lightclient clippy fixes too

core/src/blocks/extrinsics.rs

@@ -279,7 +279,7 @@ where
     }
 
     /// Fetch the metadata for this extrinsic.
-    pub fn extrinsic_metadata(&self) -> Result<ExtrinsicMetadataDetails, Error> {
+    pub fn extrinsic_metadata(&self) -> Result<ExtrinsicMetadataDetails<'_>, Error> {
         let pallet = self.metadata.pallet_by_index_err(self.pallet_index())?;
         let variant = pallet
             .call_variant_by_index(self.variant_index())

core/src/events.rs

@@ -339,7 +339,7 @@ impl<T: Config> EventDetails<T> {
     }
 
     /// Fetch details from the metadata for this event.
-    pub fn event_metadata(&self) -> EventMetadataDetails {
+    pub fn event_metadata(&self) -> EventMetadataDetails<'_> {
         let pallet = self
             .metadata
             .pallet_by_index(self.pallet_index())

core/src/metadata/metadata_type.rs

@@ -25,7 +25,7 @@ impl Metadata {
     pub fn pallet_by_name_err(
         &self,
         name: &str,
-    ) -> Result<subxt_metadata::PalletMetadata, MetadataError> {
+    ) -> Result<subxt_metadata::PalletMetadata<'_>, MetadataError> {
         self.pallet_by_name(name)
             .ok_or_else(|| MetadataError::PalletNameNotFound(name.to_owned()))
     }
@@ -34,7 +34,7 @@ impl Metadata {
     pub fn pallet_by_index_err(
         &self,
         index: u8,
-    ) -> Result<subxt_metadata::PalletMetadata, MetadataError> {
+    ) -> Result<subxt_metadata::PalletMetadata<'_>, MetadataError> {
         self.pallet_by_index(index)
             .ok_or(MetadataError::PalletIndexNotFound(index))
     }
@@ -43,7 +43,7 @@ impl Metadata {
     pub fn runtime_api_trait_by_name_err(
         &self,
         name: &str,
-    ) -> Result<subxt_metadata::RuntimeApiMetadata, MetadataError> {
+    ) -> Result<subxt_metadata::RuntimeApiMetadata<'_>, MetadataError> {
         self.runtime_api_trait_by_name(name)
             .ok_or_else(|| MetadataError::RuntimeTraitNotFound(name.to_owned()))
     }
@@ -52,7 +52,7 @@ impl Metadata {
     pub fn custom_value_by_name_err(
         &self,
         name: &str,
-    ) -> Result<subxt_metadata::CustomValueMetadata, MetadataError> {
+    ) -> Result<subxt_metadata::CustomValueMetadata<'_>, MetadataError> {
         self.custom()
             .get(name)
             .ok_or_else(|| MetadataError::CustomValueNameNotFound(name.to_owned()))