Allow changing the behavior for imported blocks (#5236)

* Added option to disable default block announce

* Added on_block_imported on NetworkService

* Revert "Added on_block_imported on NetworkService"

This reverts commit ba360cad96e0cb041d7047af30df2a35eb112449.

* Do not announce block if set to not announce block

* Revert fix

* Moving default announce block to NetworkConfig

* WIP

Forked at: ad90ab7ec9
Parent branch: origin/master

* WIP

Forked at: ad90ab7ec9
Parent branch: origin/master

* Removing boolean in favor of explicit call

* Fixing tests

* WIP

Forked at: ad90ab7ec9
Parent branch: origin/master

* WIP

Forked at: ad90ab7ec9
Parent branch: origin/master

* increase spec_version

* increase spec_version

* Fixed test

* Fixing test

* Renamed should_announce_imported_blocks to announce_imported_blocks

* Updated assert_cmd
This commit is contained in:
Cecile Tonglet
2020-03-31 11:02:16 +02:00
committed by GitHub
parent b8eb094c7f
commit 439887a773
9 changed files with 31 additions and 19 deletions
+2 -11
View File
@@ -1467,20 +1467,11 @@ impl<B: BlockT, H: ExHashT> Protocol<B, H> {
}
}
/// Call this when a block has been imported in the import queue and we should announce it on
/// the network.
pub fn on_block_imported(&mut self, header: &B::Header, data: Vec<u8>, is_best: bool) {
/// Call this when a block has been imported in the import queue
pub fn on_block_imported(&mut self, header: &B::Header, is_best: bool) {
if is_best {
self.sync.update_chain_info(header);
}
// blocks are not announced by light clients
if self.config.roles.is_light() {
return;
}
// send out block announcements
self.send_announcement(header, data, is_best, false);
}
/// Call this when a block has been finalized. The sync layer may have some additional