From 4719cb22921d24ebac5327f2dd95563bb475ad01 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomasz=20Drwi=C4=99ga?= <tomusdrw@users.noreply.github.com>
Date: Tue, 2 Feb 2021 23:27:57 +0100
Subject: [PATCH] Add finality verifier test with different validator set id.
 (#698)

* Add test for invalid set id.

* cargo fmt --all

* Update modules/finality-verifier/src/lib.rs

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
---
 bridges/modules/finality-verifier/src/lib.rs | 21 ++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/bridges/modules/finality-verifier/src/lib.rs b/bridges/modules/finality-verifier/src/lib.rs
index 924a1c0054..bfb5394705 100644
--- a/bridges/modules/finality-verifier/src/lib.rs
+++ b/bridges/modules/finality-verifier/src/lib.rs
@@ -203,6 +203,27 @@ mod tests {
 		})
 	}
 
+	#[test]
+	fn rejects_justification_that_skips_authority_set_transition() {
+		run_test(|| {
+			initialize_substrate_bridge();
+
+			let child = test_header(1);
+			let header = test_header(2);
+
+			let set_id = 2;
+			let grandpa_round = 1;
+			let justification =
+				make_justification_for_header(&header, grandpa_round, set_id, &authority_list()).encode();
+			let ancestry_proof = vec![child, header.clone()];
+
+			assert_err!(
+				Module::<TestRuntime>::submit_finality_proof(Origin::signed(1), header, justification, ancestry_proof,),
+				<Error<TestRuntime>>::InvalidJustification
+			);
+		})
+	}
+
 	#[test]
 	fn does_not_import_header_with_invalid_finality_proof() {
 		run_test(|| {