Add ci check for parity-publish and fix current check issues (#1887)

Co-authored-by: Sergejs Kostjucenko <85877331+sergejparity@users.noreply.github.com>
Co-authored-by: Bastian Köcher <info@kchr.de>

substrate/bin/node/cli/Cargo.toml

@@ -1,5 +1,5 @@
 [package]
-name = "node-cli"
+name = "staging-node-cli"
 version = "3.0.0-dev"
 authors.workspace = true
 description = "Generic Substrate node implementation in Rust."
@@ -101,12 +101,12 @@ pallet-im-online = { path = "../../../frame/im-online", default-features = false
 kitchensink-runtime = { path = "../runtime" }
 node-rpc = { path = "../rpc" }
 node-primitives = { path = "../primitives" }
-node-executor = { path = "../executor" }
+node-executor = { package = "staging-node-executor", path = "../executor" }
 
 # CLI-specific dependencies
 sc-cli = { path = "../../../client/cli", optional = true}
 frame-benchmarking-cli = { path = "../../../utils/frame/benchmarking-cli", optional = true}
-node-inspect = { path = "../inspect", optional = true}
+node-inspect = { package = "staging-node-inspect", path = "../inspect", optional = true}
 try-runtime-cli = { path = "../../../utils/frame/try-runtime/cli", optional = true}
 serde_json = "1.0.107"
 
@@ -139,7 +139,7 @@ substrate-cli-test-utils = { path = "../../../test-utils/cli" }
 [build-dependencies]
 clap = { version = "4.4.6", optional = true }
 clap_complete = { version = "4.0.2", optional = true }
-node-inspect = { path = "../inspect", optional = true}
+node-inspect = { package = "staging-node-inspect", path = "../inspect", optional = true}
 frame-benchmarking-cli = { path = "../../../utils/frame/benchmarking-cli", optional = true}
 substrate-build-script-utils = { path = "../../../utils/build-script-utils", optional = true}
 substrate-frame-cli = { path = "../../../utils/frame/frame-utilities-cli", optional = true}

substrate/bin/node/cli/benches/block_production.rs

@@ -39,6 +39,7 @@ use sp_runtime::{
 	transaction_validity::{InvalidTransaction, TransactionValidityError},
 	AccountId32, MultiAddress, OpaqueExtrinsic,
 };
+use staging_node_cli as node_cli;
 use tokio::runtime::Handle;
 
 fn new_node(tokio_handle: Handle) -> node_cli::service::NewFullBase {

substrate/bin/node/cli/benches/transaction_pool.rs

@@ -35,6 +35,7 @@ use sc_transaction_pool_api::{TransactionPool as _, TransactionSource, Transacti
 use sp_core::{crypto::Pair, sr25519};
 use sp_keyring::Sr25519Keyring;
 use sp_runtime::OpaqueExtrinsic;
+use staging_node_cli as node_cli;
 use tokio::runtime::Handle;
 
 fn new_node(tokio_handle: Handle) -> node_cli::service::NewFullBase {

substrate/bin/node/cli/bin/main.rs

@@ -20,6 +20,8 @@
 
 #![warn(missing_docs)]
 
+use staging_node_cli as node_cli;
+
 fn main() -> sc_cli::Result<()> {
 	node_cli::run()
 }

substrate/bin/node/executor/Cargo.toml

@@ -1,5 +1,5 @@
 [package]
-name = "node-executor"
+name = "staging-node-executor"
 version = "3.0.0-dev"
 authors.workspace = true
 description = "Substrate node implementation in Rust."

substrate/bin/node/executor/benches/bench.rs

@@ -35,6 +35,7 @@ use sp_core::{
 };
 use sp_runtime::traits::BlakeTwo256;
 use sp_state_machine::TestExternalities as CoreTestExternalities;
+use staging_node_executor as node_executor;
 
 criterion_group!(benches, bench_execute_block);
 criterion_main!(benches);

substrate/bin/node/executor/tests/common.rs

@@ -42,6 +42,7 @@ use node_executor::ExecutorDispatch;
 use node_primitives::{BlockNumber, Hash};
 use node_testing::keyring::*;
 use sp_externalities::Externalities;
+use staging_node_executor as node_executor;
 
 pub const TEST_KEY_TYPE_ID: KeyTypeId = KeyTypeId(*b"test");
 

substrate/bin/node/inspect/Cargo.toml

@@ -1,5 +1,5 @@
 [package]
-name = "node-inspect"
+name = "staging-node-inspect"
 version = "0.9.0-dev"
 authors.workspace = true
 description = "Substrate node block inspection tool."
@@ -7,7 +7,6 @@ edition.workspace = true
 license = "GPL-3.0-or-later WITH Classpath-exception-2.0"
 homepage = "https://substrate.io"
 repository.workspace = true
-publish = false
 
 [package.metadata.docs.rs]
 targets = ["x86_64-unknown-linux-gnu"]

substrate/bin/node/testing/Cargo.toml

@@ -19,7 +19,7 @@ futures = "0.3.21"
 log = "0.4.17"
 tempfile = "3.1.0"
 frame-system = { path = "../../../frame/system" }
-node-executor = { path = "../executor" }
+node-executor = { package = "staging-node-executor", path = "../executor" }
 node-primitives = { path = "../primitives" }
 kitchensink-runtime = { path = "../runtime" }
 pallet-asset-conversion = { path = "../../../frame/asset-conversion" }