Remove pov hash comparison when waiting on a block to announce (#396)

* Remove pov hash comparison when waiting on a block to announce

Internally we get notified on the channel for our candidate anyway.
Besides that polkadot will compress the pov which leads to a different
pov hash and thus, would lead to a failing check on the `pov_hash`.

* Fix

* Fix tests
This commit is contained in:
Bastian Köcher
2021-04-12 19:26:55 +02:00
committed by GitHub
parent 959f5852ed
commit 498595a5b7
3 changed files with 14 additions and 24 deletions
+4 -4
View File
@@ -219,7 +219,7 @@ fn check_signer_is_legit_validator() {
let (mut validator, api) = make_validator_and_api();
let (signed_statement, header) = block_on(make_gossip_message_and_header_using_genesis(api, 1));
let data = BlockAnnounceData::try_from(signed_statement)
let data = BlockAnnounceData::try_from(&signed_statement)
.unwrap()
.encode();
@@ -233,7 +233,7 @@ fn check_statement_is_correctly_signed() {
let (signed_statement, header) = block_on(make_gossip_message_and_header_using_genesis(api, 0));
let mut data = BlockAnnounceData::try_from(signed_statement)
let mut data = BlockAnnounceData::try_from(&signed_statement)
.unwrap()
.encode();
@@ -296,7 +296,7 @@ fn check_header_match_candidate_receipt_header() {
let (signed_statement, mut header) =
block_on(make_gossip_message_and_header_using_genesis(api, 0));
let data = BlockAnnounceData::try_from(signed_statement)
let data = BlockAnnounceData::try_from(&signed_statement)
.unwrap()
.encode();
header.number = 300;
@@ -323,7 +323,7 @@ fn relay_parent_not_imported_when_block_announce_is_processed() {
let (signed_statement, header) = make_gossip_message_and_header(api, block.hash(), 0).await;
let data = BlockAnnounceData::try_from(signed_statement)
let data = BlockAnnounceData::try_from(&signed_statement)
.unwrap()
.encode();