feat/jaeger: more spans, more stages (#2477)

* feat/jaeger: more spans, more stages

Stage numbers are still arbitrarily picked.

* feat/jaeger: additional spans

* chore/spellcheck: improve the dictionary

* fix/jaeger JaegerSpan -> jaeger::Span
This commit is contained in:
Bernhard Schuster
2021-02-19 15:19:43 +01:00
committed by GitHub
parent a5defa7c7f
commit 49c6aa9a76
22 changed files with 249 additions and 143 deletions
@@ -28,6 +28,7 @@ use polkadot_primitives::v1::{
use polkadot_subsystem::{
ActiveLeavesUpdate, OverseerSignal, SubsystemContext, SubsystemResult, SubsystemError, Subsystem,
FromOverseer, SpawnedSubsystem,
jaeger,
messages::{
PoVDistributionMessage, AllMessages, NetworkBridgeMessage, NetworkBridgeEvent,
},
@@ -154,7 +155,11 @@ async fn handle_signal(
OverseerSignal::ActiveLeaves(ActiveLeavesUpdate { activated, deactivated }) => {
let _timer = state.metrics.time_handle_signal();
for (relay_parent, _span) in activated {
for (relay_parent, span) in activated {
let _span = span.child_builder("pov-dist")
.with_stage(jaeger::Stage::PoVDistribution)
.build();
match request_validators_ctx(relay_parent, ctx).await {
Ok(vals_rx) => {
let n_validators = match vals_rx.await? {
@@ -28,7 +28,7 @@ use polkadot_primitives::v1::{
AuthorityDiscoveryId, BlockData, CoreState, GroupRotationInfo, Id as ParaId,
ScheduledCore, ValidatorIndex, SessionIndex, SessionInfo,
};
use polkadot_subsystem::{messages::{RuntimeApiMessage, RuntimeApiRequest}, JaegerSpan};
use polkadot_subsystem::{messages::{RuntimeApiMessage, RuntimeApiRequest}, jaeger};
use polkadot_node_subsystem_test_helpers as test_helpers;
use polkadot_node_subsystem_util::TimeoutExt;
use polkadot_node_network_protocol::{view, our_view};
@@ -277,7 +277,7 @@ fn ask_validators_for_povs() {
overseer_signal(
&mut virtual_overseer,
OverseerSignal::ActiveLeaves(ActiveLeavesUpdate {
activated: [(test_state.relay_parent, Arc::new(JaegerSpan::Disabled))][..].into(),
activated: [(test_state.relay_parent, Arc::new(jaeger::Span::Disabled))][..].into(),
deactivated: [][..].into(),
}),
).await;
@@ -449,7 +449,7 @@ fn ask_validators_for_povs() {
overseer_signal(
&mut virtual_overseer,
OverseerSignal::ActiveLeaves(ActiveLeavesUpdate {
activated: [(next_leaf, Arc::new(JaegerSpan::Disabled))][..].into(),
activated: [(next_leaf, Arc::new(jaeger::Span::Disabled))][..].into(),
deactivated: [current.clone()][..].into(),
})
).await;