pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-04-26 14:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

bench: Use _ instead of :: in auto-generated file names (#12332)

Browse Source 
* Replace :: with _ in auto-generated file names

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* fmt

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
This commit is contained in:
Oliver Tale-Yazdi
2022-09-23 12:42:36 +02:00
committed by GitHub
parent b56c0e4cb6
commit 4bab1c72d9
3 changed files with 27 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/utils/frame/benchmarking-cli/src/pallet/writer.rs
+18 -6
View File
@@ -24,6 +24,7 @@ use std::{
};
use inflector::Inflector;
use itertools::Itertools;
use serde::Serialize;
use crate::{pallet::command::ComponentRange, shared::UnderscoreHelper, PalletCmd};
@@ -314,18 +315,21 @@ pub(crate) fn write_results(
// Organize results by pallet into a JSON map
let all_results = map_results(batches, storage_info, component_ranges, &analysis_choice)?;
let mut created_files = Vec::new();
for ((pallet, instance), results) in all_results.iter() {
let mut file_path = path.clone();
// If a user only specified a directory...
if file_path.is_dir() {
// Start with "path/to/pallet_name".
let mut file_name = pallet.clone();
// Check if there might be multiple instances benchmarked.
if all_results.keys().any(|(p, i)| p == pallet && i != instance) {
// Create new file: "path/to/pallet_name_instance_name.rs".
file_path.push(pallet.clone() + "_" + instance.to_snake_case().as_str());
} else {
// Create new file: "path/to/pallet_name.rs".
file_path.push(pallet.clone());
// Append "_instance_name".
file_name = format!("{}_{}", file_name, instance.to_snake_case());
}
// "mod::pallet_name.rs" becomes "mod_pallet_name.rs".
file_path.push(file_name.replace("::", "_"));
file_path.set_extension("rs");
}
@@ -342,10 +346,18 @@ pub(crate) fn write_results(
benchmarks: results.clone(),
};
let mut output_file = fs::File::create(file_path)?;
let mut output_file = fs::File::create(&file_path)?;
handlebars
.render_template_to_write(&template, &hbs_data, &mut output_file)
.map_err(|e| io_error(&e.to_string()))?;
println!("Created file: {:?}", &file_path);
created_files.push(file_path);
}
for file in created_files.iter().duplicates() {
// This can happen when there are multiple instances of a pallet deployed
// and `--output` forces the output of all instances into the same file.
println!("Multiple benchmarks were written to the same file: {:?}.", file);
}
Ok(())
}