pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-14 18:01:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor candidate validation messages (#2219)

Browse Source
This commit is contained in:
s0me0ne-unkn0wn
2023-11-08 15:21:58 +01:00
committed by GitHub
parent 1bc0885829
commit 50390950d8
14 changed files with 384 additions and 354 deletions
Download Patch File Download Diff File Expand all files Collapse all files
polkadot/node/malus/src/variants/common.rs
+43 -41
View File
@@ -273,30 +273,31 @@ where
// Message sent by the approval voting subsystem
FromOrchestra::Communication {
msg:
CandidateValidationMessage::ValidateFromExhaustive(
CandidateValidationMessage::ValidateFromExhaustive {
validation_data,
validation_code,
candidate_receipt,
pov,
executor_params,
timeout,
sender,
),
exec_timeout_kind,
response_sender,
..
},
} => {
match self.fake_validation {
x if x.misbehaves_valid() && x.should_misbehave(timeout) => {
x if x.misbehaves_valid() && x.should_misbehave(exec_timeout_kind) => {
// Behave normally if the `PoV` is not known to be malicious.
if pov.block_data.0.as_slice() != MALICIOUS_POV {
return Some(FromOrchestra::Communication {
msg: CandidateValidationMessage::ValidateFromExhaustive(
msg: CandidateValidationMessage::ValidateFromExhaustive {
validation_data,
validation_code,
candidate_receipt,
pov,
executor_params,
timeout,
sender,
),
exec_timeout_kind,
response_sender,
},
})
}
// Create the fake response with probability `p` if the `PoV` is malicious,
@@ -313,7 +314,7 @@ where
create_validation_response(
validation_data,
candidate_receipt.descriptor,
sender,
response_sender,
);
None
},
@@ -326,20 +327,20 @@ where
);
Some(FromOrchestra::Communication {
msg: CandidateValidationMessage::ValidateFromExhaustive(
msg: CandidateValidationMessage::ValidateFromExhaustive {
validation_data,
validation_code,
candidate_receipt,
pov,
executor_params,
timeout,
sender,
),
exec_timeout_kind,
response_sender,
},
})
},
}
},
x if x.misbehaves_invalid() && x.should_misbehave(timeout) => {
x if x.misbehaves_invalid() && x.should_misbehave(exec_timeout_kind) => {
// Set the validation result to invalid with probability `p` and trigger a
// dispute
let behave_maliciously = self.distribution.sample(&mut rand::thread_rng());
@@ -358,7 +359,7 @@ where
// We're not even checking the candidate, this makes us appear
// faster than honest validators.
sender.send(Ok(validation_result)).unwrap();
response_sender.send(Ok(validation_result)).unwrap();
None
},
false => {
@@ -366,56 +367,57 @@ where
gum::info!(target: MALUS, "😈 'Decided' to not act maliciously.",);
Some(FromOrchestra::Communication {
msg: CandidateValidationMessage::ValidateFromExhaustive(
msg: CandidateValidationMessage::ValidateFromExhaustive {
validation_data,
validation_code,
candidate_receipt,
pov,
executor_params,
timeout,
sender,
),
exec_timeout_kind,
response_sender,
},
})
},
}
},
// Handle FakeCandidateValidation::Disabled
_ => Some(FromOrchestra::Communication {
msg: CandidateValidationMessage::ValidateFromExhaustive(
msg: CandidateValidationMessage::ValidateFromExhaustive {
validation_data,
validation_code,
candidate_receipt,
pov,
executor_params,
timeout,
sender,
),
exec_timeout_kind,
response_sender,
},
}),
}
},
// Behaviour related to the backing subsystem
FromOrchestra::Communication {
msg:
CandidateValidationMessage::ValidateFromChainState(
CandidateValidationMessage::ValidateFromChainState {
candidate_receipt,
pov,
executor_params,
timeout,
exec_timeout_kind,
response_sender,
),
..
},
} => {
match self.fake_validation {
x if x.misbehaves_valid() && x.should_misbehave(timeout) => {
x if x.misbehaves_valid() && x.should_misbehave(exec_timeout_kind) => {
// Behave normally if the `PoV` is not known to be malicious.
if pov.block_data.0.as_slice() != MALICIOUS_POV {
return Some(FromOrchestra::Communication {
msg: CandidateValidationMessage::ValidateFromChainState(
msg: CandidateValidationMessage::ValidateFromChainState {
candidate_receipt,
pov,
executor_params,
timeout,
exec_timeout_kind,
response_sender,
),
},
})
}
// If the `PoV` is malicious, back the candidate with some probability `p`,
@@ -439,17 +441,17 @@ where
// If the `PoV` is malicious, we behave normally with some probability
// `(1-p)`
false => Some(FromOrchestra::Communication {
msg: CandidateValidationMessage::ValidateFromChainState(
msg: CandidateValidationMessage::ValidateFromChainState {
candidate_receipt,
pov,
executor_params,
timeout,
exec_timeout_kind,
response_sender,
),
},
}),
}
},
x if x.misbehaves_invalid() && x.should_misbehave(timeout) => {
x if x.misbehaves_invalid() && x.should_misbehave(exec_timeout_kind) => {
// Maliciously set the validation result to invalid for a valid candidate
// with probability `p`
let behave_maliciously = self.distribution.sample(&mut rand::thread_rng());
@@ -473,25 +475,25 @@ where
gum::info!(target: MALUS, "😈 'Decided' to not act maliciously.",);
Some(FromOrchestra::Communication {
msg: CandidateValidationMessage::ValidateFromChainState(
msg: CandidateValidationMessage::ValidateFromChainState {
candidate_receipt,
pov,
executor_params,
timeout,
exec_timeout_kind,
response_sender,
),
},
})
},
}
},
_ => Some(FromOrchestra::Communication {
msg: CandidateValidationMessage::ValidateFromChainState(
msg: CandidateValidationMessage::ValidateFromChainState {
candidate_receipt,
pov,
executor_params,
timeout,
exec_timeout_kind,
response_sender,
),
},
}),
}
},