From 515a56af4a1e36f1e978065b7b186830aa3bbe40 Mon Sep 17 00:00:00 2001 From: Max Inden Date: Tue, 16 Jul 2019 01:49:27 +0200 Subject: [PATCH] core/network: Remove self mutability on put and get value (#3118) Make `NetworkService.{get,put}_value` only take a self reference instead of a mutable self reference. When retrieving `NetworkService` via `NetworkWorker`, one only gets an immutable reference. --- substrate/core/network/src/service.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/substrate/core/network/src/service.rs b/substrate/core/network/src/service.rs index fbafa29d04..5841336b44 100644 --- a/substrate/core/network/src/service.rs +++ b/substrate/core/network/src/service.rs @@ -442,7 +442,7 @@ impl, H: ExHashT> NetworkServic /// /// This will generate either a `ValueFound` or a `ValueNotFound` event and pass it to /// `on_event` on the network specialization. - pub fn get_value(&mut self, key: &Multihash) { + pub fn get_value(&self, key: &Multihash) { let _ = self .to_worker .unbounded_send(ServerToWorkerMsg::GetValue(key.clone())); @@ -452,7 +452,7 @@ impl, H: ExHashT> NetworkServic /// /// This will generate either a `ValuePut` or a `ValuePutFailed` event and pass it to /// `on_event` on the network specialization. - pub fn put_value(&mut self, key: Multihash, value: Vec) { + pub fn put_value(&self, key: Multihash, value: Vec) { let _ = self .to_worker .unbounded_send(ServerToWorkerMsg::PutValue(key, value)); @@ -643,7 +643,7 @@ struct NetworkLink<'a, B: BlockT, S: NetworkSpecialization, H: ExHashT> { impl<'a, B: BlockT, S: NetworkSpecialization, H: ExHashT> Link for NetworkLink<'a, B, S, H> { fn blocks_processed( - &mut self, + &mut self, imported: usize, count: usize, results: Vec<(Result>, BlockImportError>, B::Hash)>