pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-07-16 04:55:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

BlockId removal: refactor: HeaderBackend::header (#12874)

Browse Source 
* BlockId removal: refactor: HeaderBackend::header

It changes the arguments of:
- `HeaderBackend::header`,
- `Client::header`,
- `PeersClient::header`
- `ChainApi::block_header`

methods from: `BlockId<Block>` to: `Block::Hash`

This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)

* non-trivial usages of haeder(block_id) refactored

This may required introduction of dedicated function:
header_for_block_num

* fmt

* fix

* doc fixed

* ".git/.scripts/fmt.sh"

* BlockId removal: refactor: HeaderBackend::expect_header

It changes the arguments of `HeaderBackend::expect_header` method from: `BlockId<Block>` to: `Block::Hash`

* ".git/.scripts/fmt.sh"

* readme updated

* ".git/.scripts/fmt.sh"

* fix

Co-authored-by: parity-processbot <>
This commit is contained in:
Michal Kucharczyk
2022-12-20 10:43:31 +01:00
committed by GitHub
parent 74da30c8a2
commit 548955a73f
55 changed files with 307 additions and 360 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/client/finality-grandpa/src/tests.rs
+8 -5
View File
@@ -1530,10 +1530,13 @@ async fn justification_with_equivocation() {
// we create a basic chain with 3 blocks (no forks)
net.peer(0).push_blocks(3, false);
let client = net.peer(0).client().clone();
let block1 = client.header(&BlockId::Number(1)).ok().flatten().unwrap();
let block2 = client.header(&BlockId::Number(2)).ok().flatten().unwrap();
let block3 = client.header(&BlockId::Number(3)).ok().flatten().unwrap();
let client = net.peer(0).client().as_client().clone();
let hashof1 = client.expect_block_hash_from_id(&BlockId::Number(1)).unwrap();
let hashof2 = client.expect_block_hash_from_id(&BlockId::Number(2)).unwrap();
let hashof3 = client.expect_block_hash_from_id(&BlockId::Number(3)).unwrap();
let block1 = client.expect_header(hashof1).unwrap();
let block2 = client.expect_header(hashof2).unwrap();
let block3 = client.expect_header(hashof3).unwrap();
let set_id = 0;
let justification = {
@@ -1576,7 +1579,7 @@ async fn justification_with_equivocation() {
precommits,
};
GrandpaJustification::from_commit(&client.as_client(), round, commit).unwrap()
GrandpaJustification::from_commit(&client, round, commit).unwrap()
};
// the justification should include the minimal necessary vote ancestry and