Staking::{bond, set_controller} to set controllers to stash only. (#14039)

* update set_controller

* clone

* bond uses `stash`

* remove controller from bond(), chill_other test works

* remove ctlr from testing_utils &  dead ctlr -> dead payee

* mvs controllers to stashes for 3 tests

* migrate mock bond fns & fix 1 test

* mvs controllers to stashes for 7 tests

* mvs controllers to stashes for 9 tests

* remove double_controlling_should_fail

* remove double_staking_should_fail

* mvs controllers to stashes for 10 tests

* mvs controllers to stashes for 2 tests

* remove payout_creates_controller

* mvs controllers to stashes for 27 tests

* remove println!

* fix rewards_should_work

* fix test_payout_stakers

* fix bond benchmark

* clone

* rm unused import

* rm unused var

* rm controller from create_offender

* fix GenesisConfig stakers

* fix controllers in consensus pallets

* fix unqiue controller in chain_spec

* fmt

* fix create_offender

* fix set_controller benchmark

* add TODO

* create_unique_stash_controller

* staking benchmarks working

* fmt

* fix args

* rm println

* import

* import

* fix fast unstake tests

* fix staking-tests-e2e

* fix root-offenses

* fmt

* differentiate controller to stash

* bring back change_controller_works w. unique ctrl

* bring back double_staking_should_fail

* double_controlling_attempt_should_fail

* bring back payout_creates_controller

* add commnet to controller balances

* + set_controller call description

* fmt

* rm clones

* fmt

* clippy fixes

* fmt

* update README

* small fixes

* use controller_to_be_deprecated

* .comment

* comment

* bump zombienet version

* ci

---------

Co-authored-by: parity-processbot <>
Co-authored-by: Javier Viola <javier@parity.io>
This commit is contained in:
Ross Bulat
2023-05-12 02:22:15 +08:00
committed by GitHub
parent 0eeaf7709f
commit 56940bc874
20 changed files with 696 additions and 711 deletions
@@ -372,19 +372,19 @@ impl Default for StakingExtBuilder {
let stakers = vec![
// (stash, ctrl, stake, status)
// these two will be elected in the default test where we elect 2.
(11, 10, 1000, StakerStatus::<AccountId>::Validator),
(21, 20, 1000, StakerStatus::<AccountId>::Validator),
// loser validatos if validator_count() is default.
(31, 30, 500, StakerStatus::<AccountId>::Validator),
(41, 40, 500, StakerStatus::<AccountId>::Validator),
(51, 50, 500, StakerStatus::<AccountId>::Validator),
(61, 60, 500, StakerStatus::<AccountId>::Validator),
(71, 70, 500, StakerStatus::<AccountId>::Validator),
(81, 80, 500, StakerStatus::<AccountId>::Validator),
(91, 90, 500, StakerStatus::<AccountId>::Validator),
(101, 100, 500, StakerStatus::<AccountId>::Validator),
(11, 11, 1000, StakerStatus::<AccountId>::Validator),
(21, 21, 1000, StakerStatus::<AccountId>::Validator),
// loser validators if validator_count() is default.
(31, 31, 500, StakerStatus::<AccountId>::Validator),
(41, 41, 1500, StakerStatus::<AccountId>::Validator),
(51, 51, 1500, StakerStatus::<AccountId>::Validator),
(61, 61, 1500, StakerStatus::<AccountId>::Validator),
(71, 71, 1500, StakerStatus::<AccountId>::Validator),
(81, 81, 1500, StakerStatus::<AccountId>::Validator),
(91, 91, 1500, StakerStatus::<AccountId>::Validator),
(101, 101, 500, StakerStatus::<AccountId>::Validator),
// an idle validator
(201, 200, 1000, StakerStatus::<AccountId>::Idle),
(201, 201, 1000, StakerStatus::<AccountId>::Idle),
];
Self {
@@ -439,7 +439,7 @@ impl Default for BalancesExtBuilder {
(2, 20),
(3, 300),
(4, 400),
// controllers
// controllers (still used in some tests. Soon to be deprecated).
(10, 100),
(20, 100),
(30, 100),